--- parser3/src/classes/file.C 2016/07/21 18:30:10 1.243 +++ parser3/src/classes/file.C 2016/10/04 13:23:45 1.252 @@ -25,7 +25,7 @@ #include "pa_vregex.h" #include "pa_version.h" -volatile const char * IDENT_FILE_C="$Id: file.C,v 1.243 2016/07/21 18:30:10 moko Exp $"; +volatile const char * IDENT_FILE_C="$Id: file.C,v 1.252 2016/10/04 13:23:45 moko Exp $"; // defines @@ -133,7 +133,7 @@ static void _save(Request& r, MethodPara if(HashStringValue* options=params.as_hash(2)){ int valid_options=0; if(Value* vcharset_name=options->get(PA_CHARSET_NAME)){ - asked_charset=&::charsets.get(vcharset_name->as_string().change_case(r.charsets.source(), String::CC_UPPER)); + asked_charset=&pa_charsets.get(vcharset_name->as_string()); valid_options++; } if(valid_options != options->count()) @@ -153,11 +153,11 @@ static void _delete(Request& r, MethodPa if(HashStringValue* options=params.as_hash(1)){ int valid_options=0; if(Value* vkeep_empty_dirs=options->get(KEEP_EMPTY_DIRS_NAME)){ - keep_empty_dirs=r.process_to_value(*vkeep_empty_dirs).as_bool(); + keep_empty_dirs=r.process(*vkeep_empty_dirs).as_bool(); valid_options++; } if(Value* vsuppress_exception=options->get(SUPPRESS_EXCEPTION_NAME)){ - fail_on_problem=r.process_to_value(*vsuppress_exception).as_bool(); + fail_on_problem=r.process(*vsuppress_exception).as_bool(); valid_options++; } if(valid_options != options->count()) @@ -177,7 +177,7 @@ static void _move(Request& r, MethodPara if(HashStringValue* options=params.as_hash(2)){ int valid_options=0; if(Value* vkeep_empty_dirs=options->get(KEEP_EMPTY_DIRS_NAME)){ - keep_empty_dirs=r.process_to_value(*vkeep_empty_dirs).as_bool(); + keep_empty_dirs=r.process(*vkeep_empty_dirs).as_bool(); valid_options++; } if(valid_options != options->count()) @@ -262,10 +262,10 @@ static void _load(Request& r, MethodPara if(options){ options=new HashStringValue(*options); if(Value *voffset=(Value *)options->get(sql_offset_name)){ - offset=r.process_to_value(*voffset).as_int(); + offset=r.process(*voffset).as_int(); } if(Value *vlimit=(Value *)options->get(sql_limit_name)){ - limit=r.process_to_value(*vlimit).as_int(); + limit=r.process(*vlimit).as_int(); } // no check on options count here, see file_read } @@ -318,7 +318,8 @@ static void _create(Request& r, MethodPa } VString* vcontent_type=0; - Charset* asked_charset=0; + Charset* to_charset=0; + Charset* from_charset=0; if(params.count()>options_index) if(HashStringValue* options=params.as_hash(options_index)) { int valid_options=0; @@ -333,8 +334,18 @@ static void _create(Request& r, MethodPa valid_options++; } } + if(Value* vcharset_name=options->get("to-charset")) { + to_charset=&pa_charsets.get(vcharset_name->as_string()); + valid_options++; + } + if(Value* vcharset_name=options->get("from-charset")) { + from_charset=&pa_charsets.get(vcharset_name->as_string()); + valid_options++; + } if(Value* vcharset_name=options->get(PA_CHARSET_NAME)) { - asked_charset=&::charsets.get(vcharset_name->as_string().change_case(r.charsets.source(), String::CC_UPPER)); + if(to_charset) + throw Exception(PARSER_RUNTIME, 0, "charset option can not be used with to-charset"); + to_charset=&pa_charsets.get(vcharset_name->as_string()); valid_options++; } if(Value* value=options->get(CONTENT_TYPE_NAME)) { @@ -351,15 +362,24 @@ static void _create(Request& r, MethodPa if(const String* content_str=vcontent.get_string()){ String::Body body=content_str->cstr_to_string_body_untaint(String::L_AS_IS, r.connection(false), &r.charsets); // explode content, honor tainting changes - if(asked_charset && is_text) - body=Charset::transcode(body, r.charsets.source(), *asked_charset); self.set(true/*tainted*/, is_text, body.cstrm(), body.length(), file_name, vcontent_type, &r); } else { - if(asked_charset) - throw Exception(PARSER_RUNTIME, 0, "charset option can not be used with file-content"); - self.set(*vcontent.as_vfile(String::L_AS_IS), mode != 0, is_text, file_name, vcontent_type, &r); + VFile& fcontent=*vcontent.as_vfile(String::L_AS_IS); // can't be null + if(mode){ + self.set(fcontent, &is_text, file_name, vcontent_type, &r); + if(is_text && !fcontent.is_text_mode()) + from_charset=self.detect_binary_charset(from_charset); + } else { + self.set(fcontent, 0, file_name, vcontent_type, &r); + is_text=fcontent.is_text_mode(); + } } + if(to_charset || from_charset) + if(is_text) + self.transcode(from_charset ? *from_charset : r.charsets.source(), to_charset ? *to_charset : r.charsets.source()); + else + throw Exception(PARSER_RUNTIME, 0, "charset options can not be used with binary content"); } static void _stat(Request& r, MethodParams& params) { @@ -367,9 +387,7 @@ static void _stat(Request& r, MethodPara size_t size; time_t atime, mtime, ctime; - file_stat(r.absolute(lfile_name), - size, - atime, mtime, ctime); + file_stat(r.absolute(lfile_name), size, atime, mtime, ctime); VFile& self=GET_SELF(r, VFile); @@ -491,8 +509,7 @@ static void _exec_cgi(Request& r, Method if(HashStringValue* user_env=params.as_hash(param_index++, "env")) { // $.charset [previewing to handle URI pieces] if(Value* vcharset=user_env->get(CHARSET_EXEC_PARAM_NAME)) - charset=&charsets.get(vcharset->as_string() - .change_case(r.charsets.source(), String::CC_UPPER)); + charset=&pa_charsets.get(vcharset->as_string()); // $.others Append_env_pair_info info={&r.charsets, &env, 0}; @@ -532,13 +549,10 @@ static void _exec_cgi(Request& r, Method } else { Table* table=param.get_table(); if(table){ - for(size_t i=0; icount(); i++) { - append_to_argv(r, argv, table->get(i)->get(0)); - } + for(size_t j=0; jcount(); j++) + append_to_argv(r, argv, table->get(j)->get(0)); } else { - throw Exception(PARSER_RUNTIME, - 0, - "param must be string or table"); + throw Exception(PARSER_RUNTIME, 0, "param must be string or table"); } } } @@ -635,8 +649,7 @@ static void _exec_cgi(Request& r, Method // $fields << header if(header) { ArrayString rows; - size_t pos_after=0; - header->split(rows, pos_after, eol_marker); + header->split(rows, 0, eol_marker); Pass_cgi_header_attribute_info info={0, 0, 0}; info.charset=&r.charsets.source(); info.fields=&self.fields(); @@ -677,7 +690,7 @@ static void _list(Request& r, MethodPara if(HashStringValue* options=voption.get_hash()) { int valid_options=0; if(Value* vstat=options->get("stat")) { - stat=r.process_to_value(*vstat).as_bool(); + stat=r.process(*vstat).as_bool(); valid_options++; } if(Value* value=options->get("filter")) { @@ -999,11 +1012,11 @@ static void _sql(Request& r, MethodParam } if(Value* vlimit=options->get(sql_limit_name)) { valid_options++; - limit=(ulong)r.process_to_value(*vlimit).as_double(); + limit=(ulong)r.process(*vlimit).as_double(); } if(Value* voffset=options->get(sql_offset_name)) { valid_options++; - offset=(ulong)r.process_to_value(*voffset).as_double(); + offset=(ulong)r.process(*voffset).as_double(); } if(valid_options!=options->count()) throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION); @@ -1059,7 +1072,7 @@ static void _base64(Request& r, MethodPa valid_options++; } if(Value* vstrict=options->get(BASE64_STRICT_OPTION_NAME)) { - strict=r.process_to_value(*vstrict).as_bool(); + strict=r.process(*vstrict).as_bool(); valid_options++; } if(valid_options!=options->count())