--- parser3/src/classes/hash.C	2004/02/11 15:33:12	1.65
+++ parser3/src/classes/hash.C	2004/03/01 13:46:46	1.68
@@ -5,7 +5,7 @@
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
 
-static const char * const IDENT_HASH_C="$Date: 2004/02/11 15:33:12 $";
+static const char * const IDENT_HASH_C="$Date: 2004/03/01 13:46:46 $";
 
 #include "classes.h"
 #include "pa_vmethod_frame.h"
@@ -44,6 +44,8 @@ class Hash_sql_event_handlers: public SQ
 	HashStringValue* row_hash;
 	int column_index;
 	ArrayString columns;
+	bool only_one_column;
+	static VBool only_one_column_value;
 public:
 	Hash_sql_event_handlers(
 		const String& astatement_string, const char* astatement_cstr,
@@ -53,7 +55,8 @@ public:
 		distinct(adistinct),
 		rows_hash(arows_hash),
 		row_hash(0),
-		column_index(0) {
+		column_index(0),
+		only_one_column(false) {
 	}
 	bool add_column(SQL_Error& error, const char* str, size_t length) {
 		try {
@@ -65,12 +68,11 @@ public:
 		}
 	}
 	bool before_rows(SQL_Error& error) { 
-		if(columns.count()<=1) {
-			error=SQL_Error("parser.runtime",
-				/*method_name,*/
-				"column count must be more than 1 to create a hash");
+		if(columns.count()<1) {
+			error=SQL_Error("parser.runtime", "no columns");
 			return true;
 		}
+		only_one_column=columns.count()==1;
 
 		return false;
 	}
@@ -88,11 +90,11 @@ public:
 				row_hash=&row_vhash->hash();
 				if(rows_hash.put_dont_replace(cell, row_vhash)) // put. existed?
 					if(!distinct) {
-						error=SQL_Error("parser.runtime",
-							/*cell,*/
-							"duplicate key");
+						error=SQL_Error("parser.runtime", "duplicate key");
 						return true;
 					}
+				if(only_one_column)
+					row_hash->put(cell, &only_one_column_value);
 			} else
 				row_hash->put(*columns[column_index], new VString(cell));
 			column_index++;
@@ -105,6 +107,8 @@ public:
 	}
 
 };
+VBool Hash_sql_event_handlers::only_one_column_value(true);
+
 #endif
 
 static void copy_all_overwrite_to(
@@ -115,9 +119,13 @@ static void copy_all_overwrite_to(
 }
 static void _create_or_add(Request& r, MethodParams& params) {
 	if(params.count()) {
-		Value& vb=params.as_no_junction(0, "param must be hash");
-		if(HashStringValue* b=vb.get_hash())
-			b->for_each(copy_all_overwrite_to, &(GET_SELF(r, VHash).hash()));
+		Value& vsrc=params.as_no_junction(0, "param must be hash");
+		if(HashStringValue* src=vsrc.get_hash()) {
+			HashStringValue* self=&(GET_SELF(r, VHash).hash());
+			if(src==self) // same: doing nothing
+				return;
+			src->for_each(copy_all_overwrite_to, self);
+		}
 	}
 }
 
@@ -128,9 +136,15 @@ static void remove_key_from(
 	dest->remove(key);
 }
 static void _sub(Request& r, MethodParams& params) {
-	Value& vb=params.as_no_junction(0, "param must be hash");
-	if(HashStringValue* b=vb.get_hash())
-		b->for_each(remove_key_from, &GET_SELF(r, VHash).hash());
+	Value& vsrc=params.as_no_junction(0, "param must be hash");
+	if(HashStringValue* src=vsrc.get_hash()) {
+		HashStringValue* self=&(GET_SELF(r, VHash).hash());
+		if(src==self) { // same: clearing
+			self->clear();
+			return;
+		}
+		src->for_each(remove_key_from, self);
+	}
 }
 
 static void copy_all_dontoverwrite_to(
@@ -143,9 +157,9 @@ static void _union(Request& r, MethodPar
 	// dest = copy of self
 	Value& result=*new VHash(GET_SELF(r, VHash).hash());
 	// dest += b
-	Value& vb=params.as_no_junction(0, "param must be hash");
-	if(HashStringValue* b=vb.get_hash())
-		b->for_each(copy_all_dontoverwrite_to, result.get_hash());
+	Value& vsrc=params.as_no_junction(0, "param must be hash");
+	if(HashStringValue* src=vsrc.get_hash())
+		src->for_each(copy_all_dontoverwrite_to, result.get_hash());
 
 	// return result
 	r.write_no_lang(result);
@@ -257,9 +271,15 @@ static void keys_collector(
 	*row+=new String(key, String::L_TAINTED);
 	*table+=row;
 }
-static void _keys(Request& r, MethodParams&) {
+static void _keys(Request& r, MethodParams& params) {
+	const String* keys_column_name;
+	if(params.count()>0)
+		keys_column_name=&params.as_string(0, "column name must be string");
+	else 
+		keys_column_name=new String("key");
+
 	Table::columns_type columns(new ArrayString);
-	*columns+=new String("key");
+	*columns+=keys_column_name;
 	Table* table=new Table(columns);
 
 	GET_SELF(r, VHash).hash().for_each(keys_collector, table);
@@ -346,8 +366,8 @@ MHash::MHash(): Methoded("hash")
 	// ^hash:sql[query][$.limit(1) $.offset(2)]
 	add_native_method("sql", Method::CT_DYNAMIC, _sql, 1, 2);
 
-	// ^hash._keys[]
-	add_native_method("_keys", Method::CT_DYNAMIC, _keys, 0, 0);	
+	// ^hash._keys[[column name]]
+	add_native_method("_keys", Method::CT_DYNAMIC, _keys, 0, 1);	
 
 	// ^hash._count[]
 	add_native_method("_count", Method::CT_DYNAMIC, _count, 0, 0);