--- parser3/src/main/pa_exec.C 2003/03/20 08:11:14 1.48.2.18.2.2 +++ parser3/src/main/pa_exec.C 2003/03/24 13:43:41 1.48.2.18.2.9 @@ -7,7 +7,7 @@ @todo setrlimit */ -static const char* IDENT_EXEC_C="$Date: 2003/03/20 08:11:14 $"; +static const char* IDENT_EXEC_C="$Date: 2003/03/24 13:43:41 $"; #include "pa_config_includes.h" @@ -111,17 +111,14 @@ error: return result; } -static const String& read_pipeHANDLE hOutRead, const char* file_spec, - String::Untaint_lang lang){ - const String& result(new String); +static void read_pipe(String& result, HANDLE hOutRead, String::Language lang){ while(true) { - char *buf=new char[MAX_STRING]; + char *buf=new(PointerFreeGC) char[MAX_STRING]; unsigned long size; if(!ReadFile(hOutRead, buf, MAX_STRING, &size, NULL) || !size) break; - result->APPEND(buf, size, lang, file_spec, 0); - } - return result; + result.append(buf, size, lang); + } } static const char* buildCommand(const char* file_spec_cstr, const ArrayString& argv) { @@ -279,16 +276,14 @@ static int get_exit_status(int pid) { WEXITSTATUS(status) : -2; } -static const String& read_pipeint file, const char* file_spec, String::Untaint_lang lang){ - const String& result(new String); +static void read_pipe(String& result, int file, String::Language lang){ while(true) { - char *buf=new char[MAX_STRING]; + char *buf=new(PointerFreeGC) char[MAX_STRING]; ssize_t size=read(file, buf, MAX_STRING); if(size<=0) break; - result->APPEND(buf, size, lang, file_spec, 0); - } - return result; + result.append(buf, size, lang); + } } #endif @@ -296,24 +291,24 @@ static const String& read_pipeint file, #ifndef DOXYGEN struct Append_env_pair_info { #ifdef WIN32 - String* string; + String& string; + Append_env_pair_info(String& astring): string(astring) {} #else - ; char **env_ref; #endif }; #endif -///@test maybe here and at argv construction --- cstr(String::UL_UNSPECIFIED +///@test maybe here and at argv construction --- cstr(String::L_UNSPECIFIED static void append_env_pair(HashStringString::key_type key, HashStringString::value_type value, Append_env_pair_info *info) { #ifdef WIN32 - *info->string << key << "=" << value; - info->string->APPEND_AS_IS("", 1, 0, 0); // zero byte + info->string << key << "=" << value; + info->string.append("", 1, String::L_AS_IS); // zero byte #else String string; - string << key << "=" << value; + string << key << "=" << *value; - *(info->env_ref++)=string.cstr(*info->String::UL_UNSPECIFIED); + *(info->env_ref++)=string.cstr(*info->String::L_UNSPECIFIED); #endif } @@ -329,26 +324,26 @@ PA_exec_result pa_exec( #ifdef NO_PA_EXECS if(!forced_allow) throw Exception("parser.runtime", - file_spec, + &file_spec, "parser execs are disabled [recompile parser without --disable-execs configure option]"); #endif - char* file_spec_cstr=file_spec->cstr(String::UL_FILE_SPEC); + const char* file_spec_cstr=file_spec.cstr(String::L_FILE_SPEC); #ifdef WIN32 PROCESS_INFORMATION pi; HANDLE hInWrite, hOutRead, hErrRead; - const char* cmd=buildCommand(file_spec->cstr(String::UL_FILE_SPEC), argv); - const char* env_cstr; + const char* cmd=buildCommand(file_spec.cstr(String::L_FILE_SPEC), argv); + char* env_cstr; if(env) { String string; - Append_env_pair_info info={&string}; + Append_env_pair_info info(string); env->for_each(append_env_pair, &info); - env_cstr=info.string->cstr(String::UL_UNSPECIFIED); + env_cstr=info.string.cstrm(String::L_UNSPECIFIED); } if(DWORD error=CreateHiddenConsoleProcess(cmd, env_cstr, &pi, &hInWrite, &hOutRead, &hErrRead)) { char szErrorDesc[MAX_STRING]; - const char *param="the file you tried to run"; + const char* param="the file you tried to run"; size_t error_size=FormatMessage( FORMAT_MESSAGE_FROM_SYSTEM|FORMAT_MESSAGE_ARGUMENT_ARRAY , NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL), @@ -357,21 +352,21 @@ PA_exec_result pa_exec( szErrorDesc[error_size-3]=0; throw Exception(0, - file_spec, + &file_spec, "exec failed - %s (%ld). Consider adding shbang line (#!x:\\interpreter\\command line)", error_size?szErrorDesc:"", (long)error); } else { const char* in_cstr=in.cstr(); DWORD written_size; - WriteFile(hInWrite, in_cstr, in.size(), &written_size, NULL); + WriteFile(hInWrite, in_cstr, in.length(), &written_size, NULL); // EOF for stupid text reads // normally they should read CONTENT_LENGTH bytes, // without this char WriteFile(hInWrite, "\x1A", 1, &written_size, NULL); CloseHandle(hInWrite); - result.out=read_pipe(hOutRead, file_spec_cstr, String::UL_AS_IS); + read_pipe(result.out, hOutRead, String::L_AS_IS); CloseHandle(hOutRead); - result.err=read_pipe(hErrRead, file_spec_cstr, String::UL_TAINTED); + read_pipe(result.err, hErrRead, String::L_TAINTED); CloseHandle(hErrRead); /* from http://www.apache.org/websrc/cvsweb.cgi/apache-1.3/src/main/util_script.c?rev=1.151&content-type=text/vnd.viewcvs-markup @@ -418,7 +413,7 @@ from http://www.apache.org/websrc/cvsweb char **env_cstrs; if(env) { - env_cstrs=new char *[env->count()+1/*0*/]; + env_cstrs=new(PointerFreeGC) char *[env->count()+1/*0*/]; Append_env_pair_info info={&env_cstrs}; env->for_each(append_env_pair, &info); *info.env_ref=0; @@ -431,14 +426,14 @@ from http://www.apache.org/websrc/cvsweb &pipe_write, &pipe_read, &pipe_err); if(pid>0) { // in child - if(in.size()) {// there is some in data + if(in.length()) {// there is some in data const char* in_cstr=in.cstr(); - write(pipe_write, in_cstr, in.size()); + write(pipe_write, in_cstr, in.length()); } close(pipe_write); - result.out=read_pipe(pipe_read, file_spec_cstr, String::UL_AS_IS); + result.out=read_pipe(pipe_read, file_spec_cstr, String::L_AS_IS); close(pipe_read); - result.err=read_pipe(pipe_err, file_spec_cstr, String::UL_TAINTED); + result.err=read_pipe(pipe_err, file_spec_cstr, String::L_TAINTED); close(pipe_err); result.status=get_exit_status(pid); // negative may mean "-errno[execl()]"