--- parser3/src/main/pa_string.C	2023/09/26 20:49:10	1.269
+++ parser3/src/main/pa_string.C	2024/11/10 20:46:08	1.280
@@ -1,7 +1,7 @@
 /** @file
 	Parser: string class. @see untalength_t.C.
 
-	Copyright (c) 2001-2023 Art. Lebedev Studio (http://www.artlebedev.com)
+	Copyright (c) 2001-2024 Art. Lebedev Studio (http://www.artlebedev.com)
 	Authors: Konstantin Morshnev <moko@design.ru>, Alexandr Petrosian <paf@design.ru>
 */
 
@@ -12,7 +12,7 @@
 #include "pa_charset.h"
 #include "pa_vregex.h"
 
-volatile const char * IDENT_PA_STRING_C="$Id: pa_string.C,v 1.269 2023/09/26 20:49:10 moko Exp $" IDENT_PA_STRING_H;
+volatile const char * IDENT_PA_STRING_C="$Id: pa_string.C,v 1.280 2024/11/10 20:46:08 moko Exp $" IDENT_PA_STRING_H;
 
 const String String::Empty;
 
@@ -46,9 +46,10 @@ template<typename T> inline T pa_ato_any
 		}
 	}
 
-	if (base < 2 || base > 16) { /* illegal base */
+	if (base < 2 || base > 16) /* illegal base */
 		throw Exception(PARSER_RUNTIME, 0, "base to must be an integer from 2 to 16");
-	}
+	if (*pos == '-')
+		throw Exception("number.format", problem_source, problem_source ? "out of range (negative)" : "'%s' is out if range (negative)", str);
 
 	T cutoff = max / base;
 	int cutoff_digit = (int)(max - cutoff * base);
@@ -80,7 +81,7 @@ template<typename T> inline T pa_ato_any
 
 	while(char c=*pos++)
 		if(!isspace(c))
-			throw Exception("number.format", problem_source, problem_source ? "invalid number (int)" : "'%s' is invalid number (int)", str);
+			throw Exception("number.format", problem_source, problem_source ? "invalid number (int)" : "'%s' is an invalid number (int)", str);
 
 	return result;
 }
@@ -109,12 +110,17 @@ int pa_atoi(const char* str, int base, c
 	if(!*str)
 		return 0;
 
+	const char *str_copy=str;
 	bool negative=false;
 	if(str[0]=='-') {
 		negative=true;
 		str++;
+		if(!*str || isspace(*str))
+			throw Exception("number.format", problem_source, problem_source ? "invalid number (int)" : "'%s' is an invalid number (int)", str_copy);
 	} else if(str[0]=='+') {
 		str++;
+		if(!*str || isspace(*str))
+			throw Exception("number.format", problem_source, problem_source ? "invalid number (int)" : "'%s' is an invalid number (int)", str_copy);
 	}
 
 	unsigned int result=pa_atoui(str, base, problem_source);
@@ -124,11 +130,11 @@ int pa_atoi(const char* str, int base, c
 	
 	if(result<=INT_MAX)
 		return (int)result;
-	
-	throw Exception("number.format", problem_source, problem_source ? "out of range (int)" : "'%s' is out of range (int)", str);
+
+	throw Exception("number.format", problem_source, problem_source ? "out of range (int)" : "'%s' is out of range (int)", str_copy);
 }
 
-double pa_atod(const char* str, const String* problem_source) {
+double pa_atod(const char* str, const String* problem_source /* never null */) {
 	if(!str)
 		return 0;
 
@@ -142,8 +148,12 @@ double pa_atod(const char* str, const St
 	if(str[0]=='-') {
 		negative=true;
 		str++;
+		if(!*str || isspace(*str))
+			throw Exception("number.format", problem_source, "invalid number (double)");
 	} else if(str[0]=='+') {
 		str++;
+		if(!*str || isspace(*str))
+			throw Exception("number.format", problem_source, "invalid number (double)");
 	}
 
 	double result;
@@ -161,9 +171,9 @@ double pa_atod(const char* str, const St
 	char *error_pos;
 	result=strtod(str, &error_pos);
 
-	while(char c=*error_pos++)
-		if(!isspace((unsigned char)c))
-			throw Exception("number.format", problem_source, problem_source ? "invalid number (double)" : "'%s' is invalid number (double)", str);
+	while(const char c=*error_pos++)
+		if(!isspace(c))
+			throw Exception("number.format", problem_source, "invalid number (double)");
 
 	return negative ? -result : result;
 }
@@ -179,7 +189,7 @@ typedef struct {
 
 static int CORD_range_contains_chr_greater_then_proc(char c, size_t size, void* client_data)
 {
-	register chr_data * d = (chr_data *)client_data;
+	chr_data * d = (chr_data *)client_data;
 
 	if (d -> countdown<=0) return(2);
 	d -> countdown -= size;
@@ -223,21 +233,20 @@ public:
 		*this+=new String("match");
 		*this+=new String("postmatch");
 		for(int i=0; i<MAX_MATCH_GROUPS; i++) {
-			*this+=new String(String::Body::Format(1+i), String::L_CLEAN);
+			*this+=new String(pa_uitoa(1+i), String::L_CLEAN);
 		}
 	}
 };
 
-Table string_match_table_template(new String_match_table_template_columns);
+static Table &string_match_table_template(){
+	static Table *singleton=NULL;
+	if(!singleton)
+		singleton=new Table(new String_match_table_template_columns);
+	return *singleton;
+}
 
 // String::Body methods
 
-String::Body String::Body::Format(int value) {
-	char local[MAX_NUMBER];
-	size_t length=snprintf(local, MAX_NUMBER, "%d", value);
-	return String::Body(pa_strdup(local, length));
-}
-
 String::Body String::Body::trim(String::Trim_kind kind, const char* chars, size_t* out_start, size_t* out_length, Charset* source_charset) const {
 	size_t our_length=length();
 	if(!our_length)
@@ -652,11 +661,11 @@ Table* String::match(VRegex* vregex, Row
 
 	const char* subject=cstr();
 	size_t subject_length=length();
-	const int ovector_size=(1/*match*/+MAX_MATCH_GROUPS)*3;
+	const int ovector_size=(1/*match*/+MAX_MATCH_GROUPS)*3; /* 1/3 is used as workspace by pcre_exec() */
 	int ovector[ovector_size];
 
 	Table::Action_options table_options;
-	Table& table=*new Table(string_match_table_template, table_options);
+	Table& table=*new Table(string_match_table_template(), table_options);
 
 	int prestart=0;
 	int poststart=0;
@@ -696,7 +705,7 @@ Table* String::match(VRegex* vregex, Row
 		matches_count++;
 		row_action(table, row, prestart - !action_was_executed, prefinish, poststart, postfinish, info);
 
-		if(!global || poststart>=subject_length) // last step, avoid prestart++ after last char
+		if(!global || (size_t)poststart>=subject_length) // last step, avoid prestart++ after last char
 			break;
 
 		prestart=poststart;