--- sql/odbc/parser3odbc.C	2002/12/09 12:33:28	1.12
+++ sql/odbc/parser3odbc.C	2004/01/26 15:13:13	1.18
@@ -1,11 +1,11 @@
 /** @file
 	Parser ODBC driver.
 
-	Copyright(c) 2001, 2002 ArtLebedev Group (http://www.artlebedev.com)
+	Copyright(c) 2001, 2003 ArtLebedev Group (http://www.artlebedev.com)
 
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
-static const char *RCSId="$Id: parser3odbc.C,v 1.12 2002/12/09 12:33:28 paf Exp $"; 
+static const char *RCSId="$Id: parser3odbc.C,v 1.18 2004/01/26 15:13:13 paf Exp $"; 
 
 #ifndef _MSC_VER
 #	error compile ISAPI module with MSVC [no urge for now to make it autoconf-ed (PAF)]
@@ -18,6 +18,7 @@ static const char *RCSId="$Id: parser3od
 
 #include "pa_sql_driver.h"
 
+#define WINVER 0x0400
 #include <AFXDB.H>
 
 // defines
@@ -55,6 +56,12 @@ static char *lsplit(char *string, char d
     return 0;
 }
 
+struct Connection {
+	SQL_Driver_services* services;
+
+	CDatabase* db;
+};
+
 /**
 	ODBC server driver
 */
@@ -75,78 +82,78 @@ public:
 	void connect(
 		char *used_only_in_connect_url, 
 		SQL_Driver_services& services, 
-		void **connection ///< output: CDatabase *
+		void **connection_ref ///< output: Connection*
 		) {
 	//	_asm int 3;
-		CDatabase *db;
+		Connection& connection=*(Connection  *)::calloc(sizeof(Connection), 1);
+		*connection_ref=&connection;
+		connection.services=&services;
+
 		TRY {
-			db=new CDatabase();
-			db->OpenEx(used_only_in_connect_url, CDatabase::noOdbcDialog);
-			db->BeginTrans();
+			connection.db=new CDatabase();
+			connection.db->OpenEx(used_only_in_connect_url, CDatabase::noOdbcDialog);
+			connection.db->BeginTrans();
 		} 
 		CATCH_ALL (e) {
 			_throw(services, e);
-			db=0; // calm, compiler
 		}
 		END_CATCH_ALL
-
-		*(CDatabase **)connection=db;
 	}
-	void disconnect(void *connection) {
-		CDatabase *db=static_cast<CDatabase *>(connection);
+	void disconnect(void *aconnection) {
+		Connection& connection=*static_cast<Connection*>(aconnection);
 		TRY
-			delete db;
+			delete connection.db;
+			connection.db=0;
 		CATCH_ALL (e) {
 			// nothing
 		}
 		END_CATCH_ALL
 	}
-	void commit(SQL_Driver_services& services, void *connection) {
-		CDatabase *db=static_cast<CDatabase *>(connection);
+	void commit(void *aconnection) {
+		Connection& connection=*static_cast<Connection*>(aconnection);
 		TRY
-			db->CommitTrans();
-			db->BeginTrans();
+			connection.db->CommitTrans();
+			connection.db->BeginTrans();
 		CATCH_ALL (e) {
-			_throw(services, e);
+			_throw(*connection.services, e);
 		}
 		END_CATCH_ALL
 	}
-	void rollback(SQL_Driver_services& services, void *connection) {
-		CDatabase *db=static_cast<CDatabase *>(connection);
+	void rollback(void *aconnection) {
+		Connection& connection=*static_cast<Connection*>(aconnection);
 		TRY
-			db->Rollback();
-			db->BeginTrans();
+			connection.db->Rollback();
+			connection.db->BeginTrans();
 		CATCH_ALL (e) {
-			_throw(services, e);
+			_throw(*connection.services, e);
 		}
 		END_CATCH_ALL
 	}
 
-	bool ping(SQL_Driver_services&, void *connection) {
+	bool ping(void *connection) {
 		return true;
 	}
 
-	unsigned int quote(
-		SQL_Driver_services&, void *connection,
-		char *to, const char *from, unsigned int length) {
-		if(to) { // store mode
-			unsigned int result=length;
-			while(length--) {
-				if(*from=='\'') { // ' -> ''
-					*to++='\''; result++;
-				}
-				*to++=*from++;
+	const char* quote(void *aconnection, const char *from, unsigned int length) {
+		Connection& connection=*static_cast<Connection*>(aconnection);
+		char *result=(char*)connection.services->malloc_atomic(length*2+1);
+		char *to=result;
+		while(length--) {
+			if(*from=='\'') { // ' -> ''
+				*to++='\'';
 			}
-			return result;
-		} else // estimate mode
-			return length*2;
+			*to++=*from++;
+		}
+		*to=0;
+		return result;
 	}
-	void query(
-		SQL_Driver_services& services, void *connection, 
+	void query(void *aconnection, 
 		const char *statement, unsigned long offset, unsigned long limit,
 		SQL_Driver_query_event_handlers& handlers) {
 
-		CDatabase *db=static_cast<CDatabase *>(connection);
+		Connection& connection=*static_cast<Connection*>(aconnection);
+		CDatabase *db=connection.db;
+		SQL_Driver_services& services=*connection.services;
 
 		while(isspace(*statement)) 
 			statement++;
@@ -201,12 +208,12 @@ public:
 					rs.GetODBCFieldInfo(i, fieldinfo);
 					column_types[i]=fieldinfo.m_nSQLType;
 					size_t size=fieldinfo.m_strName.GetLength();
-					void *ptr=0;
+					char *str=0;
 					if(size) {
-						ptr=services.malloc(size);
-						memcpy(ptr, (char *)LPCTSTR(fieldinfo.m_strName), size);
+						str=(char*)services.malloc_atomic(size+1);
+						memcpy(str, (char *)LPCTSTR(fieldinfo.m_strName), size+1);
 					}
-					CHECK(handlers.add_column(sql_error, ptr, size));
+					CHECK(handlers.add_column(sql_error, str, size));
 				}
 
 				CHECK(handlers.before_rows(sql_error));
@@ -219,24 +226,25 @@ public:
 						CHECK(handlers.add_row(sql_error));
 						for(int i=0; i<column_count; i++) {
 							size_t size;
-							void *ptr;
+							char* str;
 							switch(column_types[i]) {
 							//case xBOOL:
 //							case SQL_INTEGER: // serg@design.ru did that in parser2. test first!
-							//case SQL_DATETIME:
-							case SQL_BINARY:
+							//case SQL_DATETIME: << default: handles that more properly (?)
+							case SQL_BINARY: 
 							case SQL_VARBINARY:
 							case SQL_LONGVARBINARY:
 							case SQL_SMALLDATETIME:
+							//case SQL_NVARCHAR: // mfc 7.1 has errors with nvarchar(length): SQLGetData in dbcore.cpp truncates last byte for unknown reason.  could be fixed by uncommenting this and handing DBVT_WSTRING inside, but it's UNICODE
 								rs.GetFieldValue(i, v);
-								getFromDBVariant(services, v, ptr, size);
+								getFromDBVariant(services, v, str, size);
 								break;
 							default:
 								rs.GetFieldValue(i, s);
-								getFromString(services, s, ptr, size);
+								getFromString(services, s, str, size);
 								break;
 							}
-							CHECK(handlers.add_row_cell(sql_error, ptr, size));
+							CHECK(handlers.add_row_cell(sql_error, str, size));
 						}
 					}
 					rs.MoveNext();  row++;
@@ -251,29 +259,40 @@ public:
 		} END_CATCH_ALL
 	}
 
-	void getFromDBVariant(SQL_Driver_services& services, CDBVariant& v, void *& ptr, size_t& size) {
+	void getFromDBVariant(SQL_Driver_services& services, CDBVariant& v, char*& str, size_t& length) {
 		switch(v.m_dwType) {
+		case DBVT_BINARY: /* << would cause problems with current String implementation
+				  now falling into NULL case, effectively ignoring such columns [not failing]
+			{
+				if(length=v.m_pbinary->m_dwDataLength) {
+					str=services.malloc_atomic(length+1);
+					memcpy(ptr, ::GlobalLock(v.m_pbinary->m_hData), length);
+					::GlobalUnlock(v.m_pbinary->m_hData);
+				} else 
+					str=0;
+				break;
+			}*/ 
 		case DBVT_NULL: // No union member is valid for access. 
-			ptr=0;
-			size=0;
+			str=0;
+			length=0;
 			break;
 /*		case DBVT_BOOL:
 			ptr=v.m_boolVal?"1":"0";
-			size=1;
+			length=1;
 			break;*/
 /*							case DBVT_UCHAR:
-			size=strlen(ptr=v.m_chVal);
+			length=strlen(ptr=v.m_chVal);
 			break;
 		case DBVT_SHORT:
 			char buf[MAX_NUMBER];
-			size=snprintf(HEAPIZE buf, "%d", v.m_iVal);
+			length=snprintf(HEAPIZE buf, "%d", v.m_iVal);
 			break;*/
 /*		case DBVT_LONG: 
 			{
 				char local_buf[MAX_NUMBER];
-				size=snprintf(local_buf, MAX_NUMBER, "%ld", v.m_lVal);
-				ptr=services.malloc(size);
-				memcpy(ptr, local_buf, size);
+				length=snprintf(local_buf, MAX_NUMBER, "%ld", v.m_lVal);
+				ptr=services.malloc_atomic(length);
+				memcpy(ptr, local_buf, length);
 				break;
 			}*/
 		/*case DBVT_SINGLE:
@@ -281,20 +300,10 @@ public:
 			break;
 	case DBVT_DOUBLE m_dblVal 
 	case DBVT_STRING m_pstring */ 
-		case DBVT_BINARY:
-			{
-				if(size=v.m_pbinary->m_dwDataLength) {
-					ptr=services.malloc(size);
-					memcpy(ptr, ::GlobalLock(v.m_pbinary->m_hData), size);
-					::GlobalUnlock(v.m_pbinary->m_hData);
-				} else 
-					ptr=0;
-				break;
-			}
 		case DBVT_DATE:
 			{
 				char local_buf[MAX_STRING];
-				size=snprintf(local_buf, MAX_STRING, 
+				length=snprintf(local_buf, MAX_STRING, 
 					"%04d-%02d-%02d %02d:%02d:%02d.%03d",
 					v.m_pdate->year, 
 					v.m_pdate->month,
@@ -303,8 +312,8 @@ public:
 					v.m_pdate->minute,
 					v.m_pdate->second,
 					v.m_pdate->fraction);
-				ptr=services.malloc(size);
-				memcpy(ptr, local_buf, size);
+				str=(char*)services.malloc_atomic(length+1);
+				memcpy(str, local_buf, length+1);
 				break;
 			}
 		default:
@@ -315,15 +324,15 @@ public:
 		}
 	}
 
-	void getFromString(SQL_Driver_services& services, CString& s, void *& ptr, size_t& size) {
+	void getFromString(SQL_Driver_services& services, CString& s, char*& astr, size_t& length) {
 		if(s.IsEmpty()) {
-			ptr=0;
-			size=0;
+			astr=0;
+			length=0;
 		} else {
 			const char *cstr=LPCTSTR(s);
-			size=strlen(cstr); //string.GetLength() works wrong with non-string types: 
-			ptr=services.malloc(size);
-			memcpy(ptr, cstr, size);
+			length=strlen(cstr); //string.GetLength() works wrong with non-string types: 
+			astr=(char*)services.malloc_atomic(length+1);
+			memcpy(astr, cstr, length+1);
 		}
 	}