--- sql/odbc/parser3odbc.C	2002/05/15 14:06:07	1.9
+++ sql/odbc/parser3odbc.C	2003/11/19 12:57:43	1.17
@@ -1,11 +1,11 @@
 /** @file
 	Parser ODBC driver.
 
-	Copyright(c) 2001, 2002 ArtLebedev Group (http://www.artlebedev.com)
+	Copyright(c) 2001, 2003 ArtLebedev Group (http://www.artlebedev.com)
 
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
-static const char *RCSId="$Id: parser3odbc.C,v 1.9 2002/05/15 14:06:07 paf Exp $"; 
+static const char *RCSId="$Id: parser3odbc.C,v 1.17 2003/11/19 12:57:43 paf Exp $"; 
 
 #ifndef _MSC_VER
 #	error compile ISAPI module with MSVC [no urge for now to make it autoconf-ed (PAF)]
@@ -18,12 +18,17 @@ static const char *RCSId="$Id: parser3od
 
 #include "pa_sql_driver.h"
 
+#define WINVER 0x0400
 #include <AFXDB.H>
 
+// defines
+
+#define MAX_COLS 500
+
 #define MAX_STRING 0x400
 #define MAX_NUMBER 40
 
-// MSSQL2000
+// new in MSSQL2000, no MFC constants
 #ifndef SQL_NVARCHAR
 #define SQL_NVARCHAR (-9)
 #endif
@@ -122,20 +127,19 @@ public:
 		return true;
 	}
 
-	unsigned int quote(
-		SQL_Driver_services&, void *connection,
-		char *to, const char *from, unsigned int length) {
-		if(to) { // store mode
-			unsigned int result=length;
-			while(length--) {
-				if(*from=='\'') { // ' -> ''
-					*to++='\''; result++;
-				}
-				*to++=*from++;
+	const char* quote(
+		SQL_Driver_services& services, void *connection,
+		const char *from, unsigned int length) {
+		char *result=(char*)services.malloc_atomic(length*2+1);
+		char *to=result;
+		while(length--) {
+			if(*from=='\'') { // ' -> ''
+				*to++='\'';
 			}
-			return result;
-		} else // estimate mode
-			return length*2;
+			*to++=*from++;
+		}
+		*to=0;
+		return result;
 	}
 	void query(
 		SQL_Driver_services& services, void *connection, 
@@ -184,50 +188,56 @@ public:
 				if(!column_count)
 					services._throw("result contains no columns");
 
+				SWORD column_types[MAX_COLS];
+				if(column_count>MAX_COLS)
+					column_count=MAX_COLS;
+
+				SQL_Error sql_error;
+#define CHECK(afailed) if(afailed) services._throw(sql_error)
+
 				for(int i=0; i<column_count; i++){
 					CString string;
 					CODBCFieldInfo fieldinfo;
 					rs.GetODBCFieldInfo(i, fieldinfo);
+					column_types[i]=fieldinfo.m_nSQLType;
 					size_t size=fieldinfo.m_strName.GetLength();
-					void *ptr=0;
+					char *str=0;
 					if(size) {
-						ptr=services.malloc(size);
-						memcpy(ptr, (char *)LPCTSTR(fieldinfo.m_strName), size);
+						str=(char*)services.malloc_atomic(size+1);
+						memcpy(str, (char *)LPCTSTR(fieldinfo.m_strName), size+1);
 					}
-					handlers.add_column(ptr, size);
+					CHECK(handlers.add_column(sql_error, str, size));
 				}
 
-				handlers.before_rows();
+				CHECK(handlers.before_rows(sql_error));
 
 				unsigned long row=0;
+				CDBVariant v;
+				CString s;
 				while(!rs.IsEOF() && (!limit||(row<offset+limit))) {
 					if(row>=offset) {
-						handlers.add_row();
-						for(int i=0; i<column_count; i++) 						{
-							CODBCFieldInfo fieldinfo;
-							rs.GetODBCFieldInfo(i, fieldinfo);
+						CHECK(handlers.add_row(sql_error));
+						for(int i=0; i<column_count; i++) {
 							size_t size;
-							void *ptr;
-							switch(fieldinfo.m_nSQLType) {
+							char* str;
+							switch(column_types[i]) {
 							//case xBOOL:
 //							case SQL_INTEGER: // serg@design.ru did that in parser2. test first!
-							//case SQL_DATETIME:
+							//case SQL_DATETIME: << default: handles that more properly (?)
+							case SQL_BINARY: 
+							case SQL_VARBINARY:
+							case SQL_LONGVARBINARY:
 							case SQL_SMALLDATETIME:
-								{
-									CDBVariant v;
-									rs.GetFieldValue(i, v);
-									getFromDBVariant(services, v, ptr, size);
-									break;
-								}
+							//case SQL_NVARCHAR: // mfc 7.1 has errors with nvarchar(length): SQLGetData in dbcore.cpp truncates last byte for unknown reason.  could be fixed by uncommenting this and handing DBVT_WSTRING inside, but it's UNICODE
+								rs.GetFieldValue(i, v);
+								getFromDBVariant(services, v, str, size);
+								break;
 							default:
-								{
-									CString s;
-									rs.GetFieldValue(i, s);
-									getFromString(services, s, ptr, size);
-									break;
-								}
+								rs.GetFieldValue(i, s);
+								getFromString(services, s, str, size);
+								break;
 							}
-							handlers.add_row_cell(ptr, size);
+							CHECK(handlers.add_row_cell(sql_error, str, size));
 						}
 					}
 					rs.MoveNext();  row++;
@@ -242,41 +252,51 @@ public:
 		} END_CATCH_ALL
 	}
 
-	void getFromDBVariant(SQL_Driver_services& services, CDBVariant& v, void *& ptr, size_t& size) {
+	void getFromDBVariant(SQL_Driver_services& services, CDBVariant& v, char*& str, size_t& length) {
 		switch(v.m_dwType) {
+		case DBVT_BINARY: /* << would cause problems with current String implementation
+				  now falling into NULL case, effectively ignoring such columns [not failing]
+			{
+				if(length=v.m_pbinary->m_dwDataLength) {
+					str=services.malloc_atomic(length+1);
+					memcpy(ptr, ::GlobalLock(v.m_pbinary->m_hData), length);
+					::GlobalUnlock(v.m_pbinary->m_hData);
+				} else 
+					str=0;
+				break;
+			}*/ 
 		case DBVT_NULL: // No union member is valid for access. 
-			ptr=0;
-			size=0;
+			str=0;
+			length=0;
 			break;
 /*		case DBVT_BOOL:
 			ptr=v.m_boolVal?"1":"0";
-			size=1;
+			length=1;
 			break;*/
 /*							case DBVT_UCHAR:
-			size=strlen(ptr=v.m_chVal);
+			length=strlen(ptr=v.m_chVal);
 			break;
 		case DBVT_SHORT:
 			char buf[MAX_NUMBER];
-			size=snprintf(HEAPIZE buf, "%d", v.m_iVal);
+			length=snprintf(HEAPIZE buf, "%d", v.m_iVal);
 			break;*/
 /*		case DBVT_LONG: 
 			{
 				char local_buf[MAX_NUMBER];
-				size=snprintf(local_buf, MAX_NUMBER, "%ld", v.m_lVal);
-				ptr=services.malloc(size);
-				memcpy(ptr, local_buf, size);
+				length=snprintf(local_buf, MAX_NUMBER, "%ld", v.m_lVal);
+				ptr=services.malloc_atomic(length);
+				memcpy(ptr, local_buf, length);
 				break;
 			}*/
 		/*case DBVT_SINGLE:
 			m_fltVal 
 			break;
 	case DBVT_DOUBLE m_dblVal 
-	case DBVT_STRING m_pstring 
-	case DBVT_BINARY m_pbinary */
+	case DBVT_STRING m_pstring */ 
 		case DBVT_DATE:
 			{
 				char local_buf[MAX_STRING];
-				size=snprintf(local_buf, MAX_STRING, 
+				length=snprintf(local_buf, MAX_STRING, 
 					"%04d-%02d-%02d %02d:%02d:%02d.%03d",
 					v.m_pdate->year, 
 					v.m_pdate->month,
@@ -285,8 +305,8 @@ public:
 					v.m_pdate->minute,
 					v.m_pdate->second,
 					v.m_pdate->fraction);
-				ptr=services.malloc(size);
-				memcpy(ptr, local_buf, size);
+				str=(char*)services.malloc_atomic(length+1);
+				memcpy(str, local_buf, length+1);
 				break;
 			}
 		default:
@@ -297,15 +317,15 @@ public:
 		}
 	}
 
-	void getFromString(SQL_Driver_services& services, CString& s, void *& ptr, size_t& size) {
+	void getFromString(SQL_Driver_services& services, CString& s, char*& astr, size_t& length) {
 		if(s.IsEmpty()) {
-			ptr=0;
-			size=0;
+			astr=0;
+			length=0;
 		} else {
 			const char *cstr=LPCTSTR(s);
-			size=strlen(cstr); //string.GetLength() works wrong with non-string types: 
-			ptr=services.malloc(size);
-			memcpy(ptr, cstr, size);
+			length=strlen(cstr); //string.GetLength() works wrong with non-string types: 
+			astr=(char*)services.malloc_atomic(length+1);
+			memcpy(astr, cstr, length+1);
 		}
 	}