--- sql/oracle/parser3oracle.C	2003/07/24 10:09:40	1.32
+++ sql/oracle/parser3oracle.C	2003/12/15 08:57:22	1.41
@@ -7,7 +7,7 @@
 
 	2001.07.30 using Oracle 8.1.6 [@test tested with Oracle 7.x.x]
 */
-static const char *RCSId="$Id: parser3oracle.C,v 1.32 2003/07/24 10:09:40 paf Exp $"; 
+static const char *RCSId="$Id: parser3oracle.C,v 1.41 2003/12/15 08:57:22 paf Exp $"; 
 
 #include "config_includes.h"
 
@@ -38,7 +38,7 @@ inline int max(int a, int b) { return a>
 inline int min(int a, int b){ return a<b?a:b; }
 #endif
 
-/// @test setenv version memory. maybe key/value needs ::malloc_atomic?
+/// @todo small memory leaks here
 static int pa_setenv(const char *name, const char *value, bool do_append) {
 	const char *prev_value=0;
 	if(do_append)
@@ -70,7 +70,7 @@ static int pa_setenv(const char *name, c
 	if(value) {
 		if(prev_value) {
 			// MEM_LEAK_HERE
-			char *buf=(char *)::malloc_atomic(strlen(prev_value)
+			char *buf=(char *)::malloc(strlen(prev_value)
 				+strlen(value)
 				+1);
 			strcpy(buf, prev_value);
@@ -104,11 +104,17 @@ static char *lsplit(char **string_ref, c
     return result;
 }
 
-static const char *options2env(char *options) {
+static const char *options2env(char *options, bool* LowerCaseColumnNames) {
 	while(options) {
 		if(char *key=lsplit(&options, '&')) {
 			if(*key) {
 				if(char *value=lsplit(key, '=')) {
+					if( strcmp( key, "LowerCaseColumnNames" ) == 0 ) {
+						if( LowerCaseColumnNames )
+							*LowerCaseColumnNames = atoi(value)!=0;
+						continue;
+					}
+
 					bool do_append=key[strlen(key)-1]=='+'; // PATH+=
 					if(do_append)
 						key[strlen(key)-1]=0; // remove trailing +
@@ -138,6 +144,8 @@ struct OracleSQL_connection_struct {
 	OCIError *errhp;
 	OCISvcCtx *svchp;
 	OCISession *usrhp;
+
+	bool bLowerCaseColumnNames;
 };
 
 struct OracleSQL_query_lobs {
@@ -206,7 +214,7 @@ public:
 		const char *error=dlopen_file_spec?
 			dlink(dlopen_file_spec):"client library column is empty";
 		if(!error) {
-			error=options2env(options);
+			error=options2env(options, 0);
 
 			if(!error)
 				OCIInitialize((ub4)OCI_THREADED/*| OCI_OBJECT*/, (dvoid *)0, 
@@ -237,6 +245,7 @@ public:
 		// connections are cross-request, do not use services._alloc [linked with request]
 		OracleSQL_connection_struct &cs=
 			*(OracleSQL_connection_struct  *)::calloc(sizeof(OracleSQL_connection_struct), 1);
+		cs.bLowerCaseColumnNames = true;
 
 		char *user=used_only_in_connect_url;
 		char *service=lsplit(user, '@');
@@ -246,7 +255,7 @@ public:
 		if(!(user && pwd && service))
 			services._throw("mailformed connect part, must be 'user:pass@service'");
 
-		if(const char *error=options2env(options))
+		if(const char *error=options2env(options, &cs.bLowerCaseColumnNames))
 			services._throw(error);
 
 		if(setjmp(cs.mark))
@@ -368,7 +377,7 @@ public:
 		while(length--) {
 			switch(*from) {
 			case '\'': // "'" -> "''"
-				*to++='\''; result++;
+				*to++='\'';
 				break;
 			}
 			*to++=*from++;
@@ -467,6 +476,7 @@ private: // private funcs
 				o[0]=='/' &&
 				o[1]=='*' && 
 				o[2]=='*') { // name start
+				const char* saved_o=o;
 				o+=3;
 				const char *name_begin=o;
 				while(*o)
@@ -475,6 +485,7 @@ private: // private funcs
 						o[1]=='*' &&
 						o[2]=='/' &&
 						o[3]=='\'') { // name end
+						saved_o=0; // found, marking that
 						const char *name_end=o;
 						o+=4;
 						OracleSQL_query_lobs::Item &item=lobs.items[lobs.count++];
@@ -506,6 +517,10 @@ private: // private funcs
 						break;
 					} else
 						o++; // /**skip**/'xxx'
+				if(saved_o) {
+					o=saved_o;
+					*n++=*o++;
+				}
 			} else
 				*n++=*o++;
 		}
@@ -518,17 +533,12 @@ private: // private funcs
 				if(i)
 					*n++=',';
 				n+=sprintf(n, "%.*s", lobs.items[i].name_size, lobs.items[i].name_ptr);
-				/*memcpy(n, lobs.items[i].name_ptr, lobs.items[i].name_size);
-				n+=lobs.items[i].name_size;*/
 			}
 			n+=sprintf(n, " into ");
 			for(i=0; i<lobs.count; i++) {
 				if(i)
-					*n++='x';
+					*n++=',';
 				n+=sprintf(n, ":%.*s", lobs.items[i].name_size, lobs.items[i].name_ptr);
-				/**n++=':';
-				memcpy(n, lobs.items[i].name_ptr, lobs.items[i].name_size);
-				n+=lobs.items[i].name_size;*/
 			}
 		}
 
@@ -618,7 +628,7 @@ private: // private funcs
 		ub2                    dtype;
 		text                  *col_name;
 
-		struct {
+		struct Col {
 			ub2 type;
 			char *str;
 			OCILobLocator *var;
@@ -655,11 +665,16 @@ private: // private funcs
 					(dvoid**) &col_name, (ub4 *) &col_name_len, (ub4)OCI_ATTR_NAME, 
 					(OCIError *)cs.errhp));
 				
+				Col& col=cols[column_count-1];
 				{
-					size_t size=(size_t)col_name_len;
-					char *ptr=(char *)services.malloc_atomic(size);
-					tolower(ptr, (char *)col_name, size);
-					check(cs, handlers.add_column(cs.sql_error, ptr, size));
+					size_t length=(size_t)col_name_len;
+					char *ptr=(char *)services.malloc_atomic(length+1);
+					if( cs.bLowerCaseColumnNames ) 
+						tolower(ptr, (char *)col_name, length);
+					else
+						memcpy(ptr, col_name, length);						
+					ptr[length]=0;
+					check(cs, handlers.add_column(cs.sql_error, ptr, length));
 				}
 				
 				ub2 coerce_type=dtype;
@@ -670,7 +685,7 @@ private: // private funcs
 				case SQLT_CLOB: 
 					{
 						check(cs, "alloc output var desc", OCIDescriptorAlloc(
-							(dvoid *)cs.envhp, (dvoid **)(ptr=&cols[column_count-1].var), 
+							(dvoid *)cs.envhp, (dvoid **)(ptr=&col.var), 
 							(ub4)OCI_DTYPE_LOB, 
 							0, (dvoid **)0));
 						
@@ -679,17 +694,17 @@ private: // private funcs
 					}
 				default:
 					coerce_type=SQLT_STR;
-					ptr=cols[column_count-1].str=(char *)services.malloc_atomic(MAX_OUT_STRING_LENGTH+1);
+					ptr=col.str=(char *)services.malloc_atomic(MAX_OUT_STRING_LENGTH+1);
 					size=MAX_OUT_STRING_LENGTH;
 					break;
 				}
 				
-				cols[column_count-1].type=coerce_type;
+				col.type=coerce_type;
 				
-				check(cs, "DefineByPos", OCIDefineByPos(
-					stmthp, &cols[column_count-1].def, cs.errhp, 
+				col.def=0; check(cs, "DefineByPos", OCIDefineByPos(
+					stmthp, &col.def, cs.errhp, 
 					column_count, (ub1 *) ptr, size, 
-					coerce_type, (dvoid *) &cols[column_count-1].indicator, 
+					coerce_type, (dvoid *) &col.indicator, 
 					(ub2 *)0, (ub2 *)0, OCI_DEFAULT));
 			}
 			
@@ -705,7 +720,7 @@ private: // private funcs
 				if(row>=offset) {
 					check(cs, handlers.add_row(cs.sql_error));
 					for(int i=0; i<column_count; i++) {
-						size_t size=0;
+						size_t length=0;
 						char* str=0;
 						if(!cols[i].indicator) // not NULL
 							switch(cols[i].type) {
@@ -717,29 +732,29 @@ private: // private funcs
 									OCILobLocator *var=(OCILobLocator *)cols[i].var;
 									OCILobGetLength(cs.svchp, cs.errhp, var, &loblen);
 									if(loblen) {
-										size=(size_t)loblen;
-										str=(char*)services.malloc_atomic(size+1);
+										length=(size_t)loblen;
+										str=(char*)services.malloc_atomic(length+1);
 										check(cs, "lobread", OCILobRead(cs.svchp, cs.errhp, 
 											var, &amtp, offset, (dvoid *) str, 
 											loblen, (dvoid *)0, 
 											0, 
 											(ub2)0, (ub1) SQLCS_IMPLICIT));
-										str[size]=0;
+										str[length]=0;
 									}
 									break;
 								}
 							default:
 								if(const char *value=cols[i].str) {
-									size=strlen(str);
-									str=(char*)services.malloc_atomic(size+1);
-									memcpy(str, value, size+1);
+									length=strlen(value);
+									str=(char*)services.malloc_atomic(length+1);
+									memcpy(str, value, length+1);
 								} else {
-									size=0;
+									length=0;
 									str=0;
 								}
 								break;
 							}
-						check(cs, handlers.add_row_cell(cs.sql_error, str, size));
+						check(cs, handlers.add_row_cell(cs.sql_error, str, length));
 					}
 				}
 			}
@@ -1018,6 +1033,5 @@ void tolower(char *out, const char *in,
 }
 
 extern "C" SQL_Driver *SQL_DRIVER_CREATE() {
-	//_asm int 3;
 	return OracleSQL_driver=new OracleSQL_Driver();
 }