--- sql/pgsql/parser3pgsql.C	2004/03/05 10:16:41	1.18
+++ sql/pgsql/parser3pgsql.C	2004/12/23 16:54:52	1.25
@@ -7,7 +7,7 @@
 
 	2001.07.30 using PgSQL 7.1.2
 */
-static const char *RCSId="$Id: parser3pgsql.C,v 1.18 2004/03/05 10:16:41 paf Exp $"; 
+static const char *RCSId="$Id: parser3pgsql.C,v 1.25 2004/12/23 16:54:52 paf Exp $"; 
 
 #include "config_includes.h"
 
@@ -58,7 +58,18 @@ static char *lsplit(char **string_ref, c
     return result;
 }
 
-static void toupper(char *out, const char *in, size_t size) {
+static char* rsplit(char* string, char delim) {
+    if(string) {
+		char* v=strrchr(string, delim); 
+		if(v) {
+			*v=0;
+			return v+1;
+		}
+    }
+    return NULL;	
+}
+
+static void toupper_str(char *out, const char *in, size_t size) {
 	while(size--)
 		*out++=(char)toupper(*in++);
 }
@@ -95,16 +106,16 @@ public:
 	#define PQclear_throwPQerror PQclear_throw(PQerrorMessage(connection.conn))
 
 	/**	connect
-		@param used_only_in_connect_url
+		@param url
 			format: @b user:pass@host[:port]|[local]/database
 	*/
 	void connect(
-		char *used_only_in_connect_url, 
+		char *url, 
 		SQL_Driver_services& services, 
 		void **connection_ref ///< output: Connection*
 		) {
-		char *user=used_only_in_connect_url;
-		char *host=lsplit(user, '@');
+		char *user=url;
+		char *host=rsplit(user, '@');
 		char *db=lsplit(host, '/');
 		char *pwd=lsplit(user, ':');
 		char *port=lsplit(host, ':');
@@ -127,18 +138,21 @@ public:
 
 		char *charset=0;
 		char *datestyle=0;
+		isDefaultTransaction = true;
 
 		while(options) {
 			if(char *key=lsplit(&options, '&')) {
 				if(*key) {
 					if(char *value=lsplit(key, '=')) {
 						if(strcmp(key, "ClientCharset" ) == 0) {
-							toupper(value, value, strlen(value));
+							toupper_str(value, value, strlen(value));
 							connection.cstrClientCharset=value;
 						} else if(strcasecmp(key, "charset")==0) { // left for backward compatibility, consider using ClientCharset
 							cstrBackwardCompAskServerToTranscode=value;
 						} else if(strcasecmp(key, "datestyle")==0) {
 							datestyle=value;
+						} else if(strcmp(key, "WithoutDefaultTransaction")==0) {
+							isDefaultTransaction = false;
 						} else
 							services._throw("unknown connect option" /*key*/);
 					} else 
@@ -182,22 +196,28 @@ public:
 		connection.conn=0;
 	}
 	void commit(void *aconnection) {
-		Connection& connection=*static_cast<Connection*>(aconnection);
-
-		if(PGresult *res=PQexec(connection.conn, "COMMIT"))
-			PQclear(res);
-		else
-			throwPQerror;
-		begin_transaction(connection);
+		if(isDefaultTransaction)
+		{
+			Connection& connection=*static_cast<Connection*>(aconnection);
+
+			if(PGresult *res=PQexec(connection.conn, "COMMIT"))
+				PQclear(res);
+			else
+				throwPQerror;
+			begin_transaction(connection);
+		}
 	}
 	void rollback(void *aconnection) {
-		Connection& connection=*static_cast<Connection*>(aconnection);
-
-		if(PGresult *res=PQexec(connection.conn, "ROLLBACK"))
-			PQclear(res);
-		else
-			throwPQerror;
-		begin_transaction(connection);
+		if(isDefaultTransaction)
+		{
+			Connection& connection=*static_cast<Connection*>(aconnection);
+
+			if(PGresult *res=PQexec(connection.conn, "ROLLBACK"))
+				PQclear(res);
+			else
+				throwPQerror;
+			begin_transaction(connection);
+		}
 	}
 
 	bool ping(void *aconnection) {
@@ -228,15 +248,21 @@ public:
 		return result;
 		}
 	void query(void *aconnection, 
-		const char *astatement, unsigned long offset, unsigned long limit,
+		const char *astatement, 
+		size_t placeholders_count, Placeholder* placeholders, 
+		unsigned long offset, unsigned long limit,
 		SQL_Driver_query_event_handlers& handlers) {
 //		_asm int 3;
 		Connection& connection=*static_cast<Connection*>(aconnection);
+		const char* cstrClientCharset=connection.cstrClientCharset;
 		SQL_Driver_services& services=*connection.services;
 		PGconn *conn=connection.conn;
 
+		if(placeholders_count>0)
+			services._throw("bind variables not supported (yet)");
+
 		// transcode from $request:charset to connect-string?client_charset
-		if(const char* cstrClientCharset=connection.cstrClientCharset) {
+		if(cstrClientCharset) {
 			size_t transcoded_statement_size;
 			services.transcode(astatement, strlen(astatement),
 				astatement, transcoded_statement_size,
@@ -281,16 +307,16 @@ public:
 		for(int i=0; i<column_count; i++){
 			char *name=PQfname(res, i);
 			size_t length=strlen(name);
-			char* str=(char*)services.malloc(length+1);
-			memcpy(str, name, length+1);
+			char* strm=(char*)services.malloc(length+1);
+			memcpy(strm, name, length+1);
+			const char* str=strm;
 
 			// transcode to $request:charset from connect-string?client_charset
-			if(const char* cstrClientCharset=connection.cstrClientCharset) {
+			if(cstrClientCharset) 
 				services.transcode(str, length,
 					str, length,
 					cstrClientCharset,
 					services.request_charset());
-			}
 
 			CHECK(handlers.add_column(sql_error, str, length));
 		}
@@ -303,7 +329,7 @@ public:
 				for(int i=0; i<column_count; i++){
 					const char *cell=PQgetvalue(res, r, i);
 					size_t length;
-					char* str;
+					const char* str;
 					if(PQftype(res, i)==OIDOID) {
 						// ObjectID column, read object bytes
 
@@ -324,10 +350,11 @@ public:
 							length=(size_t)size_tell;
 							if(length) {
 								// read 
-								str=(char*)services.malloc(length+1);
-								if(!lo_read_ex(conn, fd, str, size_tell))
+								char* strm=(char*)services.malloc(length+1);
+								if(!lo_read_ex(conn, fd, strm, size_tell))
 									PQclear_throw("lo_read can not read all bytes of object");
-								str[length]=0;
+								strm[length]=0;
+								str=strm;
 							} else
 								str=0;
 							if(lo_close(conn, fd)<0)
@@ -338,15 +365,16 @@ public:
 						// normal column, read it normally
 						length=(size_t)PQgetlength(res, r, i);
 						if(length) {
-							str=(char*)services.malloc(length+1);
-							memcpy(str, cell, length+1);
+							char* strm=(char*)services.malloc(length+1);
+							memcpy(strm, cell, length+1);
+							str=strm;
 						} else
 							str=0;
 					}
 
 					if(str && length) {
 						// transcode to $request:charset from connect-string?client_charset
-						if(const char* cstrClientCharset=connection.cstrClientCharset)
+						if(cstrClientCharset)
 							services.transcode(str, length,
 								str, length,
 								cstrClientCharset,
@@ -365,10 +393,13 @@ cleanup:
 private: // private funcs
 
 	void begin_transaction(Connection& connection) {
-		if(PGresult *res=PQexec(connection.conn, "BEGIN"))
-			PQclear(res);
-		else
-			throwPQerror;
+		if(isDefaultTransaction)
+		{
+			if(PGresult *res=PQexec(connection.conn, "BEGIN"))
+				PQclear(res);
+			else
+				throwPQerror;
+		}
 	}
 
 	const char *preprocess_statement(Connection& connection,
@@ -552,6 +583,7 @@ private: // conn client library funcs li
 		return 0;
 	}
 
+	bool isDefaultTransaction;
 };
 
 extern "C" SQL_Driver *SQL_DRIVER_CREATE() {