--- sql/pgsql/parser3pgsql.C	2012/10/19 04:15:47	1.43
+++ sql/pgsql/parser3pgsql.C	2021/11/03 14:51:51	1.47
@@ -1,7 +1,7 @@
 /** @file
 	Parser PgSQL driver.
 
-	Copyright (c) 2001-2012 Art. Lebedev Studio (http://www.artlebedev.com)
+	Copyright (c) 2001-2019 Art. Lebedev Studio (http://www.artlebedev.com)
 
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 
@@ -15,7 +15,7 @@
 #include <libpq-fe.h>
 #include <libpq/libpq-fs.h>
 
-volatile const char * IDENT_PARSER3PGSQL_C="$Id: parser3pgsql.C,v 1.43 2012/10/19 04:15:47 misha Exp $" IDENT_PA_SQL_DRIVER_H;
+volatile const char * IDENT_PARSER3PGSQL_C="$Id: parser3pgsql.C,v 1.47 2021/11/03 14:51:51 moko Exp $" IDENT_PA_SQL_DRIVER_H;
 
 // from catalog/pg_type.h
 #define BOOLOID			16
@@ -99,7 +99,6 @@ struct Connection {
 	PGconn *conn;
 	const char* client_charset;
 	bool autocommit;
-	bool without_default_transactions;
 	bool standard_conforming_strings;
 };
 
@@ -134,9 +133,8 @@ public:
 			ClientCharset=charset&	// transcode by parser
 			charset=value&			// transcode by server with 'SET CLIENT_ENCODING=value'
 			datestyle=value&		// 'SET DATESTYLE=value' available values are: ISO|SQL|Postgres|European|US|German [default=ISO]
-			autocommit=1&			// each transaction is commited automatically (default)
-			standard_conforming_strings=1& // 0 -- escape \ char that could be needed for old servers
-			WithoutDefaultTransaction=0	   // 1 -- disable any BEGIN TRAN/COMMIT/ROLLBACK [can NOT be used with autocommit option]
+			autocommit=0&			// 1 -- each statement is commited automatically, only when with_default_transaction enabled
+			standard_conforming_strings=1&	// 0 -- escape \ char that could be needed for old servers
 	*/
 	void connect(
 				char* url, 
@@ -155,11 +153,11 @@ public:
 		char* datestyle=0;
 
 		Connection& connection=*(Connection *)services.malloc(sizeof(Connection));
+
 		*connection_ref=&connection;
 		connection.services=&services;
-		connection.client_charset=0;	
+		connection.client_charset=0;
 		connection.autocommit=true;
-		connection.without_default_transactions=false;
 		connection.standard_conforming_strings=true;
 
 		connection.conn=PQsetdbLogin(
@@ -184,17 +182,8 @@ public:
 						} else if(strcasecmp(key, "datestyle")==0){
 							datestyle=value;
 						} else if(strcasecmp(key, "autocommit")==0){
-							if(connection.without_default_transactions)
-								services._throw("options WithoutDefaultTransaction and autocommit can't be used together");
 							if(atoi(value)==0)
 								connection.autocommit=false;
-						} else if(strcmp(key, "WithoutDefaultTransaction")==0){
-							if(!connection.autocommit)
-								services._throw("options WithoutDefaultTransaction and autocommit can't be used together");
-							if(atoi(value)==1){
-								connection.without_default_transactions=true;
-								connection.autocommit=false;
-							}
 						} else if(strcasecmp(key, "standard_conforming_strings")==0){
 							if(atoi(value)==0)
 								connection.standard_conforming_strings=false;
@@ -220,7 +209,8 @@ public:
 			_execute_cmd(connection, statement);
 		}
 
-		_transaction_begin(connection);
+		if(!connection.autocommit)
+			_execute_cmd(connection, "set AUTOCOMMIT off");
 	}
 
 	void disconnect(void *aconnection){
@@ -231,14 +221,14 @@ public:
 
 	void commit(void *aconnection){
 		Connection& connection=*static_cast<Connection*>(aconnection);
-		_transaction_commit(connection);
-		_transaction_begin(connection);
+		if(!connection.autocommit)
+			_execute_cmd(connection, "COMMIT");
 	}
 
 	void rollback(void *aconnection){
 		Connection& connection=*static_cast<Connection*>(aconnection);
-		_transaction_rollback(connection);
-		_transaction_begin(connection);
+		if(!connection.autocommit)
+			_execute_cmd(connection, "ROLLBACK");
 	}
 
 	bool ping(void *aconnection) {
@@ -354,11 +344,9 @@ public:
 				break;
 			case PGRES_COMMAND_OK: // empty result: insert|delete|update|...
 				PQclear(res);
-				if(connection.autocommit)
-					commit(aconnection);
 				return;
 			case PGRES_TUPLES_OK: 
-				break;	
+				break;
 			default:
 				PQclear_throwPQerror;
 				break;
@@ -482,9 +470,6 @@ cleanup:
 		PQclear(res);
 		if(failed)
 			services._throw(sql_error);
-
-		if(connection.autocommit)
-			commit(aconnection);
 	}
 
 private:
@@ -520,24 +505,6 @@ private:
 		}
 	}
 	
-	
-	void _transaction_begin(Connection& connection){
-		_execute_transactions_cmd(connection, "BEGIN");
-	}
-
-	void _transaction_commit(Connection& connection){
-		_execute_transactions_cmd(connection, "COMMIT");
-	}
-
-	void _transaction_rollback(Connection& connection){
-		_execute_transactions_cmd(connection, "ROLLBACK");
-	}
-
-	void _execute_transactions_cmd(const Connection& connection, const char *query){
-		if(!connection.without_default_transactions) // with option ?WithoutDefaultTransaction=1 user must execute BEGIN/COMMIT/ROLLBACK by himself
-			_execute_cmd(connection, query);
-	}
-
 	// executes a query and throw away the result.
 	void _execute_cmd(const Connection& connection, const char *query){
 		if(PGresult *res=PQexec(connection.conn, query))