--- parser3/src/classes/op.C 2003/03/21 13:42:27 1.127.2.22.2.7 +++ parser3/src/classes/op.C 2003/03/26 18:52:48 1.127.2.22.2.20 @@ -5,7 +5,7 @@ Author: Alexandr Petrosian (http://paf.design.ru) */ -static const char* IDENT_OP_C="$Date: 2003/03/21 13:42:27 $"; +static const char* IDENT_OP_C="$Date: 2003/03/26 18:52:48 $"; #include "classes.h" #include "pa_vmethod_frame.h" @@ -31,7 +31,6 @@ static const char* IDENT_OP_C="$Date: 20 class VClassMAIN: public VClass { public: VClassMAIN(); - override ~VClassMAIN() {} }; // defines for statics @@ -47,23 +46,23 @@ public: // statics //^switch ^case -static const String& switch_data_name(new String(SWITCH_DATA_NAME)); +static const String switch_data_name(SWITCH_DATA_NAME); //^cache -static const String& cache_data_name(new String(CACHE_DATA_NAME)); +static const String cache_data_name(CACHE_DATA_NAME); -static const String& exception_var_name(new String(EXCEPTION_VAR_NAME)); -static const String& exception_type_part_name(new String(EXCEPTION_TYPE_PART_NAME)); -static const String& exception_source_part_name(new String(EXCEPTION_SOURCE_PART_NAME)); -static const String& exception_comment_part_name(new String(EXCEPTION_COMMENT_PART_NAME)); -static const String& exception_handled_part_name(new String(EXCEPTION_HANDLED_PART_NAME)); +static const String exception_var_name(EXCEPTION_VAR_NAME); +static const String exception_type_part_name(EXCEPTION_TYPE_PART_NAME); +static const String exception_source_part_name(EXCEPTION_SOURCE_PART_NAME); +static const String exception_comment_part_name(EXCEPTION_COMMENT_PART_NAME); +static const String exception_handled_part_name(EXCEPTION_HANDLED_PART_NAME); // helpers -class Untaint_lang_name2enum: public Hash { +class Untaint_lang_name2enum: public Hash { public: Untaint_lang_name2enum() { #define ULN(name, LANG) \ - put(String* (new String(name)), (value_type)String::L_##LANG); + put(StringBody(name), (value_type)(String::L_##LANG)); ULN("as-is", AS_IS); ULN("optimized-as-is", AS_IS|String::L_OPTIMIZE_BIT); ULN("file-spec", FILE_SPEC); @@ -83,21 +82,21 @@ public: // methods -static void _if(Request& r, const String& /*method_name*/, MethodParams* params) { - Value* condition_code=params->as_junction(0, "condition must be expression"); +static void _if(Request& r, MethodParams* params) { + Value& condition_code=params->as_junction(0, "condition must be expression"); bool condition=r.process_to_value(condition_code, /*0/*no name* /,*/ - false/*don't intercept string*/)->as_bool(); + false/*don't intercept string*/).as_bool(); if(condition) r.write_pass_lang(r.process(params->as_junction(1, "'then' parameter must be code"))); else if(params->count()>2) r.write_pass_lang(r.process(params->as_junction(2, "'else' parameter must be code"))); } -static void _untaint(Request& r, const String& method_name, MethodParams* params) { +static void _untaint(Request& r, MethodParams* params) { - Language lang; + String::Language lang; if(params->count()==1) lang=String::L_AS_IS; // mark as simply 'tainted'. useful in html from sql else { @@ -105,21 +104,20 @@ static void _untaint(Request& r, const S lang=untaint_lang_name2enum.get(lang_name); if(!lang) throw Exception(0, - lang_name, + &lang_name, "invalid taint language"); } { - Value* vbody=params->as_junction(params->count()-1, "body must be code"); + Value& vbody=params->as_junction(params->count()-1, "body must be code"); Temp_lang temp_lang(r, lang); // set temporarily specified ^untaint[language; r.write_pass_lang(r.process(vbody)); // process marking tainted with that lang } } -static void _taint(Request& r, const String& /*method_name*/, MethodParams* params) { - - Language lang; +static void _taint(Request& r, MethodParams* params) { + String::Language lang; if(params->count()==1) lang=String::L_TAINTED; // mark as simply 'tainted'. useful in table:set else { @@ -127,46 +125,45 @@ static void _taint(Request& r, const Str lang=untaint_lang_name2enum.get(lang_name); if(!lang) throw Exception(0, - lang_name, + &lang_name, "invalid taint language"); } { - Value* vbody=params->as_no_junction(params->count()-1, "body must not be code"); + Value& vbody=params->as_no_junction(params->count()-1, "body must not be code"); String result; result.append( - *vbody->as_string(), // process marking tainted with that lang + vbody.as_string(), // process marking tainted with that lang lang, true); // force result language to specified r.write_pass_lang(result); } } -static void _process(Request& r, const String& method_name, MethodParams* params) { - const String* source; // must be declared here to prevent premature destruction +static void _process(Request& r, MethodParams* params) { Method* main_method; - Value* target_self=params->count()>1? + Value& target_self=params->count()>1? params->as_no_junction(0, "target must not be code") - :Value*(&r.get_method_frame()->caller()->self()); + :r.get_method_frame()->caller()->self(); { - Value* vjunction=params->as_junction(params->count()-1, "body must be code"); + Value& vjunction=params->as_junction(params->count()-1, "body must be code"); - VStateless_class *target_class=target_self->get_last_derived_class(); + VStateless_class *target_class=target_self.get_last_derived_class(); if(!target_class) throw Exception("parser.runtime", - method_name, + 0, "no target class"); // evaluate source to process - source=r.process_to_string(vjunction); + const String& source=r.process_to_string(vjunction); // temporary remove language change Temp_lang temp_lang(r, String::L_PASS_APPENDED); // temporary zero @main so to maybe-replace it in processed code - Temp_method temp_method_main(*target_class, main_method_name, Method*(0)); + Temp_method temp_method_main(*target_class, main_method_name, 0); // temporary zero @auto so it wouldn't be auto-called in Request::use_buf - Temp_method temp_method_auto(*target_class, auto_method_name, Method*(0)); - + Temp_method temp_method_auto(*target_class, auto_method_name, 0); +#ifdef LATER // calculate pseudo file name of processed chars // would be something like "/some/file(4) process" char local_place[MAX_STRING]; @@ -186,13 +183,13 @@ static void _process(Request& r, const S size_t place_size=strlen(local_place)+1; #endif char *heap_place=pool.copy(local_place, place_size); - +#endif // process source code, append processed methods to 'self' class // maybe-define new @main r.use_buf(*target_class, - source->cstr(String::L_UNSPECIFIED, r.connection(0)), - String* (new String(heap_place, place_size, true /*tainted*/)), - heap_place); + source.cstr(String::L_UNSPECIFIED, r.connection(false)), + *new String("later"), //new String(heap_place, place_size, true /*tainted*/), + "later"); //heap_place); // main_method main_method=target_class->get_method(main_method_name); @@ -207,26 +204,25 @@ static void _process(Request& r, const S } } -static void _rem(Request& r, const String& /*method_name*/, MethodParams* params) { +static void _rem(Request& r, MethodParams* params) { params->as_junction(0, "body must be code"); } -static void _while(Request& r, const String& method_name, MethodParams* params) { - - Value* vcondition=params->as_junction(0, "condition must be expression"); - Value* body=params->as_junction(1, "body must be code"); +static void _while(Request& r, MethodParams* params) { + Value& vcondition=params->as_junction(0, "condition must be expression"); + Value& body=params->as_junction(1, "body must be code"); // while... int endless_loop_count=0; while(true) { if(++endless_loop_count>=MAX_LOOPS) // endless loop? throw Exception("parser.runtime", - method_name, + 0, "endless loop detected"); bool condition=r.process_to_value(vcondition, /*0/*no name* /,*/ - false/*don't intercept string*/)->as_bool(); + false/*don't intercept string*/).as_bool(); if(!condition) // ...condition is true break; @@ -235,66 +231,63 @@ static void _while(Request& r, const Str } } -static void _use(Request& r, const String& method_name, MethodParams* params) { - Value* vfile=params->as_no_junction(0, "file name must not be code"); - r.use_file(*r.main_class, vfile->as_string()); +static void _use(Request& r, MethodParams* params) { + Value& vfile=params->as_no_junction(0, "file name must not be code"); + r.use_file(r.main_class, vfile.as_string()); } -static void _for(Request& r, const String& method_name, MethodParams* params) { +static void _for(Request& r, MethodParams* params) { const String& var_name=params->as_string(0, "var name must be string"); int from=params->as_int(1, "from must be int", r); int to=params->as_int(2, "to must be int", r); - Value* body_code=params->as_junction(3, "body must be code"); + Value& body_code=params->as_junction(3, "body must be code"); Value* delim_maybe_code=params->count()>4?(*params)[4]:0; if(to-from>=MAX_LOOPS) // too long loop? throw Exception("parser.runtime", - method_name, + 0, "endless loop detected"); bool need_delim=false; - VIntPtr vint(new VInt(0)); + VInt* vint=new VInt(0); r.get_method_frame()->caller()->put_element(var_name, vint, false); for(int i=from; i<=to; i++) { vint->set_int(i); StringOrValue sv_processed=r.process(body_code); - const String& s_processed=sv_processed.get_string(); + const String* s_processed=sv_processed.get_string(); if(delim_maybe_code && s_processed && s_processed->length()) { // delimiter set and we have body if(need_delim) // need delim & iteration produced string? - r.write_pass_lang(r.process(delim_maybe_code)); + r.write_pass_lang(r.process(*delim_maybe_code)); need_delim=true; } r.write_pass_lang(sv_processed); } } -static void _eval(Request& r, const String& method_name, MethodParams* params) { - Value* expr=params->as_junction(0, "need expression"); +static void _eval(Request& r, MethodParams* params) { + Value& expr=params->as_junction(0, "need expression"); // evaluate expresion - Value* value_result=r.process_to_value(expr, + Value& value_result=*r.process_to_value(expr, /*0/*no name YET* /,*/ - true/*don't intercept string*/)->as_expr_result(); + true/*don't intercept string*/).as_expr_result(); if(params->count()>1) { - Value* fmt=params->as_no_junction(1, "fmt must not be code"); - String string; - string.APPEND_CONST( - format(value_result->as_double(), fmt->as_string()->cstr())); - r.write_no_lang(string); + Value& fmt=params->as_no_junction(1, "fmt must not be code"); + r.write_no_lang(String(format(value_result.as_double(), fmt.as_string().cstrm()))); } else r.write_no_lang(value_result); } -static void _connect(Request& r, const String& method_name, MethodParams* params) { +static void _connect(Request& r, MethodParams* params) { #ifdef RESOURCES_DEBUG struct timeval mt[2]; #endif - Value* url=params->as_no_junction(0, "url must not be code"); - Value* body_code=params->as_junction(1, "body must be code"); + Value& url=params->as_no_junction(0, "url must not be code"); + Value& body_code=params->as_junction(1, "body must be code"); Table* protocol2driver_and_client=0; - if(Value* sql=r.main_class->get_element(String* (new String(MAIN_SQL_NAME)), *r.main_class, false)) { - if(Value* element=sql->get_element(String* (new String(MAIN_SQL_DRIVERS_NAME)), *sql, false)) { + if(Value* sql=r.main_class.get_element(String(MAIN_SQL_NAME), r.main_class, false)) { + if(Value* element=sql->get_element(String(MAIN_SQL_DRIVERS_NAME), *sql, false)) { protocol2driver_and_client=element->get_table(); } } @@ -304,8 +297,8 @@ struct timeval mt[2]; gettimeofday(&mt[0],NULL); #endif // connect - SQL_ConnectionPtr connection=SQL_driver_manager.get_connection(pool, - url->as_string(), method_name, protocol2driver_and_client); + SQL_Connection* connection=SQL_driver_manager.get_connection(url.as_string(), + protocol2driver_and_client); #ifdef RESOURCES_DEBUG //measure:after connect @@ -317,7 +310,7 @@ for(int i=0;i<2;i++) r.sql_connect_time+=t[1]-t[0]; #endif - Temp_connection temp_connection(r, connection.get()); + Temp_connection temp_connection(r, connection); // execute body try { r.write_assign_lang(r.process(body_code)); @@ -331,67 +324,65 @@ r.sql_connect_time+=t[1]-t[0]; class Switch_data: public PA_Object { public: Request& r; - Value* searching; + Value& searching; Value* found; Value* _default; public: - Switch_data(Request& ar, Value* asearching): + Switch_data(Request& ar, Value& asearching): r(ar), searching(asearching) {} }; -DECLARE_OBJECT_PTR(Switch_data); #endif -static void _switch(Request& r, const String& /*method_name*/, MethodParams* params) { - Switch_dataPtr data(new Switch_data(r, r.process_to_value(params->get(0)))); - Temp_hash_value +static void _switch(Request& r, MethodParams* params) { + Switch_data* data=new Switch_data(r, r.process_to_value(*(*params)[0])); + Temp_hash_value switch_data_setter(r.classes_conf, switch_data_name, data); - Value* cases_code=params->as_junction(1, "switch cases must be code"); + Value& cases_code=params->as_junction(1, "switch cases must be code"); // execution of found ^case[...]{code} must be in context of ^switch[...]{code} // because of stacked WWrapper used there as wcontext r.process(cases_code, true/*intercept_string*/); if(Value* selected_code=data->found? data->found: data->_default) { // setting code context, would execute in ^switch[...]{>>context<<} //selected_code->get_junction()->change_context(cases_code.get_junction()); - r.write_pass_lang(r.process(selected_code)); + r.write_pass_lang(r.process(*selected_code)); } } -static void _case(Request& r, const String& method_name, MethodParams* params) { - - Switch_data* data=static_cast(r.classes_conf.get(switch_data_name).get()); +static void _case(Request& r, MethodParams* params) { + Switch_data* data=static_cast(r.classes_conf.get(switch_data_name)); if(!data) throw Exception("parser.runtime", - method_name, + 0, "without switch"); int count=params->count(); - Value* code=params->as_junction(--count, "case result must be code"); + Value& code=params->as_junction(--count, "case result must be code"); // killing context for safety, would execute in ^switch[...]{>>context<<} // reason: context is stacked, and it would become invalid afterwards //code->get_junction()->change_context(0); for(int i=0; iget(i)); + Value& value=r.process_to_value(*(*params)[i]); - if(*value->as_string() == CASE_DEFAULT_VALUE) { - data->_default=code; + if(value.as_string() == CASE_DEFAULT_VALUE) { + data->_default=&code; break; } bool matches; - if(data->searching->is_string()) - matches=*data->searching->as_string() == *value->as_string(); + if(data->searching.is_string()) + matches=data->searching.as_string() == value.as_string(); else - matches=data->searching->as_double() == value->as_double(); + matches=data->searching.as_double() == value.as_double(); if(matches) { if(data->found) throw Exception("parser.runtime", - method_name, + 0, "duplicate found"); - data->found=code; + data->found=&code; break; } } @@ -421,11 +412,10 @@ class Cache_data: public PA_Object { public: time_t expires; }; -DECLARE_OBJECT_PTR(Cache_data); struct Locked_process_and_cache_put_action_info { Request *r; Cache_data *data; - Value* body_code; const String& evaluated_body; + Value* body_code; const String* evaluated_body; }; #endif /* @todo maybe network order worth spending some effort? @@ -436,38 +426,34 @@ static void locked_process_and_cache_put Locked_process_and_cache_put_action_info& info= *static_cast(context); - =info.r->pool(); - // body->process - info.evaluated_body=info.r->process_to_string(info.body_code); + info.evaluated_body=&info.r->process_to_string(*info.body_code); // expiration time not spoiled by ^cache(0) or something? if(info.data->expires > time(0)) { // string -serialize> buffer - char *data; size_t data_size; - info.evaluated_body->serialize( - sizeof(Data_string_serialized_prolog), - data, data_size); + String::C serialized=info.evaluated_body->serialize( + sizeof(Data_string_serialized_prolog)); Data_string_serialized_prolog& prolog= - *reinterpret_cast(data); + *reinterpret_cast(serialized.str); prolog.version=DATA_STRING_SERIALIZED_VERSION; prolog.expires=info.data->expires; // buffer -write> file - write(f, data, data_size); + write(f, serialized.str, serialized.length); } else // expired! info.data->expires=0; // flag it so that could be easily checked by caller } -const String& locked_process_and_cache_put(Request& r, - Value* body_code, - Cache_data& data, - const String& file_spec) { +const String* locked_process_and_cache_put(Request& r, + Value& body_code, + Cache_data& data, + const String& file_spec) { Locked_process_and_cache_put_action_info info; info.r=&r; info.data=&data; - info.body_code=body_code; + info.body_code=&body_code; - const String& result=file_write_action_under_lock( + const String* result=file_write_action_under_lock( file_spec, "cache_put", locked_process_and_cache_put_action, &info, false/*as_text*/, @@ -479,30 +465,29 @@ const String& locked_process_and_cache_p cache_delete(file_spec); return result; } -const String& cache_getCharset& charset, const String& file_spec, time_t now) { +const String* cache_get(Charset& charset, const String& file_spec, time_t now) { File_read_result file=file_read(charset, file_spec, false/*as_text*/, 0, //no params false/*fail_on_read_problem*/); - if(file.success && file.size/* ignore reads which are empty due to + if(file.success && file.length/* ignore reads which are empty due to non-unary open+lockEX conflict with lockSH */) { Data_string_serialized_prolog& prolog= - *reinterpret_cast(file.data); + *reinterpret_cast(file.str); - const String& result(new String); + String* result=new String; if( - file.size>=sizeof(Data_string_serialized_prolog) + file.length>=sizeof(Data_string_serialized_prolog) && prolog.version==DATA_STRING_SERIALIZED_VERSION && prolog.expires > now - && result->deserialize( - sizeof(Data_string_serialized_prolog), file.data, file.size, file_spec->cstr())) + && result->deserialize(sizeof(Data_string_serialized_prolog), file.str, file.length)) return result; } return 0; } -static time_t as_expires(Request& r, const String& method_name, MethodParams* params, +static time_t as_expires(Request& r, MethodParams* params, int index, time_t now) { time_t result; if(Value* vdate=(*params)[index]->as(VDATE_TYPE, false)) @@ -515,7 +500,7 @@ static time_t as_expires(Request& r, con static const String& as_file_spec(Request& r, MethodParams* params, int index) { return r.absolute(params->as_string(index, "filespec must be string")); } -static void _cache(Request& r, const String& method_name, MethodParams* params) { +static void _cache(Request& r, MethodParams* params) { time_t now=time(0); // ^cache[filename] ^cache(seconds) ^cache[expires date] @@ -526,13 +511,13 @@ static void _cache(Request& r, const Str } // secods|expires date - Cache_data* data=static_cast(r.classes_conf.get(cache_data_name).get()); + Cache_data* data=static_cast(r.classes_conf.get(cache_data_name)); if(!data) throw Exception("parser.runtime", - method_name, + 0, "expire-time reducing instruction without cache"); - time_t expires=as_expires(r, method_name, params, 0, now); + time_t expires=as_expires(r, params, 0, now); if(expires < data->expires) data->expires=expires; @@ -542,11 +527,11 @@ static void _cache(Request& r, const Str // file_spec, expires, body code const String& file_spec=r.absolute(params->as_string(0, "filespec must be string")); - Cache_dataPtr data(new Cache_data); - Temp_hash_value + Cache_data* data=new Cache_data; + Temp_hash_value cache_data_setter(r.classes_conf, cache_data_name, data); - data->expires=as_expires(r, method_name, params, 1, now); - Value* body_code=params->as_junction(2, "body must be code"); + data->expires=as_expires(r, params, 1, now); + Value& body_code=params->as_junction(2, "body must be code"); if(data->expires>now) { // valid 'expires' specified? try cached copy... // hence we don't hope to have unary create/lockEX @@ -566,7 +551,7 @@ static void _cache(Request& r, const Str // |lockSH succeeds; ... for(int retry=0; retry<2; retry++) { - if(const String& cached_body=cache_get(r.charsets.source(), file_spec, now)) { // have cached copy? + if(const String* cached_body=cache_get(r.charsets.source(), file_spec, now)) { // have cached copy? // write it out r.write_assign_lang(*cached_body); // happy with it @@ -574,7 +559,7 @@ static void _cache(Request& r, const Str } // non-blocked lock; process; cache it - if(const String& processed_body= + if(const String* processed_body= locked_process_and_cache_put(r, body_code, *data, file_spec)) { // write it out r.write_assign_lang(*processed_body); @@ -586,7 +571,7 @@ static void _cache(Request& r, const Str } } throw Exception(0, - file_spec, + &file_spec, "locking problem"); } else { // instructed not to cache; forget cached copy @@ -594,7 +579,7 @@ static void _cache(Request& r, const Str // process const String& processed_body=r.process_to_string(body_code); // write it out - r.write_assign_lang(*processed_body); + r.write_assign_lang(processed_body); // happy with it return; } @@ -602,39 +587,28 @@ static void _cache(Request& r, const Str } // also used in pa_request.C to pass param to @unhandled_exception -VHash* exception2vhashconst Exception& e) { - VHash* result(new VHash); - HashStringValue& hash=result->hash(0); +VHash& exception2vhash(const Exception& e) { + VHash& result=*new VHash; + HashStringValue& hash=result.hash(); if(const char* type=e.type(true)) - hash.put(exception_type_part_name, Value*(new VString(String* (new String(type))))); - if(const String& asource=e.problem_source()) { - const String* source(new String); - source->append(*asource, String::L_TAINTED, true/*forced*/); + hash.put(exception_type_part_name, new VString(*new String(type))); + if(const String* asource=e.problem_source()) { + String& source=*new String; + source.append(*asource, String::L_TAINTED, true/*forced*/); - hash.put(exception_source_part_name, Value*(new VString(source))); -#ifndef NO_STRING_ORIGIN - const String_fragment::Origin& origin=source->origin(); - hash.put(String* (new String("file", 0, true)), - Value*(new VString(String* (new String(origin.file))))); - hash.put(String* (new String("lineno")), - Value*(new VInt(1+origin.line))); -#endif + hash.put(exception_source_part_name, new VString(source)); } - if(const char* ecomment=e.comment(true)) { - char *pcomment=pool.copy(ecomment); + if(const char* comment=e.comment(true)) hash.put(exception_comment_part_name, - Value*(new VString(String* (new String(pcomment, 0, true/*tainted*/))))); - } - hash.put(exception_handled_part_name, - Value*(new VBool(false))); + new VString(*new String(comment, 0, true/*tainted*/))); + hash.put(exception_handled_part_name, new VBool(false)); return result; } -static void _try_operator(Request& r, const String& method_name, MethodParams* params) { - - Value* body_code=params->as_junction(0, "body_code must be code"); - Value* catch_code=params->as_junction(1, "catch_code must be code"); +static void _try_operator(Request& r, MethodParams* params) { + Value& body_code=params->as_junction(0, "body_code must be code"); + Value& catch_code=params->as_junction(1, "catch_code must be code"); StringOrValue result; // taking snapshot of try-context @@ -645,16 +619,16 @@ static void _try_operator(Request& r, co Request_context_saver throw_context(r); // taking snapshot of throw-context [stack trace contains error] try_context.restore(); // restoring try-context to perform catch-code - VHash* vhash=exception2vhash(e); + VHash& vhash=exception2vhash(e); - Junction* junction=catch_code->get_junction(); + Junction* junction=catch_code.get_junction(); Value* method_frame=junction->method_frame; Value* saved_exception_var_value=method_frame->get_element(exception_var_name, *method_frame, false); - junction->method_frame->put_element(exception_var_name, vhash, false); + junction->method_frame->put_element(exception_var_name, &vhash, false); result=r.process(catch_code); bool handled=false; if(Value* value= - vhash->hash(0).get(exception_handled_part_name)) + vhash.hash().get(exception_handled_part_name)) handled=value->as_bool(); junction->method_frame->put_element(exception_var_name, saved_exception_var_value, false); @@ -667,40 +641,39 @@ static void _try_operator(Request& r, co r.write_pass_lang(result); } -static void _throw_operator(Request& r, const String& method_name, MethodParams* params) { - +static void _throw_operator(Request& r, MethodParams* params) { if(params->count()==1) { Value* param0=(*params)[0]; - if(HashStringValue *hash=param0->get_hash(method_name)) { + if(HashStringValue *hash=param0->get_hash()) { const char* type=0; if(Value* value=hash->get(exception_type_part_name)) - type=value->as_string()->cstr(); - const String* source; + type=value->as_string().cstr(); + const String* source=0; if(Value* value=hash->get(exception_source_part_name)) - source=value->as_string(); + source=&value->as_string(); const char* comment; if(Value* value=hash->get(exception_comment_part_name)) - comment=value->as_string()->cstr(); + comment=value->as_string().cstr(); throw Exception(type, - source?source:method_name, - "%s", comment?comment.get():""); + source?source:0, + "%s", comment?comment:""); } else throw Exception("parser.runtime", - method_name, + 0, "one-param version has hash param"); } else { - const char* type=params->as_string(0, "type must be string")->cstr(); - const String* source=params->as_string(1, "source must be string"); - const char* comment=params->count()>2? params->as_string(2, "comment must be string")->cstr() - :CharPtr(0); - throw Exception(type, source, "%s", comment?comment.get():""); + const char* type=params->as_string(0, "type must be string").cstr(); + const String& source=params->as_string(1, "source must be string"); + const char* comment=params->count()>2? params->as_string(2, "comment must be string").cstr() + :0; + throw Exception(type, &source, "%s", comment?comment:""); } } #if defined(WIN32) && defined(_DEBUG) # define PA_BPT -static void _bpt(Request& r, const String& method_name, MethodParams* params) { +static void _bpt(Request& r, MethodParams* params) { _asm int 3; } #endif @@ -708,7 +681,7 @@ static void _bpt(Request& r, const Strin // constructor VClassMAIN::VClassMAIN(): VClass() { - set_name(String* (new String(MAIN_CLASS_NAME))); + set_name(*new String(MAIN_CLASS_NAME)); #ifdef PA_BPT // ^bpt[] @@ -772,7 +745,6 @@ VClassMAIN::VClassMAIN(): VClass() { // constructor & configurator -VStateless_class* VClassMAIN_create() { - - return VStateless_class*(new VClassMAIN); +VStateless_class& VClassMAIN_create() { + return *new VClassMAIN; }