--- parser3/src/classes/table.C	2003/09/25 09:15:02	1.183
+++ parser3/src/classes/table.C	2003/11/20 16:34:23	1.192
@@ -5,7 +5,7 @@
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
 
-static const char* IDENT_TABLE_C="$Date: 2003/09/25 09:15:02 $";
+static const char * const IDENT_TABLE_C="$Date: 2003/11/20 16:34:23 $";
 
 #include "classes.h"
 #include "pa_vmethod_frame.h"
@@ -21,7 +21,7 @@ static const char* IDENT_TABLE_C="$Date:
 
 class MTable: public Methoded {
 public: // VStateless_class
-	Value* create_new_value() { return new VTable(); }
+	Value* create_new_value(Pool&) { return new VTable(); }
 
 public:
 	MTable();
@@ -50,6 +50,12 @@ String sql_default_name(SQL_DEFAULT_NAME
 String sql_distinct_name(SQL_DISTINCT_NAME);
 String table_reverse_name(TABLE_REVERSE_NAME);
 
+// local defines
+
+#define COLUMN_SEPARATOR_NAME "separator"
+#define COLUMN_ENCLOSER_NAME "encloser"
+
+
 // methods
 
 static Table::Action_options get_action_options(Request& r, MethodParams& params, 
@@ -172,6 +178,146 @@ static void _create(Request& r, MethodPa
 	GET_SELF(r, VTable).set_table(table);
 }
 
+static char* remove_encloser(char* cstr, char encloser) {
+	if(cstr[0]!=encloser)
+		return cstr;
+
+	size_t length=strlen(cstr);
+	if(length<2 || cstr[length-1]!=encloser)
+		return cstr;
+
+	// 'string'
+
+	cstr[length-1]=0;
+	cstr++;
+
+	// double-encloser stands for encloser
+	char *read;
+	char *write;
+	write=read=cstr;
+	while(char c=*read++) {
+		if(c==encloser && *read==encloser)
+			read++;
+
+		*write++=c;
+	}
+	*write=0; // terminate
+
+	return cstr;
+}
+
+struct lsplit_result {
+	char* piece;
+	char delim;
+
+	operator bool() { return piece!=0; }
+};
+
+inline lsplit_result lsplit(char* string, char delim1, char delim2) {
+	lsplit_result result;
+    if(string) {
+		char delims[]={delim1, delim2, 0};
+		if(char* v=strpbrk(string, delims)) {
+			result.delim=*v;
+			*v=0;
+			result.piece=v+1;
+			return result;
+		}
+    }
+	result.piece=0;
+	result.delim=0;
+    return result;
+}
+
+inline lsplit_result lsplit(char* *string_ref, char delim1, char delim2) {
+    lsplit_result result;
+	result.piece=*string_ref;
+	lsplit_result next=lsplit(*string_ref, delim1, delim2);
+	result.delim=next.delim;
+	*string_ref=next.piece;
+    return result;
+}
+
+static lsplit_result lsplit(char** string_ref, char delim1, char delim2, char encloser) {
+	lsplit_result result;
+
+    if(char* string=*string_ref) {
+		if(encloser && *string==encloser) {
+            string++;
+			
+			char *read;
+			char *write;
+			write=read=string;
+			char c;
+			while(c=*read++) {
+				if(c==encloser) {
+					char n=*read;
+					if(n==encloser) // double-encloser stands for encloser
+						read++;
+					else if(n==delim1 || n==delim2) {
+						result.delim=n;
+						read++;
+						break;
+					}
+				}
+
+				*write++=c;
+			}
+			*write=0; // terminate
+			*string_ref=c? read: 0;
+			result.piece=string;
+			return result;
+		} else
+			return lsplit(string_ref, delim1, delim2);
+    }
+	result.piece=0;
+    return result;
+}
+
+static void skip_empty_and_comment_lines( char** data_ref ) {
+	if(char *data=*data_ref) {
+		while( char c=*data ) {
+			if( c== '\n' || c == '#' ) {
+				/*nowhere=*/getrow(&data); // remove empty&comment lines
+				*data_ref=data;
+				continue;
+			}
+			break;
+		}
+	}
+}
+
+struct TableSeparators {
+	char column;
+	char encloser;
+	const String* sencloser;
+
+	TableSeparators() {
+		column='\t';
+		encloser=0;
+	}
+	void load( HashStringValue& options ) {
+		if(Value* vseparator=options.get(COLUMN_SEPARATOR_NAME)) {
+			options.remove(COLUMN_SEPARATOR_NAME);
+			const String& sseparator=vseparator->as_string();
+			if(sseparator.length()!=1)
+				throw Exception("parser.runtime",
+					&sseparator,
+					"separator must be one character long");
+			column=sseparator.first_char();
+		}
+		if(Value* vencloser=options.get(COLUMN_ENCLOSER_NAME)) {
+			options.remove(COLUMN_ENCLOSER_NAME);
+			sencloser=&vencloser->as_string();
+			if(sencloser->length()!=1)
+				throw Exception("parser.runtime",
+					sencloser,
+					"encloser must be one character long");
+			encloser=sencloser->first_char();
+		}
+	}
+};
+
 static void _load(Request& r, MethodParams& params) {
 	const String&  first_param=params.as_string(0, "file name must be string");
 	int filename_param_index=0;
@@ -179,12 +325,21 @@ static void _load(Request& r, MethodPara
 	if(nameless)
 		filename_param_index++;
 	size_t options_param_index=filename_param_index+1;
-	
+
+	HashStringValue *options=0;
+	TableSeparators separators;
+	if(options_param_index<params.count()
+		&& (options=params.as_no_junction(options_param_index, "additional params must be hash").get_hash())) {
+		// cloning, so that we could change [to simplify checks on params inside file_read_text
+		options=new HashStringValue(*options);
+		separators.load(*options);
+	}
+
 	// loading text
 	char *data=file_read_text(r.charsets,
 		r.absolute(params.as_string(filename_param_index, "file name must be string")),
 		true,
-		options_param_index<params.count()?params.as_no_junction(options_param_index, "additional params must be hash").get_hash():0
+		options
 	);
 
 	// parse columns
@@ -194,83 +349,123 @@ static void _load(Request& r, MethodPara
 	} else {
 		columns=Table::columns_type(new ArrayString);
 
-		while(char *row_chars=getrow(&data)) {
-			// remove empty&comment lines
-			if(!*row_chars || *row_chars == '#')
-				continue;
-			do {
-				*columns+=new String(lsplit(&row_chars, '\t'), 0, true);
-			} while(row_chars);
-
-			break;
+		skip_empty_and_comment_lines(&data);
+		while( lsplit_result sr=lsplit(&data, separators.column, '\n', separators.encloser) ) {
+			*columns+=new String(sr.piece, 0, true);
+			if(sr.delim=='\n') 
+				break;
 		}
 	}
+	
+	Table& table=*new Table(columns);
 
 	// parse cells
-	Table& table=*new Table(columns);//что-то очень плохое с realloc'ом: 1000 сильно помогает
-	char *row_chars;
-	int cells=0;
-	while(row_chars=getrow(&data)) {
-		// remove empty&comment lines
-		if(!*row_chars || *row_chars == '#')
-			continue;
-		Table::element_type row(new ArrayString);
-		while(char *cell_chars=lsplit(&row_chars, '\t')) {
-			*row+=new String(cell_chars, 0, true);
-			cells++;
+	Table::element_type row(new ArrayString);
+	skip_empty_and_comment_lines(&data);
+	while( lsplit_result sr=lsplit(&data, separators.column, '\n', separators.encloser) ) {
+		if(!sr.delim && !row->count()) // append last empty column [if without \n]
+			break;
+		*row+=new String(sr.piece, 0, true);
+		if(sr.delim=='\n') {
+			table+=row;
+			row=new ArrayString;
+			skip_empty_and_comment_lines(&data);
 		}
+	}
+	// last line [if without \n]
+	if(row->count())
 		table+=row;
-	};
-
+	
 	// replace any previous table value
 	GET_SELF(r, VTable).set_table(table);
 }
 
-/// @todo "x\nx" "xxx""xx"
+static void maybe_enclose( String& to, const String& from, char encloser, const String* sencloser ) {
+	if(encloser) {
+		to<<*sencloser;
+		// while we have 'encloser'...
+		size_t pos_after=0;
+		for( size_t pos_before; (pos_before=from.pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before+1) {
+            to<<from.mid(pos_before+1/*+found encloser*/, pos_after-pos_before);
+			to<<*sencloser; // doubling encloser
+		}
+		// last piece
+		size_t from_length=from.length();
+		if(pos_after<from_length)
+			to<<from.mid(pos_after, from_length);
+
+		to<<*sencloser;
+	} else
+		to.append(from, String::L_TABLE);
+}
+
+
 static void _save(Request& r, MethodParams& params) {
-	Value& vfile_name=params.as_no_junction(params.count()-1, "file name must not be code");
+	const String& first_arg=params.as_string(0, "first argument must not be code");
+	size_t param_index=1;
+
+	bool do_append=false;
+	bool output_column_names=true;
+
+	// mode?
+	if(first_arg=="append")
+		do_append=true;
+	else if(first_arg=="nameless")
+		output_column_names=false;
+	else
+		--param_index;
+
+	const String& file_name=params.as_string(param_index++, "file name must not be code");
+
+	TableSeparators separators;
+	if(param_index<params.count()) {
+		if(HashStringValue *options=params.as_no_junction(param_index++, "additional params must be hash").get_hash()) {
+			separators.load(*options);
+			if(options->count())
+				throw Exception("parser.runtime",
+					0,
+					"invalid option passed");
+		} else
+			throw Exception("parser.runtime",
+				0,
+				"additional params must be hash (did you spell mode parameter correctly?)");
+		
+	}
+	if(param_index<params.count())
+		throw Exception("parser.runtime",
+			0,
+			"bad mode (must be nameless or append)");
 
 	Table& table=GET_SELF(r, VTable).table();
 
-	bool do_append=false;
 	String sdata;
-	if(params.count()==1) { // named output
-		// write out names line
+	if(output_column_names) {
 		if(table.columns()) { // named table
 			for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
-				sdata.append(*i.next(), String::L_TABLE);
+				maybe_enclose( sdata, *i.next(), separators.encloser, separators.sencloser );
 				if(i.has_next())
 					sdata.append_know_length("\t", 1, String::L_CLEAN);
 			}
-		} else { // nameless table
+		} else { // nameless table [we were asked to output column names]
 			if(int lsize=table.count()?table[0]->count():0)
 				for(int column=0; column<lsize; column++) {
 					char *cindex_tab=new(PointerFreeGC) char[MAX_NUMBER];
 					sdata.append_know_length(cindex_tab, 
-						snprintf(cindex_tab, MAX_NUMBER, "%d\t", column),
-						String::L_CLEAN);
+						snprintf(cindex_tab, MAX_NUMBER, 
+							column<lsize-1?"%d\t":"%d", column),
+							String::L_CLEAN);
 				}
 			else
 				sdata.append_help_length("empty nameless table", 0, String::L_CLEAN);
 		}
 		sdata.append_know_length("\n", 1, String::L_CLEAN);
-	} else { // mode specified
-		const String&  mode=params.as_string(0, "mode must be string");
-		if(mode=="append")
-			do_append=true;
-		else if(mode=="nameless")
-			/*ok, already skipped names output*/;
-		else
-			throw Exception("parser.runtime",
-				&mode,
-				"unknown mode, must be 'append'");
-
 	}
+
 	// data lines
 	Array_iterator<ArrayString*> i(table);
 	while(i.has_next()) {
 		for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
-			sdata.append(*c.next(), String::L_TABLE);
+			maybe_enclose( sdata, *c.next(), separators.encloser, separators.sencloser );
 			if(c.has_next())
 				sdata.append_know_length("\t", 1, String::L_CLEAN);
 		}
@@ -278,7 +473,7 @@ static void _save(Request& r, MethodPara
 	}
 
 	// write
-	file_write(r.absolute(vfile_name.as_string()), 
+	file_write(r.absolute(file_name), 
 		sdata.cstr(), sdata.length(), true, do_append);
 }
 
@@ -566,9 +761,8 @@ struct Expression_is_true_info {
 	Value* expression_code;
 };
 #endif
-static bool expression_is_true(Table& self, void* ainfo) {
-	Expression_is_true_info& info=*static_cast<Expression_is_true_info*>(ainfo);
-	return info.r->process_to_value(*info.expression_code).as_bool();
+static bool expression_is_true(Table&, Expression_is_true_info* info) {
+	return info->r->process_to_value(*info->expression_code).as_bool();
 }
 static bool _locate_expression(Table& table, Table::Action_options o,
 			       Request& r, MethodParams& params) {
@@ -580,7 +774,7 @@ static bool _locate_expression(Table& ta
 	return table.table_first_that(expression_is_true, &info, o);
 }
 static bool _locate_name_value(Table& table, Table::Action_options o,
-			       Request& r, MethodParams& params) {
+			       Request&, MethodParams& params) {
 	check_option_param(o.defined, params, 2,
 		"locate by locate by name has parameters: name, value and, maybe, options");
 	const String& name=params.as_string(0, "column name must be string");
@@ -599,9 +793,9 @@ static void _locate(Request& r, MethodPa
 }
 
 
-static void _flip(Request& r, MethodParams& params) {
+static void _flip(Request& r, MethodParams&) {
 	Table& old_table=GET_SELF(r, VTable).table();
-	Table& new_table=*new Table(old_table.columns());
+	Table& new_table=*new Table(0);
 	if(size_t old_count=old_table.count())
 		if(size_t old_cols=old_table[0]->count()) 
 			for(size_t column=0; column<old_cols; column++) {
@@ -837,7 +1031,7 @@ MTable::MTable(): Methoded("table") {
 
 	// ^table.save[file]  
 	// ^table.save[nameless;file]
-	add_native_method("save", Method::CT_DYNAMIC, _save, 1, 2);
+	add_native_method("save", Method::CT_DYNAMIC, _save, 1, 3);
 
 	// ^table.count[]
 	add_native_method("count", Method::CT_DYNAMIC, _count, 0, 0);