--- parser3/src/classes/table.C	2009/06/20 01:55:01	1.259
+++ parser3/src/classes/table.C	2009/09/17 23:32:39	1.268
@@ -5,7 +5,7 @@
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
 
-static const char * const IDENT_TABLE_C="$Date: 2009/06/20 01:55:01 $";
+static const char * const IDENT_TABLE_C="$Date: 2009/09/17 23:32:39 $";
 
 #if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4))
 #include <sstream>
@@ -17,6 +17,7 @@ using namespace std;
 
 #include "pa_common.h"
 #include "pa_request.h"
+#include "pa_charsets.h"
 #include "pa_vtable.h"
 #include "pa_vint.h"
 #include "pa_sql_connection.h"
@@ -26,7 +27,7 @@ using namespace std;
 
 class MTable: public Methoded {
 public: // VStateless_class
-	Value* create_new_value(Pool&, HashStringValue*) { return new VTable(); }
+	Value* create_new_value(Pool&) { return new VTable(); }
 
 public:
 	MTable();
@@ -39,10 +40,6 @@ public: // Methoded
 
 DECLARE_CLASS_VAR(table, new MTable, 0);
 
-// externs
-
-extern String cycle_data_name;
-
 #define TABLE_REVERSE_NAME "reverse"
 
 // globals
@@ -58,12 +55,12 @@ String table_reverse_name(TABLE_REVERSE_
 // methods
 
 static Table::Action_options get_action_options(Request& r, MethodParams& params, 
-						const Table& source) {
+						size_t options_index, const Table& source) {
 	Table::Action_options result;
-	if(!params.count())
+	if(params.count() <= options_index)
 		return result;
 
-	Value& maybe_options=params.last();
+	Value& maybe_options=params[options_index];
 /* can not do it: 
 	want to enable ^table::create[$source;
 #		$.option[]
@@ -160,7 +157,7 @@ struct TableSeparators {
 static void _create(Request& r, MethodParams& params) {
 	// clone/copy part?
 	if(Table *source=params[0].get_table()) {
-		Table::Action_options o=get_action_options(r, params, *source);
+		Table::Action_options o=get_action_options(r, params, 1, *source);
 		check_option_param(o.defined, params, 1, 
 			"too many parameters");
 		GET_SELF(r, VTable).set_table(*new Table(*source, o));
@@ -465,7 +462,7 @@ static void _save(Request& r, MethodPara
 				if(valid_options!=options->count())
 					throw Exception(PARSER_RUNTIME,
 						0,
-						"invalid option passed");
+						INVALID_OPTION_PASSED);
 			} else {
 				throw Exception(PARSER_RUNTIME,
 					0,
@@ -527,7 +524,7 @@ static void _save(Request& r, MethodPara
 		string data=ost.str();
 		const char* data_cstr=data.c_str();
 
-		file_write(file_spec, data_cstr, data.length(), true /* as text */, do_append);
+		file_write(r.charsets, file_spec, data_cstr, data.length(), true /* as text */, do_append);
 	}
 
 #else
@@ -569,8 +566,7 @@ static void _save(Request& r, MethodPara
 	// write
 	{
 		const char* data_cstr=sdata.cstr();
-		file_write(file_spec, 
-			data_cstr, sdata.length(), true, do_append);
+		file_write(r.charsets, file_spec, data_cstr, sdata.length(), true, do_append);
 		if(*data_cstr) // not empty (when empty it's not heap memory)
 			pa_free((void*)data_cstr); // not needed anymore
 	}
@@ -611,8 +607,7 @@ static void _offset(Request& r, MethodPa
 }
 
 static void _menu(Request& r, MethodParams& params) {
-	Temp_hash_value<const String::Body, void*> 
-		cycle_data_setter(r.classes_conf, cycle_data_name, /*any not null flag*/&r);
+	InCycle temp(r);
 
 	Value& body_code=params.as_junction(0, "body must be code");
 	
@@ -916,6 +911,14 @@ static void _sort(Request& r, MethodPara
 		else
 			seq[i].value.d=value.as_double();
 	}
+
+	// @todo: handle this elsewhere
+	if(r.charsets.source().NAME()=="KOI8-R" && key_values_are_strings) {
+		for(i=0; i<old_count; i++)
+			if(*seq[i].value.c_str)
+				seq[i].value.c_str=Charset::transcode(seq[i].value.c_str, r.charsets.source(), UTF8_charset).cstr();
+	}
+
 	// sort keys
 	_qsort(seq, old_count, sizeof(Table_seq_item), 
 		key_values_are_strings?sort_cmp_string:sort_cmp_double);
@@ -959,7 +962,7 @@ static bool _locate_name_value(Table& ta
 static void _locate(Request& r, MethodParams& params) {
 	Table& table=GET_SELF(r, VTable).table();
 
-	Table::Action_options o=get_action_options(r, params, table);
+	Table::Action_options o=get_action_options(r, params, 1, table);
 
 	bool result=params[0].get_junction()?
 		_locate_expression(table, o, r, params) :
@@ -986,9 +989,8 @@ static void _flip(Request& r, MethodPara
 }
 
 static void _append(Request& r, MethodParams& params) {
-	// data
 	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
-	const String& string=r.process_to_string(params.as_junction(0, "body must be code"));
+	const String& string=r.process_to_string(params[0]);
 
 	// parse cells
 	Table::element_type row=new ArrayString;
@@ -1019,7 +1021,7 @@ static void _join(Request& r, MethodPara
 			"source is not a table");
 	Table& src=*maybe_src;
 
-	Table::Action_options o=get_action_options(r, params, src);
+	Table::Action_options o=get_action_options(r, params, 1, src);
 	check_option_param(o.defined, params, 1,
 		"invalid extra parameter");
 
@@ -1094,7 +1096,7 @@ static void marshal_bind(
 {
 	SQL_Driver::Placeholder& ph=**pptr;
 	ph.name=aname.cstr();
-	ph.value=avalue->as_string().cstr(String::L_UNSPECIFIED);
+	ph.value=avalue->as_string().untaint_cstr(String::L_AS_IS);
 	ph.is_null=avalue->get_class()==void_class;
 	ph.were_updated=false;
 
@@ -1164,8 +1166,8 @@ static void _sql(Request& r, MethodParam
 
 	Temp_lang temp_lang(r, String::L_SQL);
 	const String&  statement_string=r.process_to_string(statement);
-	const char* statement_cstr=
-		statement_string.cstr(String::L_UNSPECIFIED, r.connection());
+	const char* statement_cstr=statement_string.untaint_cstr(r.flang, r.connection());
+
 	Table_sql_event_handlers handlers;
 #ifdef RESOURCES_DEBUG
 	struct timeval mt[2];