--- parser3/src/classes/table.C 2012/03/16 09:24:08 1.286 +++ parser3/src/classes/table.C 2013/10/17 21:52:32 1.299 @@ -21,7 +21,7 @@ #include "pa_vbool.h" #include "pa_array.h" -volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.286 2012/03/16 09:24:08 moko Exp $"; +volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.299 2013/10/17 21:52:32 moko Exp $"; // class @@ -56,20 +56,7 @@ static Table::Action_options get_action_ if(params.count() <= options_index) return result; - Value& maybe_options=params[options_index]; -/* can not do it: - want to enable ^table::create[$source; -# $.option[] - ] - but there is ^table.locate[name;value] - - ...if(voptions.is_defined() && !voptions.is_string())) - if(maybe_options.is_string()) { // allow empty options - result.defined=true; - return result; - } -*/ - HashStringValue* options=maybe_options.get_hash(); + HashStringValue* options=params.as_hash(options_index); if(!options) return result; @@ -137,11 +124,15 @@ struct TableSeparators { } if(Value* vencloser=options.get(PA_COLUMN_ENCLOSER_NAME)) { sencloser=&vencloser->as_string(); + if(sencloser->is_empty()){ + encloser=0; + } else { if(sencloser->length()!=1) throw Exception(PARSER_RUNTIME, sencloser, "encloser must be one character long"); encloser=sencloser->first_char(); + } result++; } return result; @@ -179,7 +170,7 @@ static void _create(Request& r, MethodPa size_t options_param_index=data_param_index+1; if( options_param_index, gc_allocator > pa_stringstream; typedef std::basic_string, gc_allocator > pa_string; -void maybe_enclose( pa_stringstream& to, const String& from, char encloser ) { - if(encloser) { +static void enclose( pa_stringstream& to, const String* from, char encloser ) { + if(from){ to<pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) { pos_before++; // including first encloser (and skipping it for next pos) - to<mid(pos_after, pos_before).cstr(); to<length(); if(pos_aftermid(pos_after, from_length).cstr(); to< i(*table.columns()); i.has_next(); ) { + enclose( result, i.next(), separators.encloser ); + if(i.has_next()) + result< i(*table.columns()); i.has_next(); ) { + result<cstr(); + if(i.has_next()) + result<count():0) + for(int column=0; column i(table); + if(separators.encloser){ + while(i.has_next()) { + for(Array_iterator c(*i.next()); c.has_next(); ) { + enclose( result, c.next(), separators.encloser ); + if(c.has_next()) + result< c(*i.next()); c.has_next(); ) { + result<cstr(); + if(c.has_next()) + result<pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) { pos_before++; // including first encloser (and skipping it for next pos) - to<mid(pos_after, pos_before); to<<*sencloser; // doubling encloser } // last piece - size_t from_length=from.length(); + size_t from_length=from->length(); if(pos_aftermid(pos_after, from_length); to<<*sencloser; - } else - to< i(*table.columns()); i.has_next(); ) { + enclose( result, i.next(), separators.encloser, separators.sencloser ); + if(i.has_next()) + result<<*separators.scolumn; + } + } else { + for(Array_iterator i(*table.columns()); i.has_next(); ) { + result<<*i.next(); + if(i.has_next()) + result<<*separators.scolumn; + } + } + } else { // nameless table [we were asked to output column names] + if(int lsize=table.count()?table[0]->count():0) + for(int column=0; column i(table); + if(separators.encloser){ + while(i.has_next()) { + for(Array_iterator c(*i.next()); c.has_next(); ) { + enclose( result, c.next(), separators.encloser, separators.sencloser ); + if(c.has_next()) + result<<*separators.scolumn; + } + result.append_know_length("\n", 1, String::L_CLEAN); + } + } else { + while(i.has_next()) { + for(Array_iterator c(*i.next()); c.has_next(); ) { + result<<*c.next(); + if(c.has_next()) + result<<*separators.scolumn; + } + result.append_know_length("\n", 1, String::L_CLEAN); + } + } +} #endif // don't use stringstream + static void _save(Request& r, MethodParams& params) { const String& first_arg=params.as_string(0, FIRST_ARG_MUST_NOT_BE_CODE); size_t param_index=1; @@ -475,10 +587,7 @@ static void _save(Request& r, MethodPara TableSeparators separators; if(param_indexcount()) throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION); @@ -491,101 +600,65 @@ static void _save(Request& r, MethodPara Table& table=GET_SELF(r, VTable).table(); -#if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4)) - +#ifdef USE_STRINGSTREAM pa_stringstream ost(std::stringstream::out); - // process header - if(output_column_names) { - if(table.columns()) { // named table - for(Array_iterator i(*table.columns()); i.has_next(); ) { - maybe_enclose( ost, *i.next(), separators.encloser ); - if(i.has_next()){ - ost<count():0) - for(int column=0; column i(table); - while(i.has_next()) { - for(Array_iterator c(*i.next()); c.has_next(); ) { - maybe_enclose( ost, *c.next(), separators.encloser ); - if(c.has_next()) - ost< i(*table.columns()); i.has_next(); ) { - maybe_enclose( sdata, *i.next(), separators.encloser, separators.sencloser ); - if(i.has_next()) - sdata<<*separators.scolumn; - } - } else { // nameless table [we were asked to output column names] - if(int lsize=table.count()?table[0]->count():0) - for(int column=0; column i(table); - while(i.has_next()) { - for(Array_iterator c(*i.next()); c.has_next(); ) { - maybe_enclose( sdata, *c.next(), separators.encloser, separators.sencloser ); - if(c.has_next()) - sdata<<*separators.scolumn; - } - sdata.append_know_length("\n", 1, String::L_CLEAN); - } + table_to_csv(sdata, table, separators, output_column_names); // write - { const char* data_cstr=sdata.cstr(); - file_write(r.charsets, file_spec, data_cstr, sdata.length(), true, do_append); + file_write(r.charsets, file_spec, data_cstr, sdata.length(), true /* as text */, do_append); if(*data_cstr) // not empty (when empty it's not heap memory) pa_free((void*)data_cstr); // not needed anymore +#endif +} + +static void _csv_string(Request& r, MethodParams& params) { + bool output_column_names=true; + size_t param_index=0; + if(params.count()>0 && params[0].is_string()) { + if(params.as_string(0, FIRST_ARG_MUST_NOT_BE_CODE)=="nameless") { + output_column_names=false; + param_index++; + } else { + throw Exception(PARSER_RUNTIME, + 0, + "bad mode (must be nameless)"); + } } -#endif // don't use stringstream + TableSeparators separators; + if(param_indexcount()) + throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION); + } + + Table& table=GET_SELF(r, VTable).table(); + +#ifdef USE_STRINGSTREAM + pa_stringstream ost(std::stringstream::out); + + table_to_csv(ost, table, separators, output_column_names); + + r.write_no_lang(*new VString(*new String(pa_strdup(ost.str().c_str()), String::L_CLEAN))); +#else + String sdata; + + table_to_csv(sdata, table, separators, output_column_names); + + r.write_no_lang(*new VString(*new String(sdata.cstr(), String::L_CLEAN))); +#endif } static void _count(Request& r, MethodParams& params) { @@ -642,12 +715,12 @@ static void _menu(Request& r, MethodPara Value* delim_maybe_code=params.count()>1?¶ms[1]:0; Table& table=GET_SELF(r, VTable).table(); - int saved_current=table.current(); - int size=table.count(); + size_t saved_current=table.current(); + size_t size=table.count(); if(delim_maybe_code) { // delimiter set bool need_delim=false; - for(int row=0; row0) { - if(HashStringValue* options=params.as_no_junction(param_index, PARAM_MUST_NOT_BE_CODE).get_hash()){ // options where specified + if(HashStringValue* options=params.as_no_junction(param_index, PARAM_MUST_NOT_BE_CODE).get_hash()){ // can't use .as_has because the 2nd param could be table so .as_hash throws an error --param_index; int valid_options=0; if(Value* vdistinct_code=options->get(sql_distinct_name)) { // $.distinct ? @@ -818,7 +891,7 @@ static void _hash(Request& r, MethodPara } if(param_index==2) // options was specified but not as hash - throw Exception(PARSER_RUNTIME, 0, OPTIONS_MUST_BE_HASH); + throw Exception(PARSER_RUNTIME, 0, "options must be hash"); Array value_fields; if(param_index==0){ // list of columns wasn't specified @@ -927,14 +1000,14 @@ static void _sort(Request& r, MethodPara old_table.set_current(i); // calculate key value seq[i].row=old_table[i]; - Value& value=r.process_to_value(key_maker).as_expr_result(true/*return string as-is*/); + Value& value=r.process_to_value(key_maker); if(i==0) // determining key values type by first one key_values_are_strings=value.is_string(); if(key_values_are_strings) seq[i].value.c_str=value.as_string().cstr(); else - seq[i].value.d=value.as_double(); + seq[i].value.d=value.as_expr_result().as_double(); } // @todo: handle this elsewhere @@ -945,8 +1018,7 @@ static void _sort(Request& r, MethodPara } // sort keys - _qsort(seq, old_count, sizeof(Table_seq_item), - key_values_are_strings?sort_cmp_string:sort_cmp_double); + qsort(seq, old_count, sizeof(Table_seq_item), key_values_are_strings?sort_cmp_string:sort_cmp_double); // reorder table as they require in 'seq' for(i=0; i3?¶ms[3]:0; + + Table& table=GET_SELF(r, VTable).table(); + size_t saved_current=table.current(); + size_t size=table.count(); + + const String* rownum_var_name=rownum_name.is_empty()? 0 : &rownum_name; + const String* value_var_name=value_name.is_empty()? 0 : &value_name; + + Value* var_context=r.get_method_frame()->caller(); + + if(delim_maybe_code) { // delimiter set + bool need_delim=false; + for(size_t row=0; rowis_empty()) { // we have body + if(need_delim) // need delim & iteration produced string? + r.write_pass_lang(r.process(*delim_maybe_code)); + else + need_delim=true; + } + + r.write_pass_lang(sv_processed); + + if(lskip==Request::SKIP_BREAK) + break; + } + } else { + for(size_t row=0; rowput_element(*rownum_var_name, new VString(*new String(String::Body::Format(row), String::L_CLEAN))); + if(value_var_name) + var_context->put_element(*value_var_name, new VTable(&table)); + + r.process_write(body_code); + Request::Skip lskip=r.get_skip(); r.set_skip(Request::SKIP_NOTHING); + + if(lskip==Request::SKIP_BREAK) + break; + } + } + table.set_current(saved_current); +} + static void _append(Request& r, MethodParams& params) { Temp_lang temp_lang(r, String::L_PASS_APPENDED); const String& string=r.process_to_string(params[0]); @@ -1042,16 +1178,10 @@ static void join_nameless_row(Table& src *dest+=src[src.current()]; } static void _join(Request& r, MethodParams& params) { - Table* maybe_src=params.as_no_junction(0, "table ref must not be code").get_table(); - if(!maybe_src) - throw Exception(PARSER_RUNTIME, - 0, - "source is not a table"); - Table& src=*maybe_src; + Table& src=*params.as_table(0, "source"); Table::Action_options o=get_action_options(r, params, 1, src); - check_option_param(o.defined, params, 1, - "invalid extra parameter"); + check_option_param(o.defined, params, 1, "invalid extra parameter"); Table& dest=GET_SELF(r, VTable).table(); if(&src == &dest) @@ -1107,7 +1237,7 @@ public: } bool add_row_cell(SQL_Error& error, const char* str, size_t ) { try { - *row+=new String(str, String::L_TAINTED /* no length as 0x00 can be inside */); + *row+=str?new String(str, String::L_TAINTED /* no length as 0x00 can be inside */):&String::Empty; return false; } catch(...) { error=SQL_Error("exception occured in Table_sql_event_handlers::add_row_cell"); @@ -1161,7 +1291,7 @@ static void _sql(Request& r, MethodParam ulong limit=SQL_NO_LIMIT; ulong offset=0; if(params.count()>1) - if(HashStringValue* options=params.as_hash(1)) { + if(HashStringValue* options=params.as_hash(1, "sql options")) { int valid_options=0; if(Value* vbind=options->get(sql_bind_name)) { valid_options++; @@ -1189,11 +1319,7 @@ static void _sql(Request& r, MethodParam const char* statement_cstr=statement_string.untaint_cstr(r.flang, r.connection()); Table_sql_event_handlers handlers; -#ifdef RESOURCES_DEBUG - struct timeval mt[2]; - //measure:before - gettimeofday(&mt[0],NULL); -#endif + r.connection()->query( statement_cstr, placeholders_count, placeholders, @@ -1201,17 +1327,6 @@ static void _sql(Request& r, MethodParam handlers, statement_string); -#ifdef RESOURCES_DEBUG - //measure:after connect - gettimeofday(&mt[1],NULL); - - double t[2]; - for(int i=0;i<2;i++) - t[i]=mt[i].tv_sec+mt[i].tv_usec/1000000.0; - - r.sql_request_time+=t[1]-t[0]; -#endif - if(bind) unmarshal_bind_updates(*bind, placeholders_count, placeholders); @@ -1271,9 +1386,7 @@ static void _select(Request& r, MethodPa reverse=r.process_to_value(*vreverse).as_bool(); } if(valid_options!=options->count()) - throw Exception(PARSER_RUNTIME, - 0, - "called with invalid option"); + throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION); } Table& result_table=*new Table(source_table.columns()); @@ -1331,6 +1444,11 @@ MTable::MTable(): Methoded("table") { // add_native_method("save_old", Method::CT_DYNAMIC, _save_old, 1, 3); + // ^table.csv-string[] + // ^table.csv-string[nameless] + // ^table.csv-string[nameless;$.encloser["] $.separator[,]] + add_native_method("csv-string", Method::CT_DYNAMIC, _csv_string, 0, 2); + // ^table.count[] // ^table.count[rows] // ^table.count[columns] @@ -1363,6 +1481,10 @@ MTable::MTable(): Methoded("table") { // ^table.flip[] add_native_method("flip", Method::CT_DYNAMIC, _flip, 0, 0); + // ^table.foreach[row-num;value]{code} + // ^table.foreach[row-num;value]{code}[delim] + add_native_method("foreach", Method::CT_DYNAMIC, _foreach, 3, 4); + // ^table.append{r{tab}e{tab}c{tab}o{tab}r{tab}d} add_native_method("append", Method::CT_DYNAMIC, _append, 1, 1);