--- parser3/src/classes/table.C	2013/07/23 14:29:02	1.294
+++ parser3/src/classes/table.C	2015/08/04 21:10:17	1.310
@@ -5,10 +5,6 @@
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
 
-#if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4))
-#include <sstream>
-#endif
-
 #include "classes.h"
 #include "pa_vmethod_frame.h"
 
@@ -21,7 +17,12 @@
 #include "pa_vbool.h"
 #include "pa_array.h"
 
-volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.294 2013/07/23 14:29:02 moko Exp $";
+#if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4))
+#include <sstream>
+#define USE_STRINGSTREAM
+#endif
+
+volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.310 2015/08/04 21:10:17 moko Exp $";
 
 // class
 
@@ -94,14 +95,6 @@ static Table::Action_options get_action_
 
 	return result;
 }
-static void check_option_param(bool options_defined, 
-			  MethodParams& params, size_t next_param_index,
-			  const char *msg) {
-	if(next_param_index+(options_defined?1:0) != params.count())
-		throw Exception(PARSER_RUNTIME,
-			0,
-			"%s", msg);
-}
 
 struct TableSeparators {
 	char column;  const String* scolumn;
@@ -124,11 +117,15 @@ struct TableSeparators {
 		}
 		if(Value* vencloser=options.get(PA_COLUMN_ENCLOSER_NAME)) {
 			sencloser=&vencloser->as_string();
+			if(sencloser->is_empty()){
+				encloser=0;
+			} else {
 			if(sencloser->length()!=1)
 				throw Exception(PARSER_RUNTIME,
 					sencloser,
 					"encloser must be one character long");
 			encloser=sencloser->first_char();
+			}
 			result++;
 		}
 		return result;
@@ -139,8 +136,8 @@ static void _create(Request& r, MethodPa
 	// clone/copy part?
 	if(Table *source=params[0].get_table()) {
 		Table::Action_options o=get_action_options(r, params, 1, *source);
-		check_option_param(o.defined, params, 1, 
-			"too many parameters");
+		if(params.count()>2)
+			throw Exception(PARSER_RUNTIME, 0, "too many parameters");
 		GET_SELF(r, VTable).set_table(*new Table(*source, o));
 		return;
 	}
@@ -181,7 +178,7 @@ static void _create(Request& r, MethodPa
 	// data
 	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
 	const String&  data=
-		r.process_to_string(params.as_junction(data_param_index, "body must be code"));
+		r.process_to_string(params.as_junction(data_param_index, "body must be table or code"));
 
 	// parse columns
 	size_t raw_pos_after=0;
@@ -392,57 +389,170 @@ static void _load(Request& r, MethodPara
 	GET_SELF(r, VTable).set_table(table);
 }
 
-#if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4))
-
+#ifdef USE_STRINGSTREAM
 #include "gc_allocator.h"
 
 typedef std::basic_stringstream<char, std::char_traits<char>, gc_allocator<char> > pa_stringstream;
 typedef std::basic_string<char, std::char_traits<char>, gc_allocator<char> > pa_string;
 
-void maybe_enclose( pa_stringstream& to, const String& from, char encloser ) {
-	if(encloser) {
+static void enclose( pa_stringstream& to, const String* from, char encloser ) {
+	if(from){
 		to<<encloser;
 		// while we have 'encloser'...
 		size_t pos_after=0;
-		for( size_t pos_before; (pos_before=from.pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) {
+		for( size_t pos_before; (pos_before=from->pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) {
 			pos_before++; // including first encloser (and skipping it for next pos)
-			to<<from.mid(pos_after, pos_before).cstr();
+			to<<from->mid(pos_after, pos_before).cstr();
 			to<<encloser; // doubling encloser
 		}
 		// last piece
-		size_t from_length=from.length();
+		size_t from_length=from->length();
 		if(pos_after<from_length)
-			to<<from.mid(pos_after, from_length).cstr();
-
+			to<<from->mid(pos_after, from_length).cstr();
 		to<<encloser;
-	} else
-		to<<from.cstr();
+	} else {
+		to<<encloser<<encloser;
+	}
+}
+
+static void table_to_csv(pa_stringstream& result, Table& table, TableSeparators& separators, bool output_column_names) {
+	if(output_column_names) {
+		if(table.columns()) { // named table
+			if(separators.encloser){
+				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
+					enclose( result, i.next(), separators.encloser );
+					if(i.has_next())
+						result<<separators.column;
+				}
+			} else {
+				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
+					result<<i.next()->cstr();
+					if(i.has_next())
+						result<<separators.column;
+				}
+			}
+		} else { // nameless table [we were asked to output column names]
+			if(int lsize=table.count()?table[0]->count():0)
+				for(int column=0; column<lsize; column++) {
+					if(separators.encloser) {
+						result<<separators.encloser<<column<<separators.encloser;
+					} else {
+						result<<column;
+					}
+					if(column<lsize-1){
+						result<<separators.column;
+					}
+				}
+			else
+				result<<"empty nameless table";
+		}
+		result<<'\n';
+	}
+
+	// process data lines
+	Array_iterator<ArrayString*> i(table);
+	if(separators.encloser){
+		while(i.has_next()) {
+			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
+				enclose( result, c.next(), separators.encloser );
+				if(c.has_next())
+					result<<separators.column;
+			}
+			result<<'\n';
+		}
+	} else {
+		while(i.has_next()) {
+			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
+				result<<c.next()->cstr();
+				if(c.has_next())
+					result<<separators.column;
+			}
+			result<<'\n';
+		}
+	}
 }
 
 #else
 
-void maybe_enclose( String& to, const String& from, char encloser, const String* sencloser ) {
-	if(encloser) {
+void enclose( String& to, const String* from, char encloser, const String* sencloser ) {
+	if(from){
 		to<<*sencloser;
 		// while we have 'encloser'...
 		size_t pos_after=0;
-		for( size_t pos_before; (pos_before=from.pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) {
+		for( size_t pos_before; (pos_before=from->pos( encloser, pos_after ))!=STRING_NOT_FOUND; pos_after=pos_before) {
 			pos_before++; // including first encloser (and skipping it for next pos)
-			to<<from.mid(pos_after, pos_before);
+			to<<from->mid(pos_after, pos_before);
 			to<<*sencloser; // doubling encloser
 		}
 		// last piece
-		size_t from_length=from.length();
+		size_t from_length=from->length();
 		if(pos_after<from_length)
-			to<<from.mid(pos_after, from_length);
-
+			to<<from->mid(pos_after, from_length);
 		to<<*sencloser;
-	} else
-		to<<from;
+	} else {
+		to<<*sencloser<<*sencloser;
+	}
 }
 
+static void table_to_csv(String& result, Table& table, TableSeparators& separators, bool output_column_names) {
+	if(output_column_names) {
+		if(table.columns()) { // named table
+			if(separators.encloser) {
+				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
+					enclose( result, i.next(), separators.encloser, separators.sencloser );
+					if(i.has_next())
+						result<<*separators.scolumn;
+				}
+			} else {
+				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
+					result<<*i.next();
+					if(i.has_next())
+						result<<*separators.scolumn;
+				}
+			}
+		} else { // nameless table [we were asked to output column names]
+			if(int lsize=table.count()?table[0]->count():0)
+				for(int column=0; column<lsize; column++) {
+					if(separators.encloser) {
+						result<<*separators.sencloser<<String::Body::Format(column)<<*separators.sencloser;
+					} else {
+						result<<String::Body::Format(column);
+					}
+					if(column<lsize-1){
+						result<<*separators.scolumn;
+					}
+				}
+			else
+				result.append_help_length("empty nameless table", 0, String::L_CLEAN);
+		}
+		result.append_know_length("\n", 1, String::L_CLEAN);
+	}
+
+	// data lines
+	Array_iterator<ArrayString*> i(table);
+	if(separators.encloser){
+		while(i.has_next()) {
+			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
+				enclose( result, c.next(), separators.encloser, separators.sencloser );
+				if(c.has_next())
+					result<<*separators.scolumn;
+			}
+			result.append_know_length("\n", 1, String::L_CLEAN);
+		}
+	} else {
+		while(i.has_next()) {
+			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
+				result<<*c.next();
+				if(c.has_next())
+					result<<*separators.scolumn;
+			}
+			result.append_know_length("\n", 1, String::L_CLEAN);
+		}
+	}
+}
 #endif // don't use stringstream
 
+
 static void _save(Request& r, MethodParams& params) {
 	const String& first_arg=params.as_string(0, FIRST_ARG_MUST_NOT_BE_CODE);
 	size_t param_index=1;
@@ -479,101 +589,65 @@ static void _save(Request& r, MethodPara
 
 	Table& table=GET_SELF(r, VTable).table();
 
-#if (!defined(NO_STRINGSTREAM) && !defined(FREEBSD4))
-
+#ifdef USE_STRINGSTREAM
 	pa_stringstream ost(std::stringstream::out);
 
-	// process header
-	if(output_column_names) {
-		if(table.columns()) { // named table
-			for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
-				maybe_enclose( ost, *i.next(), separators.encloser );
-				if(i.has_next()){
-					ost<<separators.column;
-				}
-			}
-		} else { // nameless table [we were asked to output column names]
-			if(int lsize=table.count()?table[0]->count():0)
-				for(int column=0; column<lsize; column++) {
-					if(separators.encloser) {
-						ost<<separators.encloser<<column<<separators.encloser;
-					} else {
-						ost<<column;
-					}
-					if(column<lsize-1){
-						ost<<separators.column;
-					}
-				}
-			else
-				ost<<"empty nameless table";
-		}
-		ost<<'\n';
-	}
-
-	// process data lines
-	Array_iterator<ArrayString*> i(table);
-	while(i.has_next()) {
-		for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
-			maybe_enclose( ost, *c.next(), separators.encloser );
-			if(c.has_next())
-				ost<<separators.column;
-		}
-		ost<<'\n';
-	}
+	table_to_csv(ost, table, separators, output_column_names);
 
 	// write
-	{
 		pa_string data=ost.str();
 		const char* data_cstr=data.c_str();
-
 		file_write(r.charsets, file_spec, data_cstr, data.length(), true /* as text */, do_append);
-	}
-
 #else
-
 	String sdata;
-	if(output_column_names) {
-		if(table.columns()) { // named table
-			for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
-				maybe_enclose( sdata, *i.next(), separators.encloser, separators.sencloser );
-				if(i.has_next())
-					sdata<<*separators.scolumn;
-			}
-		} else { // nameless table [we were asked to output column names]
-			if(int lsize=table.count()?table[0]->count():0)
-				for(int column=0; column<lsize; column++) {
-					char *cindex_tab=new(PointerFreeGC) char[MAX_NUMBER];
-					sdata.append_know_length(cindex_tab, 
-						snprintf(cindex_tab, MAX_NUMBER, 
-							column<lsize-1?"%d%c":"%d", column, separators.column),
-							String::L_CLEAN);
-				}
-			else
-				sdata.append_help_length("empty nameless table", 0, String::L_CLEAN);
-		}
-		sdata.append_know_length("\n", 1, String::L_CLEAN);
-	}
 
-	// data lines
-	Array_iterator<ArrayString*> i(table);
-	while(i.has_next()) {
-		for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
-			maybe_enclose( sdata, *c.next(), separators.encloser, separators.sencloser );
-			if(c.has_next())
-				sdata<<*separators.scolumn;
-		}
-		sdata.append_know_length("\n", 1, String::L_CLEAN);
-	}
+	table_to_csv(sdata, table, separators, output_column_names);
 
 	// write
-	{
 		const char* data_cstr=sdata.cstr();
-		file_write(r.charsets, file_spec, data_cstr, sdata.length(), true, do_append);
+	file_write(r.charsets, file_spec, data_cstr, sdata.length(), true /* as text */, do_append);
 		if(*data_cstr) // not empty (when empty it's not heap memory)
 			pa_free((void*)data_cstr); // not needed anymore
+#endif
+}
+
+static void _csv_string(Request& r, MethodParams& params) {
+	bool output_column_names=true;
+	size_t param_index=0;
+	if(params.count()>0 && params[0].is_string()) {
+		if(params.as_string(0, FIRST_ARG_MUST_NOT_BE_CODE)=="nameless") {
+			output_column_names=false;
+			param_index++;
+		} else {
+			throw Exception(PARSER_RUNTIME,
+				0,
+				"bad mode (must be nameless)");
+		}
 	}
 
-#endif // don't use stringstream
+	TableSeparators separators;
+	if(param_index<params.count())
+		if(HashStringValue* options=params.as_hash(param_index++)) {
+			int valid_options=separators.load(*options);
+			if(valid_options!=options->count())
+				throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION);
+		}
+
+	Table& table=GET_SELF(r, VTable).table();
+
+#ifdef USE_STRINGSTREAM
+	pa_stringstream ost(std::stringstream::out);
+
+	table_to_csv(ost, table, separators, output_column_names);
+
+	r.write_no_lang(*new VString(*new String(pa_strdup(ost.str().c_str()), String::L_CLEAN)));
+#else
+	String sdata;
+
+	table_to_csv(sdata, table, separators, output_column_names);
+
+	r.write_no_lang(*new VString(*new String(sdata.cstr(), String::L_CLEAN)));
+#endif
 }
 
 static void _count(Request& r, MethodParams& params) {
@@ -582,7 +656,7 @@ static void _count(Request& r, MethodPar
 	if(params.count()) {
 		const String& param=params.as_string(0, PARAMETER_MUST_BE_STRING);
 		if(param == "columns")
-			result = table.columns() ? table.columns()->count() : 0;
+			result = table.columns() ? table.columns()->count() : table.max_cells();
 		else if(param == "cells")
 			result = table.count() ? table[table.current()]->count() : 0;
 		else if(param == "rows") // synonim for ^table.count[]
@@ -730,7 +804,9 @@ static void table_row_to_hash(Table::ele
 				table=new Table(*info->table, table_options/*no rows, just structure*/);
 				info->hash->put(*key, new VTable(table));
 			}
-			*table+=row;
+			Table::element_type row_copy(new ArrayString(row->count()));
+			row_copy->append(*row);
+			*table+=row_copy;
 			break;
 		}
 	}
@@ -933,8 +1009,7 @@ static void _sort(Request& r, MethodPara
 	}
 
 	// sort keys
-	_qsort(seq, old_count, sizeof(Table_seq_item), 
-		key_values_are_strings?sort_cmp_string:sort_cmp_double);
+	qsort(seq, old_count, sizeof(Table_seq_item), key_values_are_strings?sort_cmp_string:sort_cmp_double);
 
 	// reorder table as they require in 'seq'
 	for(i=0; i<old_count; i++)
@@ -959,10 +1034,9 @@ static bool expression_is_true(Table&, E
 
 static bool _locate_expression(Table& table, Request& r, MethodParams& params) {
 	Value& expression_code=params.as_junction(0, "must be expression");
-	const size_t options_index=1;
-	Table::Action_options o=get_action_options(r, params, options_index, table);
-	check_option_param(o.defined, params, options_index, "locate by expression only has parameters: expression and, maybe, options");
-
+	Table::Action_options o=get_action_options(r, params, 1, table);
+	if(params.count()>2)
+		throw Exception(PARSER_RUNTIME, 0, "locate by expression only has parameters: expression and, maybe, options");
 	Expression_is_true_info info={&r, &expression_code};
 	return table.table_first_that(expression_is_true, &info, o);
 }
@@ -970,10 +1044,7 @@ static bool _locate_expression(Table& ta
 static bool _locate_name_value(Table& table, Request& r, MethodParams& params) {
 	const String& name=params.as_string(0, "column name must be string");
 	const String& value=params.as_string(1, VALUE_MUST_BE_STRING);
-	const size_t options_index=2;
-	Table::Action_options o=get_action_options(r, params, options_index, table);
-	check_option_param(o.defined, params, options_index, "locate by name has parameters: name, value and, maybe, options");
-
+	Table::Action_options o=get_action_options(r, params, 2, table);
 	return table.locate(name, value, o);
 }
 
@@ -991,7 +1062,7 @@ static void _flip(Request& r, MethodPara
 	Table& old_table=GET_SELF(r, VTable).table();
 	Table& new_table=*new Table(0);
 	if(size_t old_count=old_table.count())
-		if(size_t old_cols=old_table.columns()?old_table.columns()->count():old_table[0]->count()) 
+		if(size_t old_cols=old_table.columns()?old_table.columns()->count():old_table.max_cells())
 			for(size_t column=0; column<old_cols; column++) {
 				Table::element_type new_row(new ArrayString(old_count));
 				for(size_t i=0; i<old_count; i++) {
@@ -1029,9 +1100,9 @@ static void _foreach(Request& r, MethodP
 			table.set_current(row);
 
 			if(rownum_var_name)
-				var_context->put_element(*rownum_var_name, new VString(*new String(String::Body::Format(row), String::L_CLEAN)), false);
+				r.put_element(*var_context, *rownum_var_name, new VString(*new String(String::Body::Format(row), String::L_CLEAN)));
 			if(value_var_name)
-				var_context->put_element(*value_var_name, new VTable(&table), false);
+				r.put_element(*var_context, *value_var_name, new VTable(&table));
 
 			StringOrValue sv_processed=r.process(body_code);
 			Request::Skip lskip=r.get_skip(); r.set_skip(Request::SKIP_NOTHING);
@@ -1054,9 +1125,9 @@ static void _foreach(Request& r, MethodP
 			table.set_current(row);
  
 			if(rownum_var_name)
-				var_context->put_element(*rownum_var_name, new VString(*new String(String::Body::Format(row), String::L_CLEAN)), false);
+				r.put_element(*var_context, *rownum_var_name, new VString(*new String(String::Body::Format(row), String::L_CLEAN)));
 			if(value_var_name)
-				var_context->put_element(*value_var_name, new VTable(&table), false);
+				r.put_element(*var_context, *value_var_name, new VTable(&table));
 
 			r.process_write(body_code);
 			Request::Skip lskip=r.get_skip(); r.set_skip(Request::SKIP_NOTHING);
@@ -1068,16 +1139,56 @@ static void _foreach(Request& r, MethodP
 	table.set_current(saved_current);
 }
 
-static void _append(Request& r, MethodParams& params) {
+static void update_cell(HashStringValue::key_type aname, HashStringValue::value_type avalue, VTable *dest) {
+	dest->put_element(String(aname, String::L_CLEAN), avalue); // new not required
+}
+
+inline Table::element_type row_from_string(Request& r, Value &param){
+	if(!param.is_string() && !param.get_junction())
+		throw Exception(PARSER_RUNTIME, 0, "row must be string, code or hash");
+
 	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
-	const String& string=r.process_to_string(params[0]);
+	const String& string=r.process_to_string(param);
 
 	// parse cells
 	Table::element_type row=new ArrayString;
 	size_t pos_after=0;
 	string.split(*row, pos_after, "\t", String::L_AS_IS);
 
-	GET_SELF(r, VTable).table()+=row;
+	return row;
+}
+
+static void _append(Request& r, MethodParams& params) {
+	VTable vtable=GET_SELF(r, VTable);
+	Table& table=vtable.table();
+
+	HashStringValue* hash=params[0].get_hash();
+	if(hash){
+		table+=new ArrayString();
+		size_t saved_current=table.current();
+		table.set_current(table.count()-1);
+		hash->for_each<VTable*>(update_cell, &vtable);
+		table.set_current(saved_current);
+	} else {
+		table+=row_from_string(r, params[0]);
+	}
+}
+
+static void _insert(Request& r, MethodParams& params) {
+	VTable vtable=GET_SELF(r, VTable);
+	Table& table=vtable.table();
+	HashStringValue* hash=params[0].get_hash();
+	if(hash){
+		table.insert(table.current(), new ArrayString());
+		hash->for_each<VTable*>(update_cell, &vtable);
+	} else {
+		table.insert(table.current(), row_from_string(r, params[0]));
+	}
+}
+
+static void _delete(Request& r, MethodParams& params) {
+	Table& table=GET_SELF(r, VTable).table();
+	table.remove_current();
 }
 
 static void join_named_row(Table& src, Table* dest) {
@@ -1097,7 +1208,6 @@ static void _join(Request& r, MethodPara
 	Table& src=*params.as_table(0, "source");
 
 	Table::Action_options o=get_action_options(r, params, 1, src);
-	check_option_param(o.defined, params, 1, "invalid extra parameter");
 
 	Table& dest=GET_SELF(r, VTable).table();
 	if(&src == &dest)
@@ -1180,7 +1290,7 @@ static void marshal_bind(
 // not static, used elsewhere
 int marshal_binds(HashStringValue& hash, SQL_Driver::Placeholder*& placeholders) {
 	int hash_count=hash.count();
-	placeholders=new(UseGC) SQL_Driver::Placeholder[hash_count];
+	placeholders=new SQL_Driver::Placeholder[hash_count];
 	SQL_Driver::Placeholder* ptr=placeholders;
 	hash.for_each<SQL_Driver::Placeholder**>(marshal_bind, &ptr);
 	return hash_count;
@@ -1360,6 +1470,11 @@ MTable::MTable(): Methoded("table") {
 
 	// add_native_method("save_old", Method::CT_DYNAMIC, _save_old, 1, 3);
 
+	// ^table.csv-string[]
+	// ^table.csv-string[nameless]
+	// ^table.csv-string[nameless;$.encloser["] $.separator[,]]
+	add_native_method("csv-string", Method::CT_DYNAMIC, _csv_string, 0, 2);
+
 	// ^table.count[]
 	// ^table.count[rows]
 	// ^table.count[columns]
@@ -1396,9 +1511,15 @@ MTable::MTable(): Methoded("table") {
 	// ^table.foreach[row-num;value]{code}[delim]
 	add_native_method("foreach", Method::CT_DYNAMIC, _foreach, 3, 4);
 
-	// ^table.append{r{tab}e{tab}c{tab}o{tab}r{tab}d}
+	// ^table.append{row{tab}data}
 	add_native_method("append", Method::CT_DYNAMIC, _append, 1, 1);
 
+	// ^table.insert{row{tab}data} before current row
+	add_native_method("insert", Method::CT_DYNAMIC, _insert, 1, 1);
+
+	// ^table.delete[] current row
+	add_native_method("delete", Method::CT_DYNAMIC, _delete, 0, 0);
+
 	// ^table.join[table][$.limit(10) $.offset(1) $.offset[cur] ]
 	add_native_method("join", Method::CT_DYNAMIC, _join, 1, 2);