--- parser3/src/classes/table.C	2015/08/02 21:21:25	1.308
+++ parser3/src/classes/table.C	2016/07/29 22:40:58	1.317
@@ -1,7 +1,7 @@
 /** @file
 	Parser: @b table parser class.
 
-	Copyright (c) 2001-2012 Art. Lebedev Studio (http://www.artlebedev.com)
+	Copyright (c) 2001-2015 Art. Lebedev Studio (http://www.artlebedev.com)
 	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 */
 
@@ -22,7 +22,7 @@
 #define USE_STRINGSTREAM
 #endif
 
-volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.308 2015/08/02 21:21:25 moko Exp $";
+volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.317 2016/07/29 22:40:58 moko Exp $";
 
 // class
 
@@ -35,7 +35,7 @@ public:
 
 // global variable
 
-DECLARE_CLASS_VAR(table, new MTable, 0);
+DECLARE_CLASS_VAR(table, new MTable);
 
 #define TABLE_REVERSE_NAME "reverse"
 
@@ -656,7 +656,7 @@ static void _count(Request& r, MethodPar
 	if(params.count()) {
 		const String& param=params.as_string(0, PARAMETER_MUST_BE_STRING);
 		if(param == "columns")
-			result = table.columns() ? table.columns()->count() : 0;
+			result = table.columns() ? table.columns()->count() : table.max_cells();
 		else if(param == "cells")
 			result = table.count() ? table[table.current()]->count() : 0;
 		else if(param == "rows") // synonim for ^table.count[]
@@ -705,11 +705,10 @@ static void _menu(Request& r, MethodPara
 
 	Table& table=GET_SELF(r, VTable).table();
 	size_t saved_current=table.current();
-	size_t size=table.count();
 
 	if(delim_maybe_code) { // delimiter set
 		bool need_delim=false;
-		for(size_t row=0; row<size; row++) {
+		for(size_t row=0; row<table.count(); row++) {
 			table.set_current(row);
 
 			StringOrValue sv_processed=r.process(body_code);
@@ -729,7 +728,7 @@ static void _menu(Request& r, MethodPara
 				break;
 		}
 	} else {
-		for(size_t row=0; row<size; row++) {
+		for(size_t row=0; row<table.count(); row++) {
 			table.set_current(row);
  
 			r.process_write(body_code);
@@ -749,6 +748,7 @@ struct Row_info {
 	Value* key_code;
 	size_t key_field;
 	Array<int>* value_fields;
+	Value* value_code;
 	HashStringValue* hash;
 	Table2hash_distint distinct;
 	size_t row;
@@ -771,8 +771,12 @@ static void table_row_to_hash(Table::ele
 	bool exist=false;
 	switch(info->value_type) {
 		case C_STRING: {
-			size_t index=info->value_fields->get(0);
-			exist=info->hash->put_dont_replace(*key, (index < row->count()) ? new VString(*row->get(index)) : new VString());
+			if(info->value_fields->count()){
+				size_t index=info->value_fields->get(0);
+				exist=info->hash->put_dont_replace(*key, (index < row->count()) ? new VString(*row->get(index)) : VString::empty());
+			} else {
+				exist=info->hash->put_dont_replace(*key, VString::empty());
+			}
 			break;
 		}
 		case C_HASH: {
@@ -781,9 +785,7 @@ static void table_row_to_hash(Table::ele
 			for(Array_iterator<int> i(*info->value_fields); i.has_next(); ) {
 				size_t value_field=i.next();
 				if(value_field<row->count())
-					hash.put(
-						*info->table->columns()->get(value_field), 
-						new VString(*row->get(value_field)));
+					hash.put(*info->table->columns()->get(value_field), new VString(*row->get(value_field)));
 			}
 
 			exist=info->hash->put_dont_replace(*key, vhash);
@@ -809,11 +811,15 @@ static void table_row_to_hash(Table::ele
 			*table+=row_copy;
 			break;
 		}
+		case C_CODE: {
+			if(!info->key_code)
+				info->table->set_current(info->row++); // change context row
+			exist=info->hash->put_dont_replace(*key, &info->r->process(*info->value_code).as_value());
+			break;
+		}
 	}
 	if(exist && info->distinct==D_ILLEGAL)
-		throw Exception(PARSER_RUNTIME,
-			key,
-			"duplicate key");
+		throw Exception(PARSER_RUNTIME, key, "duplicate key");
 }
 
 Table2hash_value_type get_value_type(Value& vvalue_type){
@@ -826,15 +832,22 @@ Table2hash_value_type get_value_type(Val
 		} else if (svalue_type == "hash") {
 			return C_HASH;
 		} else {
-			throw Exception(PARSER_RUNTIME,
-				&svalue_type,
-				"must be 'hash', 'table' or 'string'");
+			throw Exception(PARSER_RUNTIME, &svalue_type, "must be 'hash', 'table' or 'string'");
 		}
 	} else {
-		throw Exception(PARSER_RUNTIME,
-			0,
-			"'type' must be hash");
+		throw Exception(PARSER_RUNTIME, 0, "'type' must be string");
+	}
+}
+
+static Table2hash_distint get_distinct(Value& vdistinct, Table2hash_value_type& value_type){
+	if(vdistinct.is_string()) {
+		const String& sdistinct=*vdistinct.get_string();
+		if(sdistinct!="tables")
+			throw Exception(PARSER_RUNTIME, &sdistinct, "must be 'tables' or true/false");
+		value_type=C_TABLE;
+		return D_FIRST;
 	}
+	return vdistinct.as_bool() ? D_FIRST : D_ILLEGAL;
 }
 
 static void _hash(Request& r, MethodParams& params) {
@@ -846,32 +859,22 @@ static void _hash(Request& r, MethodPara
 			Table2hash_value_type value_type=C_HASH;
 			int param_index=params.count()-1;
 			if(param_index>0) {
-				if(HashStringValue* options=params.as_no_junction(param_index, PARAM_MUST_NOT_BE_CODE).get_hash()){ // can't use .as_has because the 2nd param could be table so .as_hash throws an error
+
+				if(params[1].get_junction())
+					value_type=C_CODE;
+
+				if(HashStringValue* options=params[param_index].get_hash()){ // can't use .as_hash because the 2nd param could be table so .as_hash throws an error
 					--param_index;
 					int valid_options=0;
 					if(Value* vdistinct_code=options->get(sql_distinct_name)) { // $.distinct ?
 						valid_options++;
-						Value& vdistinct_value=r.process_to_value(*vdistinct_code);
-						if(vdistinct_value.is_string()) {
-							const String& sdistinct=*vdistinct_value.get_string();
-							if(sdistinct=="tables") {
-								value_type=C_TABLE;
-								distinct=D_FIRST;
-							} else {
-								throw Exception(PARSER_RUNTIME,
-									&sdistinct,
-									"must be 'tables' or true/false");
-							}
-						} else {
-							distinct=vdistinct_value.as_bool()?D_FIRST:D_ILLEGAL;
-						}
+						distinct=get_distinct(r.process_to_value(*vdistinct_code), value_type);
 					}
 					if(Value* vvalue_type_code=options->get(sql_value_type_name)) { // $.type ?
 						if(value_type==C_TABLE) // $.distinct[tables] already was specified
-							throw Exception(PARSER_RUNTIME,
-								0,
-								"you can't specify $.distinct[tables] and $.type[] together");
-
+							throw Exception(PARSER_RUNTIME, 0, "you can't specify $.distinct[tables] and $.type[] together");
+						if(value_type==C_CODE)
+							throw Exception(PARSER_RUNTIME, 0, "you can't specify $.type[] if value is code");
 						valid_options++;
 						value_type=get_value_type(r.process_to_value(*vvalue_type_code));
 					}
@@ -881,59 +884,57 @@ static void _hash(Request& r, MethodPara
 				}
 			}
 
-			if(param_index==2) // options was specified but not as hash
+			if(param_index==2) // options were specified but not as hash
 				throw Exception(PARSER_RUNTIME, 0, "options must be hash");
 
 			Array<int> value_fields;
+			Value* value_code=0;
+
 			if(param_index==0){ // list of columns wasn't specified
 				if(value_type==C_STRING) // $.type[string]
-					throw Exception(PARSER_RUNTIME,
-						0,
-						"you must specify one value field with option $.type[string]");
+					throw Exception(PARSER_RUNTIME, 0, "you must specify one value field with option $.type[string]");
 				
 				for(size_t i=0; i<columns->count(); i++) // by all columns, including key
 					value_fields+=i;
 
-			} else { // list of columns was specified
+			} else { // list of columns or code was specified
 				if(value_type==C_TABLE)
-					throw Exception(PARSER_RUNTIME,
-						0,
-						"you can't specify value field(s) with option $.distinct[tables] or $.type[tables]");
-
-				Value& value_fields_param=params.as_no_junction(param_index, "value field(s) must not be code");
-				if(value_fields_param.is_string()) { // one column as string was specified
-					value_fields+=self_table.column_name2index(*value_fields_param.get_string(), true);
+					throw Exception(PARSER_RUNTIME, 0, "you can't specify value field(s) with option $.distinct[tables] or $.type[tables]");
+
+				Value& value_fields_param=params[1];
+				if(value_fields_param.get_junction()){ // code specified
+					value_code=&value_fields_param;
+				} else if(value_fields_param.is_string()) { // one column as string was specified
+					const String &field_name=*value_fields_param.get_string();
+					if(!field_name.is_empty())
+						value_fields+=self_table.column_name2index(field_name, true);
 				} else if(Table* value_fields_table=value_fields_param.get_table()) { // list of columns were specified in table
 					for(Array_iterator<Table::element_type> i(*value_fields_table); i.has_next(); ) {
 						const String& value_field_name =*i.next()->get(0);
 						value_fields +=self_table.column_name2index(value_field_name, true);
 					}
 				} else
-					throw Exception(PARSER_RUNTIME,
-						0,
-						"value field(s) must be string or table");
+					throw Exception(PARSER_RUNTIME, 0, "value field(s) must be string or table or code");
 			}
 
 			if(value_type==C_STRING && value_fields.count()!=1)
-				throw Exception(PARSER_RUNTIME,
-					0,
-					"you can specify only one value field with option $.type[string]");
+				throw Exception(PARSER_RUNTIME, 0, "you can specify only one value field with option $.type[string]");
 
 			{
 				Value* key_param=&params[0];
 				Row_info info={
 					&r,
 					&self_table,
-					/*key_code=*/key_param->get_junction()?key_param:0,
+					/*key_code=*/key_param->get_junction() ? key_param : 0,
 					/*key_field=*/0/*filled below*/,
 					&value_fields,
+					value_code,
 					&result.hash(),
 					distinct,
 					/*row=*/0,
 					value_type
 				};
-				info.key_field=(info.key_code?-1
-						:self_table.column_name2index(key_param->as_string(), true));
+				info.key_field=(info.key_code ? -1 : self_table.column_name2index(key_param->as_string(), true));
 
 				int saved_current=self_table.current();
 				self_table.for_each(table_row_to_hash, &info);
@@ -1062,7 +1063,7 @@ static void _flip(Request& r, MethodPara
 	Table& old_table=GET_SELF(r, VTable).table();
 	Table& new_table=*new Table(0);
 	if(size_t old_count=old_table.count())
-		if(size_t old_cols=old_table.columns()?old_table.columns()->count():old_table[0]->count()) 
+		if(size_t old_cols=old_table.columns()?old_table.columns()->count():old_table.max_cells())
 			for(size_t column=0; column<old_cols; column++) {
 				Table::element_type new_row(new ArrayString(old_count));
 				for(size_t i=0; i<old_count; i++) {
@@ -1087,7 +1088,6 @@ static void _foreach(Request& r, MethodP
 
 	Table& table=GET_SELF(r, VTable).table();
 	size_t saved_current=table.current();
-	size_t size=table.count();
 
 	const String* rownum_var_name=rownum_name.is_empty()? 0 : &rownum_name;
 	const String* value_var_name=value_name.is_empty()? 0 : &value_name;
@@ -1096,7 +1096,7 @@ static void _foreach(Request& r, MethodP
 
 	if(delim_maybe_code) { // delimiter set
 		bool need_delim=false;
-		for(size_t row=0; row<size; row++) {
+		for(size_t row=0; row<table.count(); row++) {
 			table.set_current(row);
 
 			if(rownum_var_name)
@@ -1121,7 +1121,7 @@ static void _foreach(Request& r, MethodP
 				break;
 		}
 	} else {
-		for(size_t row=0; row<size; row++) {
+		for(size_t row=0; row<table.count(); row++) {
 			table.set_current(row);
  
 			if(rownum_var_name)
@@ -1139,32 +1139,54 @@ static void _foreach(Request& r, MethodP
 	table.set_current(saved_current);
 }
 
-static void _append(Request& r, MethodParams& params) {
+static void update_cell(HashStringValue::key_type aname, HashStringValue::value_type avalue, VTable *dest) {
+	dest->put_element(String(aname, String::L_CLEAN), avalue); // new not required
+}
+
+inline Table::element_type row_from_string(Request& r, Value &param){
+	if(!param.is_string() && !param.get_junction())
+		throw Exception(PARSER_RUNTIME, 0, "row must be string, code or hash");
+
 	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
-	const String& string=r.process_to_string(params[0]);
+	const String& string=r.process_to_string(param);
 
 	// parse cells
 	Table::element_type row=new ArrayString;
 	size_t pos_after=0;
 	string.split(*row, pos_after, "\t", String::L_AS_IS);
 
-	GET_SELF(r, VTable).table()+=row;
+	return row;
 }
 
-static void _insert(Request& r, MethodParams& params) {
-	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
-	const String& string=r.process_to_string(params[0]);
+static void _append(Request& r, MethodParams& params) {
+	VTable vtable=GET_SELF(r, VTable);
+	Table& table=vtable.table();
 
-	// parse cells
-	Table::element_type row=new ArrayString;
-	size_t pos_after=0;
-	string.split(*row, pos_after, "\t", String::L_AS_IS);
+	HashStringValue* hash=params[0].get_hash();
+	if(hash){
+		table+=new ArrayString();
+		size_t saved_current=table.current();
+		table.set_current(table.count()-1);
+		hash->for_each<VTable*>(update_cell, &vtable);
+		table.set_current(saved_current);
+	} else {
+		table+=row_from_string(r, params[0]);
+	}
+}
 
-	Table& table=GET_SELF(r, VTable).table();
-	table.insert(table.current(), row);
+static void _insert(Request& r, MethodParams& params) {
+	VTable vtable=GET_SELF(r, VTable);
+	Table& table=vtable.table();
+	HashStringValue* hash=params[0].get_hash();
+	if(hash){
+		table.insert(table.current(), new ArrayString());
+		hash->for_each<VTable*>(update_cell, &vtable);
+	} else {
+		table.insert(table.current(), row_from_string(r, params[0]));
+	}
 }
 
-static void _delete(Request& r, MethodParams& params) {
+static void _delete(Request& r, MethodParams&) {
 	Table& table=GET_SELF(r, VTable).table();
 	table.remove_current();
 }