--- parser3/src/classes/table.C	2016/07/29 20:30:10	1.316
+++ parser3/src/classes/table.C	2016/09/21 15:14:39	1.331
@@ -22,7 +22,7 @@
 #define USE_STRINGSTREAM
 #endif
 
-volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.316 2016/07/29 20:30:10 moko Exp $";
+volatile const char * IDENT_TABLE_C="$Id: table.C,v 1.331 2016/09/21 15:14:39 moko Exp $";
 
 // class
 
@@ -51,8 +51,7 @@ String table_reverse_name(TABLE_REVERSE_
 
 // methods
 
-static Table::Action_options get_action_options(Request& r, MethodParams& params, 
-						size_t options_index, const Table& source) {
+static Table::Action_options get_action_options(Request& r, MethodParams& params, size_t options_index, const Table& source) {
 	Table::Action_options result;
 	if(params.count() <= options_index)
 		return result;
@@ -73,9 +72,7 @@ static Table::Action_options get_action_
 			if(soffset == "cur")
 				result.offset=source.current();
 			else
-				throw Exception(PARSER_RUNTIME,
-					&soffset,
-					"must be 'cur' string or expression");
+				throw Exception(PARSER_RUNTIME, &soffset, "must be 'cur' string or expression");
 		} else 
 			result.offset=r.process_to_value(*voffset).as_int();
 	}
@@ -96,23 +93,27 @@ static Table::Action_options get_action_
 	return result;
 }
 
-struct TableSeparators {
-	char column;  const String* scolumn;
+struct TableControlChars {
+	char separator;  const String* sseparator;
 	char encloser; const String* sencloser;
 
-	TableSeparators():
-		column('\t'), scolumn(new String("\t")),
+	char separators[3];
+
+	TableControlChars():
+		separator('\t'), sseparator(new String("\t")),
 		encloser(0), sencloser(0)
-	{}
+	{
+		strcpy(separators,"\t\n");
+	}
+
 	int load( HashStringValue& options ) {
 		int result=0;
 		if(Value* vseparator=options.get(PA_COLUMN_SEPARATOR_NAME)) {
-			scolumn=&vseparator->as_string();
-			if(scolumn->length()!=1)
-				throw Exception(PARSER_RUNTIME,
-					scolumn,
-					"separator must be one character long");
-			column=scolumn->first_char();
+			sseparator=&vseparator->as_string();
+			if(sseparator->length()!=1)
+				throw Exception(PARSER_RUNTIME, sseparator, "separator must be one byte character");
+			separator=sseparator->first_char();
+			separators[0]=separator;
 			result++;
 		}
 		if(Value* vencloser=options.get(PA_COLUMN_ENCLOSER_NAME)) {
@@ -120,11 +121,9 @@ struct TableSeparators {
 			if(sencloser->is_empty()){
 				encloser=0;
 			} else {
-			if(sencloser->length()!=1)
-				throw Exception(PARSER_RUNTIME,
-					sencloser,
-					"encloser must be one character long");
-			encloser=sencloser->first_char();
+				if(sencloser->length()!=1)
+					throw Exception(PARSER_RUNTIME, sencloser, "encloser must be empty or one byte character");
+				encloser=sencloser->first_char();
 			}
 			result++;
 		}
@@ -132,6 +131,119 @@ struct TableSeparators {
 	}
 };
 
+
+struct lsplit_sresult {
+	String* piece;
+	char delim;
+
+	lsplit_sresult() : piece(0), delim(0){}
+
+	operator bool() { return piece!=0; }
+
+	void append(String *str){
+		if(piece)
+			*piece << *str;
+		else
+			piece = str;
+	}
+};
+
+class StringSplitHelper : public String {
+public:
+	char* base;
+
+	StringSplitHelper(String astring) : String(astring), base(cstrm()) {}
+
+	bool check_lang(const char *pos){
+		return langs.check_lang(L_AS_IS, pos-base, 1);
+	}
+
+	String *extract(char *pos){
+		String *result=new String;
+		if(size_t len=strlen(pos)){
+			// first: their langs
+			result->langs.append(result->body, langs, pos-base, len);
+			// next: letters themselves
+			result->body=Body(pos);
+		}
+		return result;
+	}
+};
+
+inline lsplit_sresult lsplit(char* *string_ref, const char* delims, StringSplitHelper& helper) {
+	lsplit_sresult result;
+	if(char *pos=*string_ref) {
+		while(pos=strpbrk(pos, delims)) {
+			if(helper.check_lang(pos)){
+				result.delim=*pos;
+				*pos=0;
+				result.piece=helper.extract(*string_ref);
+				*string_ref=pos+1;
+				return result;
+			}
+			pos++;
+		}
+		result.piece=helper.extract(*string_ref);
+		*string_ref=0;
+	}
+	return result;
+}
+
+static lsplit_sresult lsplit(char** string_ref, const char* delims, char encloser, StringSplitHelper& helper) {
+	lsplit_sresult result;
+
+	if(char *pos=*string_ref) {
+		if(encloser && *pos==encloser && helper.check_lang(pos)) {
+			*string_ref=++pos;
+
+			// we are enclosed, searching for second encloser
+			while(1) {
+				if(pos=strchr(pos, encloser)){
+					if(helper.check_lang(pos)){
+						*(pos++)=0;
+						result.append(helper.extract(*string_ref));
+						if(*pos==encloser && helper.check_lang(pos)){ // double-encloser stands for encloser
+							*string_ref=pos++;
+						} else {
+							*string_ref=pos;
+							break;
+						}
+					}
+				} else {
+					result.append(helper.extract(*string_ref));
+					*string_ref=0;
+					return result;
+				}
+			}
+
+			// we are no longer enclosed, searching for delimiter
+			while(pos=strpbrk(pos, delims)) {
+				if(helper.check_lang(pos)){
+					result.delim=*pos;
+					if(pos>*string_ref){
+						*pos=0;
+						result.append(helper.extract(*string_ref));
+					}
+					*string_ref=pos+1;
+					return result;
+				}
+				pos++;
+			}
+			result.append(helper.extract(*string_ref));
+			*string_ref=0;
+		} else
+			return lsplit(string_ref, delims, helper);
+	}
+	return result;
+}
+
+static void skip_clean_empty_lines(char** data_ref, StringSplitHelper& helper) {
+	if(*data_ref) {
+		while(**data_ref == '\n' && helper.check_lang(*data_ref))
+			(*data_ref)++;
+	}
+}
+
 static void _create(Request& r, MethodParams& params) {
 	// clone/copy part?
 	if(Table *source=params[0].get_table()) {
@@ -149,75 +261,59 @@ static void _create(Request& r, MethodPa
 		if(params[0].is_string()){ // can be nameless only
 			const String& snameless=params.as_string(0, "called with more then 1 param, first param may be only string 'nameless' or junction");
 			if(snameless!="nameless")
-				throw Exception(PARSER_RUNTIME,
-					&snameless,
-					"table::create called with more then 1 param, first param may be only 'nameless'");
+				throw Exception(PARSER_RUNTIME, &snameless, "table::create called with more then 1 param, first param may be only 'nameless'");
 			nameless=true;
 			data_param_index++;
 		}
 	}
 
 	HashStringValue *options=0;
-	TableSeparators separators;
+	TableControlChars control_chars;
 
 	size_t options_param_index=data_param_index+1;
-	if(
-		options_param_index<params.count()
-		&& (options=params.as_hash(options_param_index))
-	) {
-		// cloning, so that we could change
-		options=new HashStringValue(*options);
-		separators.load(*options);
-		if(separators.encloser){
-			throw Exception(PARSER_RUNTIME,
-				0,
-				"encloser not supported for table::create yet");
-		}
+	if( options_param_index<params.count() && (options=params.as_hash(options_param_index)) ) {
+		if(control_chars.load(*options)!=options->count())
+			throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION);
 	}
 
 	// data
 	Temp_lang temp_lang(r, String::L_PASS_APPENDED);
-	const String&  data=
-		r.process_to_string(params.as_junction(data_param_index, "body must be table or code"));
+	StringSplitHelper sdata(r.process_to_string(params.as_junction(data_param_index, "body must be table or code")));
+	char *data=sdata.base;
 
 	// parse columns
-	size_t raw_pos_after=0;
 	Table::columns_type columns;
-
-	if(nameless){
-		columns=Table::columns_type(0); // nameless
+	if(nameless) {
+		columns=0; // nameless
 	} else {
-		columns=Table::columns_type(new ArrayString);
-
-		ArrayString head;
-		data.split(head, raw_pos_after, "\n", String::L_AS_IS, 1);
-		if(head.count()) {
-			size_t col_pos_after=0;
-			if(head[0]->is_empty())
-				*columns += new String();
-			else
-				head[0]->split(*columns, col_pos_after, *separators.scolumn, String::L_AS_IS);
+		columns=new ArrayString;
+		while( lsplit_sresult sr=lsplit(&data, control_chars.separators, control_chars.encloser, sdata) ) {
+			*columns+=sr.piece;
+			if(sr.delim=='\n') 
+				break;
 		}
 	}
-
+	
 	Table& table=*new Table(columns);
-	// parse cells
-
-	ArrayString rows;
-	data.split(rows, raw_pos_after, "\n", String::L_AS_IS);
-	Array_iterator<const String*> i(rows);
-	while(i.has_next()) {
-		Table::element_type row(new ArrayString);
-		const String& string=*i.next();
-		// remove comment lines
-		if(string.is_empty())
-			continue;
+	int columns_count=columns ? columns->count(): 0;
 
-		size_t col_pos_after=0;
-		string.split(*row, col_pos_after, *separators.scolumn, String::L_AS_IS);
-		table+=row;
+	// parse cells
+	Table::element_type row(new ArrayString(columns_count));
+	skip_clean_empty_lines(&data, sdata);
+	while( lsplit_sresult sr=lsplit(&data, control_chars.separators, control_chars.encloser, sdata) ) {
+		if(sr.piece->is_empty() && !sr.delim && !row->count()) // append last empty column [if without \n]
+			break;
+		*row+=sr.piece;
+		if(sr.delim=='\n') {
+			table+=row;
+			row=new ArrayString(columns_count);
+			skip_clean_empty_lines(&data, sdata);
+		}
 	}
-
+	// last line [if without \n]
+	if(row->count())
+		table+=row;
+	
 	// replace any previous table value
 	GET_SELF(r, VTable).set_table(table);
 }
@@ -226,45 +322,36 @@ struct lsplit_result {
 	char* piece;
 	char delim;
 
+	lsplit_result(char *apiece=0) : piece(apiece), delim(0){}
 	operator bool() { return piece!=0; }
 };
 
-inline lsplit_result lsplit(char* string, char delim1, char delim2) {
-	lsplit_result result;
-	if(string) {
-		char delims[]={delim1, delim2, 0};
-		if(char* v=strpbrk(string, delims)) {
+inline lsplit_result lsplit(char* *string_ref, const char* delims) {
+	lsplit_result result(*string_ref);
+	if(result.piece) {
+		if(char* v=strpbrk(result.piece, delims)) {
 			result.delim=*v;
 			*v=0;
-			result.piece=v+1;
+			*string_ref=v+1;
 			return result;
 		}
+		*string_ref=0;
 	}
-	result.piece=0;
-	result.delim=0;
-	return result;
-}
-
-inline lsplit_result lsplit(char* *string_ref, char delim1, char delim2) {
-	lsplit_result result;
-	result.piece=*string_ref;
-	lsplit_result next=lsplit(*string_ref, delim1, delim2);
-	result.delim=next.delim;
-	*string_ref=next.piece;
 	return result;
 }
 
-static lsplit_result lsplit(char** string_ref, char delim1, char delim2, char encloser) {
-	lsplit_result result;
+static lsplit_result lsplit(char** string_ref, const char* delims, char encloser) {
+	lsplit_result result(*string_ref);
 
-	if(char* string=*string_ref) {
-		if(encloser && *string==encloser) {
-			string++;
+	if(result.piece) {
+		if(encloser && *result.piece==encloser) {
+			result.piece++;
 			
+			char c;
 			char *read;
 			char *write;
-			write=read=string;
-			char c;
+			write=read=result.piece;
+
 			// we are enclosed, searching for second encloser
 			while(c=*read++) {
 				if(c==encloser) {
@@ -275,50 +362,42 @@ static lsplit_result lsplit(char** strin
 				}
 				*write++=c;
 			}
-			// we are no longer enclosed, searching for delimiter, skipping extra enclosers
+
+			// we are no longer enclosed, searching for delimiter
 			while(c=*read++) {
-				if(c==delim1 || c==delim2) {
+				if(c==delims[0] || c==delims[1]) {
 					result.delim=c;
 					break;
-				} else 	if(c!=encloser)
+				} else 
 					*write++=c;
 			}
+
 			*write=0; // terminate
-			*string_ref=c? read: 0;
-			result.piece=string;
+			*string_ref=c ? read : 0;
 			return result;
 		} else
-			return lsplit(string_ref, delim1, delim2);
+			return lsplit(string_ref, delims);
 	}
-	result.piece=0;
 	return result;
 }
 
 static void skip_empty_and_comment_lines( char** data_ref ) {
-	if(char *data=*data_ref) {
-		while( char c=*data ) {
-			if( c== '\n' || c == '#' ) {
-				/*nowhere=*/getrow(&data); // remove empty&comment lines
-				if(!(*data_ref=data))
-					break;
-				continue;
-			}
-			break;
+	while(*data_ref) {
+		if(**data_ref == '\n'){
+			(*data_ref)++;
+		} else {
+			if(**data_ref == '#' )
+				/*nowhere=*/getrow(data_ref);
+			else
+				break;
 		}
 	}
 }
 
 static void skip_empty_lines( char** data_ref ) {
-	if(char *data=*data_ref) {
-		while( char c=*data ) {
-			if( c== '\n' ) {
-				/*nowhere=*/getrow(&data); // remove empty lines
-				if(!(*data_ref=data))
-					break;
-				continue;
-			}
-			break;
-		}
+	if(*data_ref) {
+		while(**data_ref == '\n')
+			(*data_ref)++;
 	}
 }
 
@@ -333,32 +412,28 @@ static void _load(Request& r, MethodPara
 	size_t options_param_index=filename_param_index+1;
 
 	HashStringValue *options=0;
-	TableSeparators separators;
+	TableControlChars control_chars;
 	if(options_param_index<params.count()
 		&& (options=params.as_hash(options_param_index))) {
 		// cloning, so that we could change [to simplify checks on params inside file_read_text
 		options=new HashStringValue(*options);
-		separators.load(*options);
+		control_chars.load(*options);
 	}
 
 	// loading text
-	char *data=file_load_text(r,
-		r.absolute(params.as_string(filename_param_index, FILE_NAME_MUST_BE_STRING)),
-		true,
-		options
-	);
+	char *data=file_load_text(r, r.absolute(params.as_string(filename_param_index, FILE_NAME_MUST_BE_STRING)), true, options);
 
-	Skip_lines_action skip_lines_action = (separators.column=='#' || separators.encloser=='#') ? skip_empty_lines : skip_empty_and_comment_lines;
+	Skip_lines_action skip_lines_action = (control_chars.separator=='#' || control_chars.encloser=='#') ? skip_empty_lines : skip_empty_and_comment_lines;
 
 	// parse columns
 	Table::columns_type columns;
 	if(nameless) {
-		columns=Table::columns_type(0); // nameless
+		columns=0; // nameless
 	} else {
-		columns=Table::columns_type(new ArrayString);
+		columns=new ArrayString;
 
 		skip_lines_action(&data);
-		while( lsplit_result sr=lsplit(&data, separators.column, '\n', separators.encloser) ) {
+		while( lsplit_result sr=lsplit(&data, control_chars.separators, control_chars.encloser) ) {
 			*columns+=new String(sr.piece, String::L_TAINTED);
 			if(sr.delim=='\n') 
 				break;
@@ -366,12 +441,12 @@ static void _load(Request& r, MethodPara
 	}
 	
 	Table& table=*new Table(columns);
-	int columns_count=columns? columns->count(): 0;
+	int columns_count=columns ? columns->count(): 0;
 
 	// parse cells
 	Table::element_type row(new ArrayString(columns_count));
 	skip_lines_action(&data);
-	while( lsplit_result sr=lsplit(&data, separators.column, '\n', separators.encloser) ) {
+	while( lsplit_result sr=lsplit(&data, control_chars.separators, control_chars.encloser) ) {
 		if(!*sr.piece && !sr.delim && !row->count()) // append last empty column [if without \n]
 			break;
 		*row+=new String(sr.piece, String::L_TAINTED);
@@ -415,32 +490,32 @@ static void enclose( pa_stringstream& to
 	}
 }
 
-static void table_to_csv(pa_stringstream& result, Table& table, TableSeparators& separators, bool output_column_names) {
+static void table_to_csv(pa_stringstream& result, Table& table, TableControlChars& control_chars, bool output_column_names) {
 	if(output_column_names) {
 		if(table.columns()) { // named table
-			if(separators.encloser){
+			if(control_chars.encloser){
 				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
-					enclose( result, i.next(), separators.encloser );
+					enclose( result, i.next(), control_chars.encloser );
 					if(i.has_next())
-						result<<separators.column;
+						result<<control_chars.separator;
 				}
 			} else {
 				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
 					result<<i.next()->cstr();
 					if(i.has_next())
-						result<<separators.column;
+						result<<control_chars.separator;
 				}
 			}
 		} else { // nameless table [we were asked to output column names]
 			if(int lsize=table.count()?table[0]->count():0)
 				for(int column=0; column<lsize; column++) {
-					if(separators.encloser) {
-						result<<separators.encloser<<column<<separators.encloser;
+					if(control_chars.encloser) {
+						result<<control_chars.encloser<<column<<control_chars.encloser;
 					} else {
 						result<<column;
 					}
 					if(column<lsize-1){
-						result<<separators.column;
+						result<<control_chars.separator;
 					}
 				}
 			else
@@ -451,12 +526,12 @@ static void table_to_csv(pa_stringstream
 
 	// process data lines
 	Array_iterator<ArrayString*> i(table);
-	if(separators.encloser){
+	if(control_chars.encloser){
 		while(i.has_next()) {
 			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
-				enclose( result, c.next(), separators.encloser );
+				enclose( result, c.next(), control_chars.encloser );
 				if(c.has_next())
-					result<<separators.column;
+					result<<control_chars.separator;
 			}
 			result<<'\n';
 		}
@@ -465,7 +540,7 @@ static void table_to_csv(pa_stringstream
 			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
 				result<<c.next()->cstr();
 				if(c.has_next())
-					result<<separators.column;
+					result<<control_chars.separator;
 			}
 			result<<'\n';
 		}
@@ -494,32 +569,32 @@ void enclose( String& to, const String*
 	}
 }
 
-static void table_to_csv(String& result, Table& table, TableSeparators& separators, bool output_column_names) {
+static void table_to_csv(String& result, Table& table, TableControlChars& control_chars, bool output_column_names) {
 	if(output_column_names) {
 		if(table.columns()) { // named table
-			if(separators.encloser) {
+			if(control_chars.encloser) {
 				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
-					enclose( result, i.next(), separators.encloser, separators.sencloser );
+					enclose( result, i.next(), control_chars.encloser, control_chars.sencloser );
 					if(i.has_next())
-						result<<*separators.scolumn;
+						result<<*control_chars.sseparator;
 				}
 			} else {
 				for(Array_iterator<const String*> i(*table.columns()); i.has_next(); ) {
 					result<<*i.next();
 					if(i.has_next())
-						result<<*separators.scolumn;
+						result<<*control_chars.sseparator;
 				}
 			}
 		} else { // nameless table [we were asked to output column names]
 			if(int lsize=table.count()?table[0]->count():0)
 				for(int column=0; column<lsize; column++) {
-					if(separators.encloser) {
-						result<<*separators.sencloser<<String::Body::Format(column)<<*separators.sencloser;
+					if(control_chars.encloser) {
+						result<<*control_chars.sencloser<<String::Body::Format(column)<<*control_chars.sencloser;
 					} else {
 						result<<String::Body::Format(column);
 					}
 					if(column<lsize-1){
-						result<<*separators.scolumn;
+						result<<*control_chars.sseparator;
 					}
 				}
 			else
@@ -530,12 +605,12 @@ static void table_to_csv(String& result,
 
 	// data lines
 	Array_iterator<ArrayString*> i(table);
-	if(separators.encloser){
+	if(control_chars.encloser){
 		while(i.has_next()) {
 			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
-				enclose( result, c.next(), separators.encloser, separators.sencloser );
+				enclose( result, c.next(), control_chars.encloser, control_chars.sencloser );
 				if(c.has_next())
-					result<<*separators.scolumn;
+					result<<*control_chars.sseparator;
 			}
 			result.append_know_length("\n", 1, String::L_CLEAN);
 		}
@@ -544,7 +619,7 @@ static void table_to_csv(String& result,
 			for(Array_iterator<const String*> c(*i.next()); c.has_next(); ) {
 				result<<*c.next();
 				if(c.has_next())
-					result<<*separators.scolumn;
+					result<<*control_chars.sseparator;
 			}
 			result.append_know_length("\n", 1, String::L_CLEAN);
 		}
@@ -574,25 +649,23 @@ static void _save(Request& r, MethodPara
 	if(do_append && file_exist(file_spec))
 		output_column_names=false;
 
-	TableSeparators separators;
+	TableControlChars control_chars;
 	if(param_index<params.count())
 		if(HashStringValue* options=params.as_hash(param_index++)) {
-			int valid_options=separators.load(*options);
+			int valid_options=control_chars.load(*options);
 			if(valid_options!=options->count())
 				throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION);
 		}
 
 	if(param_index<params.count())
-		throw Exception(PARSER_RUNTIME,
-			0,
-			"bad mode (must be nameless or append)");
+		throw Exception(PARSER_RUNTIME, 0, "bad mode (must be nameless or append)");
 
 	Table& table=GET_SELF(r, VTable).table();
 
 #ifdef USE_STRINGSTREAM
 	pa_stringstream ost(std::stringstream::out);
 
-	table_to_csv(ost, table, separators, output_column_names);
+	table_to_csv(ost, table, control_chars, output_column_names);
 
 	// write
 		pa_string data=ost.str();
@@ -601,7 +674,7 @@ static void _save(Request& r, MethodPara
 #else
 	String sdata;
 
-	table_to_csv(sdata, table, separators, output_column_names);
+	table_to_csv(sdata, table, control_chars, output_column_names);
 
 	// write
 		const char* data_cstr=sdata.cstr();
@@ -619,16 +692,14 @@ static void _csv_string(Request& r, Meth
 			output_column_names=false;
 			param_index++;
 		} else {
-			throw Exception(PARSER_RUNTIME,
-				0,
-				"bad mode (must be nameless)");
+			throw Exception(PARSER_RUNTIME, 0, "bad mode (must be nameless)");
 		}
 	}
 
-	TableSeparators separators;
+	TableControlChars control_chars;
 	if(param_index<params.count())
 		if(HashStringValue* options=params.as_hash(param_index++)) {
-			int valid_options=separators.load(*options);
+			int valid_options=control_chars.load(*options);
 			if(valid_options!=options->count())
 				throw Exception(PARSER_RUNTIME, 0, CALLED_WITH_INVALID_OPTION);
 		}
@@ -638,13 +709,13 @@ static void _csv_string(Request& r, Meth
 #ifdef USE_STRINGSTREAM
 	pa_stringstream ost(std::stringstream::out);
 
-	table_to_csv(ost, table, separators, output_column_names);
+	table_to_csv(ost, table, control_chars, output_column_names);
 
 	r.write_no_lang(*new VString(*new String(pa_strdup(ost.str().c_str()), String::L_CLEAN)));
 #else
 	String sdata;
 
-	table_to_csv(sdata, table, separators, output_column_names);
+	table_to_csv(sdata, table, control_chars, output_column_names);
 
 	r.write_no_lang(*new VString(*new String(sdata.cstr(), String::L_CLEAN)));
 #endif
@@ -685,9 +756,7 @@ static void _offset(Request& r, MethodPa
 		    else if(whence=="set")
 				absolute=true;
 		    else
-				throw Exception(PARSER_RUNTIME,
-					&whence,
-					"is invalid whence, valid are 'cur' or 'set'");
+				throw Exception(PARSER_RUNTIME, &whence, "is invalid whence, valid are 'cur' or 'set'");
 		}
 		
 		int offset=params.as_int(params.count()-1, "offset must be expression", r);
@@ -771,8 +840,12 @@ static void table_row_to_hash(Table::ele
 	bool exist=false;
 	switch(info->value_type) {
 		case C_STRING: {
-			size_t index=info->value_fields->get(0);
-			exist=info->hash->put_dont_replace(*key, (index < row->count()) ? new VString(*row->get(index)) : new VString());
+			if(info->value_fields->count()){
+				size_t index=info->value_fields->get(0);
+				exist=info->hash->put_dont_replace(*key, (index < row->count()) ? new VString(*row->get(index)) : VString::empty());
+			} else {
+				exist=info->hash->put_dont_replace(*key, VString::empty());
+			}
 			break;
 		}
 		case C_HASH: {
@@ -898,10 +971,12 @@ static void _hash(Request& r, MethodPara
 					throw Exception(PARSER_RUNTIME, 0, "you can't specify value field(s) with option $.distinct[tables] or $.type[tables]");
 
 				Value& value_fields_param=params[1];
-				if(value_fields_param.get_junction()){
+				if(value_fields_param.get_junction()){ // code specified
 					value_code=&value_fields_param;
 				} else if(value_fields_param.is_string()) { // one column as string was specified
-					value_fields+=self_table.column_name2index(*value_fields_param.get_string(), true);
+					const String &field_name=*value_fields_param.get_string();
+					if(!field_name.is_empty())
+						value_fields+=self_table.column_name2index(field_name, true);
 				} else if(Table* value_fields_table=value_fields_param.get_table()) { // list of columns were specified in table
 					for(Array_iterator<Table::element_type> i(*value_fields_table); i.has_next(); ) {
 						const String& value_field_name =*i.next()->get(0);
@@ -1073,8 +1148,8 @@ static void _flip(Request& r, MethodPara
 static void _foreach(Request& r, MethodParams& params) {
 	InCycle temp(r);
 
-	const String& rownum_name=params.as_string(0, "rownum-var name must be string");
-	const String& value_name=params.as_string(1, "value-var name must be string");
+	const String* rownum_var_name=&params.as_string(0, "rownum-var name must be string");
+	const String* value_var_name=&params.as_string(1, "value-var name must be string");
 
 	Value& body_code=params.as_junction(2, "body must be code");
 	
@@ -1083,8 +1158,8 @@ static void _foreach(Request& r, MethodP
 	Table& table=GET_SELF(r, VTable).table();
 	size_t saved_current=table.current();
 
-	const String* rownum_var_name=rownum_name.is_empty()? 0 : &rownum_name;
-	const String* value_var_name=value_name.is_empty()? 0 : &value_name;
+	rownum_var_name=rownum_var_name->is_empty()? 0 : rownum_var_name;
+	value_var_name=value_var_name->is_empty()? 0 : value_var_name;
 
 	Value* var_context=r.get_method_frame()->caller();
 
@@ -1146,8 +1221,7 @@ inline Table::element_type row_from_stri
 
 	// parse cells
 	Table::element_type row=new ArrayString;
-	size_t pos_after=0;
-	string.split(*row, pos_after, "\t", String::L_AS_IS);
+	string.split(*row, 0, "\t", String::L_AS_IS);
 
 	return row;
 }
@@ -1205,9 +1279,7 @@ static void _join(Request& r, MethodPara
 
 	Table& dest=GET_SELF(r, VTable).table();
 	if(&src == &dest)
-		throw Exception(PARSER_RUNTIME, 
-			0, 
-			"source and destination are same table");
+		throw Exception(PARSER_RUNTIME, 0, "source and destination are same table");
 
 	if(dest.columns()) // dest is named
 		src.table_for_each(join_named_row, &dest, o);