--- parser3/src/classes/xnode.C	2001/10/16 14:43:30	1.7
+++ parser3/src/classes/xnode.C	2001/10/18 13:09:37	1.11
@@ -4,7 +4,7 @@
 	Copyright (c) 2001 ArtLebedev Group (http://www.artlebedev.com)
 	Author: Alexander Petrosyan <paf@design.ru> (http://design.ru/paf)
 
-	$Id: xnode.C,v 1.7 2001/10/16 14:43:30 parser Exp $
+	$Id: xnode.C,v 1.11 2001/10/18 13:09:37 parser Exp $
 */
 #include "classes.h"
 #ifdef XML
@@ -62,13 +62,17 @@ XalanAttr& as_attr(Pool& pool, const Str
 static void _insertBefore(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
-	XalanNode& node=vnode.get_node(pool, &method_name);
+	XalanNode& selfNode=vnode.get_node(pool, &method_name);
 
 	XalanNode& newChild=as_node(pool, method_name, params, 0, "newChild must be node");
 	XalanNode& refChild=as_node(pool, method_name, params, 1, "refChild must be node");
 	
 	try {
-		node.insertBefore(&newChild, &refChild);
+		if(XalanNode *retNode=selfNode.insertBefore(&newChild, &refChild)) {
+			// write out result
+			VXnode& result=*new(pool) VXnode(pool, retNode);
+			r.write_no_lang(result);		
+		}
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -78,13 +82,17 @@ static void _insertBefore(Request& r, co
 static void _replaceChild(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
-	XalanNode& node=vnode.get_node(pool, &method_name);
+	XalanNode& selfNode=vnode.get_node(pool, &method_name);
 
 	XalanNode& newChild=as_node(pool, method_name, params, 0, "newChild must be node");
 	XalanNode& refChild=as_node(pool, method_name, params, 1, "refChild must be node");
 	
 	try {
-		node.replaceChild(&newChild, &refChild);
+		if(XalanNode *retNode=selfNode.replaceChild(&newChild, &refChild)) {
+			// write out result
+			VXnode& result=*new(pool) VXnode(pool, retNode);
+			r.write_no_lang(result);		
+		}
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -94,12 +102,16 @@ static void _replaceChild(Request& r, co
 static void _removeChild(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
-	XalanNode& node=vnode.get_node(pool, &method_name);
+	XalanNode& selfNode=vnode.get_node(pool, &method_name);
 
 	XalanNode& oldChild=as_node(pool, method_name, params, 0, "oldChild must be node");
 	
 	try {
-		node.removeChild(&oldChild);
+		if(XalanNode *retNode=selfNode.removeChild(&oldChild)) {
+			// write out result
+			VXnode& result=*new(pool) VXnode(pool, retNode);
+			r.write_no_lang(result);		
+		}
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -109,12 +121,16 @@ static void _removeChild(Request& r, con
 static void _appendChild(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
-	XalanNode& node=vnode.get_node(pool, &method_name);
+	XalanNode& selfNode=vnode.get_node(pool, &method_name);
 
 	XalanNode& newChild=as_node(pool, method_name, params, 0, "newChild must be node");
 	
 	try {
-		node.appendChild(&newChild);
+		if(XalanNode *retNode=selfNode.appendChild(&newChild)) {
+			// write out result
+			VXnode& result=*new(pool) VXnode(pool, retNode);
+			r.write_no_lang(result);		
+		}
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -166,9 +182,9 @@ XalanElement& get_self_element(Request&
 static void _getAttribute(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	XalanElement& element=get_self_element(r, method_name);
-	const char *name=params->as_string(0, "name must not be code").cstr(String::UL_AS_IS);
+	const String& name=params->as_string(0, "name must be string");
 
-	const XalanDOMString& attribute_value=element.getAttribute(XalanDOMString(name));
+	const XalanDOMString& attribute_value=element.getAttribute(pool.transcode(name));
 	// write out result
 	r.write_no_lang(*new(pool) VString(pool.transcode(attribute_value)));
 }
@@ -177,13 +193,13 @@ static void _getAttribute(Request& r, co
 static void _setAttribute(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	XalanElement& element=get_self_element(r, method_name);
-	const char *name=params->as_string(0, "name must not be code").cstr(String::UL_AS_IS);
-	const char *attribute_value=params->as_string(1, "value must not be code").cstr(String::UL_AS_IS);
+	const String& name=params->as_string(0, "name must be string");
+	const String& attribute_value=params->as_string(1, "value must be string");
 
 	try {
 		element.setAttribute(
-			XalanDOMString(name), 
-			XalanDOMString(attribute_value));
+			pool.transcode(name), 
+			pool.transcode(attribute_value));
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -193,10 +209,10 @@ static void _setAttribute(Request& r, co
 static void _removeAttribute(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	XalanElement& element=get_self_element(r, method_name);
-	const char *name=params->as_string(0, "name must not be code").cstr(String::UL_AS_IS);
+	const String& name=params->as_string(0, "name must be string");
 
 	try {
-		element.removeAttribute(XalanDOMString(name));
+		element.removeAttribute(pool.transcode(name));
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -206,9 +222,9 @@ static void _removeAttribute(Request& r,
 static void _getAttributeNode(Request& r, const String& method_name, MethodParams *params) {
 	Pool& pool=r.pool();
 	XalanElement& element=get_self_element(r, method_name);
-	const char *name=params->as_string(0, "name must not be code").cstr(String::UL_AS_IS);
+	const String& name=params->as_string(0, "name must be string");
 
-	if(XalanAttr *attr=element.getAttributeNode(XalanDOMString(name))) {
+	if(XalanAttr *attr=element.getAttributeNode(pool.transcode(name))) {
 		// write out result
 		VXnode& result=*new(pool) VXnode(pool, attr);
 		r.write_no_lang(result);
@@ -239,7 +255,7 @@ static void _removeAttributeNode(Request
 	XalanAttr& oldAttr=as_attr(pool, method_name, params, 0, "oldAttr must be ATTRIBUTE node");
 
 	try {
-		/*XalanAttr *returnAttr*/element.removeAttributeNode(&oldAttr));
+		/*XalanAttr *returnAttr*/element.removeAttributeNode(&oldAttr);
 	} catch(const XalanDOMException& e)	{
 		pool.exception()._throw(pool, &method_name, e);
 	}
@@ -250,11 +266,11 @@ static void _getElementsByTagName(Reques
 	Pool& pool=r.pool();
 	XalanElement& element=get_self_element(r, method_name);
 
-	const char *name=params->as_string(0, "name must not be code").cstr(String::UL_AS_IS);
+	const String& name=params->as_string(0, "name must be string");
 
 	VHash& result=*new(pool) VHash(pool);
 	if(const XalanNodeList *nodes=
-		element.getElementsByTagName(XalanDOMString(name))) {
+		element.getElementsByTagName(pool.transcode(name))) {
 		for(int i=0; i<nodes->getLength(); i++) {
 			String& skey=*new(pool) String(pool);
 			{
@@ -285,7 +301,7 @@ static void _select(Request& r, const St
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
 
 	// expression
-	const String& expression=params->as_string(0, "expression must not be code");
+	const String& expression=params->as_string(0, "expression must be string");
 	const char *expression_cstr=expression.cstr(String::UL_AS_IS);
 	XalanDOMString dstring(expression_cstr);
 	const XalanDOMChar *expression_dcstr=dstring.c_str();
@@ -317,13 +333,13 @@ static void _select(Request& r, const St
 	}
 }
 
-static void _select_single(Request& r, const String& method_name, MethodParams *params) {
+static void _selectSingle(Request& r, const String& method_name, MethodParams *params) {
 //	_asm int 3;
 	Pool& pool=r.pool();
 	VXnode& vnode=*static_cast<VXnode *>(r.self);
 
 	// expression
-	const String& expression=params->as_string(0, "expression must not be code");
+	const String& expression=params->as_string(0, "expression must be string");
 	const char *expression_cstr=expression.cstr(String::UL_AS_IS);
 	XalanDOMString dstring(expression_cstr);
 	const XalanDOMChar *expression_dcstr=dstring.c_str();
@@ -394,7 +410,7 @@ MXnode::MXnode(Pool& apool) : Methoded(a
 	add_native_method("select", Method::CT_DYNAMIC, _select, 1, 1);
 
 	// ^node.selectSingle[/some/xpath/query] = first dnode
-	add_native_method("selectSingle", Method::CT_DYNAMIC, _select_single, 1, 1);
+	add_native_method("selectSingle", Method::CT_DYNAMIC, _selectSingle, 1, 1);
 
 	// consts