--- parser3/src/main/pa_sql_driver_manager.C	2001/06/28 07:44:17	1.22
+++ parser3/src/main/pa_sql_driver_manager.C	2001/09/14 15:49:06	1.35
@@ -5,7 +5,7 @@
 
 	Author: Alexander Petrosyan <paf@design.ru> (http://design.ru/paf)
 */
-static const char *RCSId="$Id: pa_sql_driver_manager.C,v 1.22 2001/06/28 07:44:17 parser Exp $"; 
+static const char *RCSId="$Id: pa_sql_driver_manager.C,v 1.35 2001/09/14 15:49:06 parser Exp $"; 
 
 #include "pa_sql_driver_manager.h"
 #include "ltdl.h"
@@ -14,17 +14,14 @@ static const char *RCSId="$Id: pa_sql_dr
 #include "pa_common.h"
 #include "pa_threads.h"
 
-#include "pa_sapi.h"
-
 // globals
 
 SQL_Driver_manager *SQL_driver_manager;
 
 // consts
 
-const char *LIBRARY_CREATE_FUNC_NAME="create";
 const int EXPIRE_UNUSED_CONNECTION_SECONDS=60;
-const int CHECK_EXPIRED_CONNECTIONS_SECONDS=60*2;
+const int CHECK_EXPIRED_CONNECTIONS_SECONDS=EXPIRE_UNUSED_CONNECTION_SECONDS*2;
 
 
 /// SQL_Driver_services Pooled implementation
@@ -60,7 +57,7 @@ SQL_Connection& SQL_Driver_manager::get_
 	if(!protocol2driver_and_client)
 		PTHROW(0, 0,
 			&request_url,
-			"$SQL:drivers table must be defined");
+			"$"MAIN_SQL_NAME":"MAIN_SQL_DRIVERS_NAME" table must be defined");
 
 	// first trying to get cached connection
 	SQL_Connection *result=get_connection_from_cache(request_url);
@@ -109,18 +106,19 @@ SQL_Connection& SQL_Driver_manager::get_
 						protocol2driver_and_client->origin_string(),
 						"driver library column for protocol '%s' is empty", 
 							request_protocol_cstr);
-				if(!(dlopen_file_spec=protocol2driver_and_client->item(2)) || dlopen_file_spec->size()==0)
-					PTHROW(0, 0,
-						protocol2driver_and_client->origin_string(),
-						"client library column for protocol '%s' is empty", 
-							request_protocol_cstr);
+				dlopen_file_spec=protocol2driver_and_client->item(2);
 			} else
 				PTHROW(0, 0,
 					&request_url,
 					"undefined protocol '%s'", 
 						request_protocol_cstr);
 
-			const char *filename=library->cstr(String::UL_FILE_NAME);
+			if(lt_dlinit())
+				PTHROW(0, 0,
+					library,
+					"prepare to dynamic loading failed, %s", lt_dlerror());
+
+			const char *filename=library->cstr(String::UL_FILE_SPEC);
 			lt_dlhandle handle=lt_dlopen(filename);
 			if (!handle)
 				PTHROW(0, 0,
@@ -128,11 +126,11 @@ SQL_Connection& SQL_Driver_manager::get_
 					"can not open the module, %s", lt_dlerror());
 
 			SQL_Driver_create_func create=(SQL_Driver_create_func)lt_dlsym(handle, 
-				LIBRARY_CREATE_FUNC_NAME);  
+				SQL_DRIVER_CREATE_NAME);
 			if(!create)
 				PTHROW(0, 0,
 					library,
-					"function '%s' was not found", LIBRARY_CREATE_FUNC_NAME);
+					"function '"SQL_DRIVER_CREATE_NAME"' was not found");
 
 			// create library-driver!
 			driver=(*create)();
@@ -146,13 +144,17 @@ SQL_Connection& SQL_Driver_manager::get_
 						driver_api_version, SQL_DRIVER_API_VERSION);
 
 			// initialise by connecting to sql client dynamic link library
-			const char *dlopen_file_spec_cstr=dlopen_file_spec->cstr(String::UL_FILE_NAME);
+			bool specified_dlopen_file_spec=dlopen_file_spec && dlopen_file_spec->size();
+			const char *dlopen_file_spec_cstr=
+				specified_dlopen_file_spec?
+				dlopen_file_spec->cstr(String::UL_FILE_SPEC):0;
 			if(const char *error=driver->initialize(
 				dlopen_file_spec_cstr))
 				PTHROW(0, 0,
 					library,
 					"driver failed to initialize client library '%s', %s",
-						dlopen_file_spec_cstr, error);
+						specified_dlopen_file_spec?dlopen_file_spec_cstr:"unspecifed", 
+						error);
 
 			// cache it
 			put_driver_to_cache(global_protocol, *driver);
@@ -197,7 +199,7 @@ void SQL_Driver_manager::put_driver_to_c
 }
 
 // connection cache
-
+/// @todo get rid of memory spending Stack [zeros deep inside got accumulated]
 SQL_Connection *SQL_Driver_manager::get_connection_from_cache(const String& url) { 
 	SYNCHRONIZED;
 
@@ -229,7 +231,7 @@ static void expire_connection(Array::Ite
 	SQL_Connection& connection=*static_cast<SQL_Connection *>(value);
 	time_t older_dies=reinterpret_cast<time_t>(info);
 
-	if(connection.expired(older_dies))
+	if(connection.connected() && connection.expired(older_dies))
 		connection.disconnect();
 }
 static void expire_connections(const Hash::Key& key, Hash::Val *value, void *info) {