--- sql/mysql/parser3mysql.C 2002/02/08 08:32:46 1.7 +++ sql/mysql/parser3mysql.C 2003/01/31 09:33:15 1.12 @@ -1,7 +1,7 @@ /** @file Parser MySQL driver. - Copyright(c) 2001, 2002 ArtLebedev Group (http://www.artlebedev.com) + Copyright(c) 2001, 2003 ArtLebedev Group (http://www.artlebedev.com) Author: Alexandr Petrosian (http://paf.design.ru) @@ -10,7 +10,7 @@ 2001.11.06 numrows on "HP-UX istok1 B.11.00 A 9000/869 448594332 two-user license" 3.23.42 & 4.0.0.alfa never worked, both subst & .sl version returned 0 */ -static const char *RCSId="$Id: parser3mysql.C,v 1.7 2002/02/08 08:32:46 paf Exp $"; +static const char *RCSId="$Id: parser3mysql.C,v 1.12 2003/01/31 09:33:15 paf Exp $"; #include "config_includes.h" @@ -204,19 +204,33 @@ public: mysql_free_result(res); services._throw("result contains no columns"); } + + bool failed=false; + SQL_Error sql_error; +#define CHECK(afailed) \ + if(afailed) { \ + failed=true; \ + goto cleanup; \ + } for(int i=0; iname); - void *ptr=services.malloc(size); - memcpy(ptr, field->name, size); - handlers.add_column(ptr, size); + if(MYSQL_FIELD *field=mysql_fetch_field(res)) { + size_t size=strlen(field->name); + void *ptr=services.malloc(size); + memcpy(ptr, field->name, size); + CHECK(handlers.add_column(sql_error, ptr, size)); + } else { + // seen some broken client, + // which reported "44" for column count of response to "select 2+2" + column_count=i; + break; + } } - handlers.before_rows(); + CHECK(handlers.before_rows(sql_error)); while(MYSQL_ROW mysql_row=mysql_fetch_row(res)) { - handlers.add_row(); + CHECK(handlers.add_row(sql_error)); unsigned long *lengths=mysql_fetch_lengths(res); for(int i=0; i