--- sql/mysql/parser3mysql.C 2019/09/10 14:25:59 1.58 +++ sql/mysql/parser3mysql.C 2020/01/18 20:59:24 1.63 @@ -1,7 +1,7 @@ /** @file Parser MySQL driver. - Copyright (c) 2001-2015 Art. Lebedev Studio (http://www.artlebedev.com) + Copyright (c) 2001-2019 Art. Lebedev Studio (http://www.artlebedev.com) Author: Alexandr Petrosian (http://paf.design.ru) @@ -15,7 +15,7 @@ #include "pa_sql_driver.h" -volatile const char * IDENT_PARSER3MYSQL_C="$Id: parser3mysql.C,v 1.58 2019/09/10 14:25:59 moko Exp $" IDENT_PA_SQL_DRIVER_H; +volatile const char * IDENT_PARSER3MYSQL_C="$Id: parser3mysql.C,v 1.63 2020/01/18 20:59:24 moko Exp $" IDENT_PA_SQL_DRIVER_H; #define NO_CLIENT_LONG_LONG #include "mysql.h" @@ -24,7 +24,7 @@ volatile const char * IDENT_PARSER3MYSQL #define MAX_STRING 0x400 #define MAX_NUMBER 20 -#if _MSC_VER +#ifdef _MSC_VER # define snprintf _snprintf # define strcasecmp _stricmp #endif @@ -334,7 +334,7 @@ public: MYSQL_RES *res=NULL; if(placeholders_count>0) - services._throw("bind variables not supported (yet)"); + services._throw("bind variables not supported yet"); bool transcode_needed=_transcode_required(connection); @@ -380,48 +380,49 @@ public: services._throw("result contains no columns"); } - bool failed=false; SQL_Error sql_error; -#define CHECK(afailed) \ - if(afailed) { \ - failed=true; \ - goto cleanup; \ - } +#define CHECK(afailed) \ + if(afailed) { \ + mysql_free_result(res); \ + services._throw(sql_error); \ + } -#define DO_FETCH_FIELDS(transcode_column_name) { \ - for(size_t i=0; iname_length; \ - const char* str=strdup(services, field->name, length); \ - transcode_column_name \ - CHECK(handlers.add_column(sql_error, str, length)); \ - } else { \ - /* seen broken client, that reported "44" column count for "select 2+2" */ \ - column_count=i; \ - break; \ - } \ - } \ - } +#define DO_FETCH_FIELDS(transcode_column_name) \ + for(size_t i=0; iname_length; \ + const char* str=strdup(services, field->name, length); \ + transcode_column_name \ + CHECK(handlers.add_column(sql_error, str, length)); \ + } else { \ + /* seen broken client, that reported "44" column count for "select 2+2" */ \ + column_count=i; \ + break; \ + } \ + } -#define DO_FETCH_ROWS(transcode_cell_value) { \ - while(MYSQL_ROW mysql_row=mysql_fetch_row(res)) { \ - CHECK(handlers.add_row(sql_error)); \ - unsigned long *lengths=mysql_fetch_lengths(res); \ - for(size_t i=0; itype); // transcode column's name from ?ClientCharset to $request:charset @@ -433,16 +434,17 @@ public: if(transcode_column[i]) services.transcode(str, length, str, length, connection.client_charset, services.request_charset()); ) +#ifdef _MSC_VER + services.realloc(transcode_column,0); +#endif } else { // without transcoding - DO_FETCH_FIELDS() + DO_FETCH_FIELDS({}) CHECK(handlers.before_rows(sql_error)); - DO_FETCH_ROWS() + DO_FETCH_ROWS({}) } -cleanup: + mysql_free_result(res); - if(failed) - services._throw(sql_error); } else { if(mysql_field_count(connection.handle))