--- sql/oracle/parser3oracle.C	2001/10/28 14:51:30	1.2
+++ sql/oracle/parser3oracle.C	2003/09/29 06:15:27	1.35
@@ -1,13 +1,13 @@
 /** @file
 	Parser Oracle driver.
 
-	Copyright(c) 2001 ArtLebedev Group(http://www.artlebedev.com)
+	Copyright(c) 2001, 2003 ArtLebedev Group (http://www.artlebedev.com)
 
-	Author: Alexander Petrosyan <paf@design.ru>(http://design.ru/paf)
+	Author: Alexandr Petrosian <paf@design.ru> (http://paf.design.ru)
 
 	2001.07.30 using Oracle 8.1.6 [@test tested with Oracle 7.x.x]
 */
-static const char *RCSId="$Id: parser3oracle.C,v 1.2 2001/10/28 14:51:30 paf Exp $"; 
+static const char *RCSId="$Id: parser3oracle.C,v 1.35 2003/09/29 06:15:27 paf Exp $"; 
 
 #include "config_includes.h"
 
@@ -38,6 +38,54 @@ inline int max(int a, int b) { return a>
 inline int min(int a, int b){ return a<b?a:b; }
 #endif
 
+/// @todo small memory leaks here
+static int pa_setenv(const char *name, const char *value, bool do_append) {
+	const char *prev_value=0;
+	if(do_append)
+		prev_value=getenv(name);
+#ifdef HAVE_PUTENV
+    // MEM_LEAK_HERE. refer to EOF man putenv
+	char *buf=(char *)::malloc(strlen(name)
+		+1
+		+(prev_value?strlen(prev_value):0)
+		+strlen(value)
+		+1);
+	strcpy(buf, name);
+	strcat(buf, "=");
+	if(prev_value)
+		strcat(buf, prev_value);
+	strcat(buf, value);
+/*
+	if(FILE *f=fopen("f", "at")) {
+		fprintf(f, "****************************%s\n", buf);
+//		for (char **env = environ; env != NULL && *env != NULL; env++)
+//			fputs(*env, f);
+	
+		fclose(f);
+	}
+*/	
+	return putenv(buf);
+#else 
+	//#ifdef HAVE_SETENV
+	if(value) {
+		if(prev_value) {
+			// MEM_LEAK_HERE
+			char *buf=(char *)::malloc(strlen(prev_value)
+				+strlen(value)
+				+1);
+			strcpy(buf, prev_value);
+			strcat(buf, value);
+			value=buf;
+		}
+
+		return setenv(name, value, 1/*overwrite*/); 
+	} else {
+		unsetenv(name);
+		return 0;
+	}
+#endif
+}
+
 static char *lsplit(char *string, char delim) {
     if(string) {
 		char *v=strchr(string, delim);
@@ -49,9 +97,42 @@ static char *lsplit(char *string, char d
     return 0;
 }
 
+static char *lsplit(char **string_ref, char delim) {
+    char *result=*string_ref;
+	char *next=lsplit(*string_ref, delim);
+    *string_ref=next;
+    return result;
+}
+
+static const char *options2env(char *options) {
+	while(options) {
+		if(char *key=lsplit(&options, '&')) {
+			if(*key) {
+				if(char *value=lsplit(key, '=')) {
+					bool do_append=key[strlen(key)-1]=='+'; // PATH+=
+					if(do_append)
+						key[strlen(key)-1]=0; // remove trailing +
+					if(strncmp(key, "ORACLE_", 7)==0  // ORACLE_HOME & co
+						|| strncmp(key, "ORA_", 4)==0 // ORA_ENCRYPT_LOGIN & co
+						|| strncmp(key, "NLS_", 4)==0 // NLS_LANG & co
+						|| do_append
+						) {
+						if(pa_setenv(key, value, do_append)!=0)
+							return "problem changing process environment" /*key*/;
+					} else
+						return "unknown option (option must start with ORACLE_, ORA_ or NLS_)" /*key*/;
+				} else 
+					return "option without =value" /*key*/;
+			}
+		}
+	}
+	return 0;
+}
+
 #ifndef DOXYGEN
 struct OracleSQL_connection_struct {
 	jmp_buf mark; char error[MAX_STRING];
+	SQL_Error sql_error;
 	OCIEnv *envhp;
 	OCIServer *srvhp;
 	OCIError *errhp;
@@ -85,9 +166,8 @@ struct OracleSQL_query_lobs {
 #endif
 
 // forwards
-void check(
-		   SQL_Driver_services& services, OracleSQL_connection_struct &cs, 
-		   const char *step, sword status);
+void check(OracleSQL_connection_struct &cs, const char *step, sword status);
+void check(OracleSQL_connection_struct &cs, bool error);
 static sb4 cbf_no_data(
 					   dvoid *ctxp, 
 					   OCIBind *bindp, 
@@ -108,7 +188,6 @@ void tolower(char *out, const char *in,
 
 /**
 	OracleSQL server driver
-	@test NLS_LANG=AMERICAN_AMERICA.CL8MSWIN1251
 */
 class OracleSQL_Driver : public SQL_Driver {
 public:
@@ -118,20 +197,23 @@ public:
 
 	/// get api version
 	int api_version() { return SQL_DRIVER_API_VERSION; }
-	/// initialize driver by loading sql dynamic link library
-	const char *initialize(const char *dlopen_file_spec) {
+	/** initialize driver by loading sql dynamic link library
+		@todo ?objects=1 which would turn on OCI_OBJECT init flag
+	*/
+	const char *initialize(char *dlopen_file_spec) {
+		char *options=lsplit(dlopen_file_spec, '?');
 
 		const char *error=dlopen_file_spec?
 			dlink(dlopen_file_spec):"client library column is empty";
 		if(!error) {
+			error=options2env(options);
 
-//			error="OCIInitialize replacer";/*
-			OCIInitialize((ub4)OCI_THREADED, (dvoid *)0, 
-				(dvoid * (*)(void *, unsigned int))0, 
-				(dvoid * (*)(void*, void*, unsigned int))0,  
-				(void (*)(void*, void*))0 );
-
-//			*/
+			if(!error)
+				OCIInitialize((ub4)OCI_THREADED/*| OCI_OBJECT*/, (dvoid *)0, 
+					(dvoid * (*)(void *, unsigned int))0, 
+					(dvoid * (*)(void*, void*, unsigned int))0,  
+					(void (*)(void*, void*))0 
+				);
 		}
 
 		return error;
@@ -139,7 +221,13 @@ public:
 
 	/**	connect
 		@param used_only_in_connect_url
-			format: @b user:pass@service
+			format: @b user:pass@service?
+			   ORACLE_HOME=/u01/app/oracle/product/8.1.5&
+			   ORA_NLS33=/u01/app/oracle/product/8.1.5/ocommon/nls/admin/data&
+			   NLS_LANG=RUSSIAN_AMERICA.CL8MSWIN1251&
+			   ORA_ENCRYPT_LOGIN=TRUE
+
+		@todo environment manupulation doesnt look thread safe
 	*/
 	void connect(
 		char *used_only_in_connect_url, 
@@ -153,10 +241,14 @@ public:
 		char *user=used_only_in_connect_url;
 		char *service=lsplit(user, '@');
 		char *pwd=lsplit(user, ':');
+		char *options=lsplit(service, '?');
 
 		if(!(user && pwd && service))
 			services._throw("mailformed connect part, must be 'user:pass@service'");
 
+		if(const char *error=options2env(options))
+			services._throw(error);
+
 		if(setjmp(cs.mark))
 			services._throw(cs.error);
 
@@ -178,44 +270,44 @@ public:
 		*/
 		OCIHandleAlloc((dvoid *)NULL, (dvoid **) &cs.envhp, (ub4)OCI_HTYPE_ENV, 0, 0);
 		// Initialize an environment handle, attempt #2
-		check(services, cs, "EnvInit", OCIEnvInit(
+		check(cs, "EnvInit", OCIEnvInit(
 			&cs.envhp, (ub4)OCI_DEFAULT, 0, 0));		
 		// Allocate and initialize OCIError handle
-		check(services, cs, "HandleAlloc errhp", OCIHandleAlloc( 
+		check(cs, "HandleAlloc errhp", OCIHandleAlloc( 
 			(dvoid *)cs.envhp, (dvoid **) &cs.errhp, (ub4)OCI_HTYPE_ERROR, 0, 0));
 		// Allocate and initialize OCIServer handle
-		check(services, cs, "HandleAlloc srvhp", OCIHandleAlloc( 
+		check(cs, "HandleAlloc srvhp", OCIHandleAlloc( 
 			(dvoid *)cs.envhp, (dvoid **) &cs.srvhp, (ub4)OCI_HTYPE_SERVER, 0, 0));		
 		// Attach to a 'service'; initialize server context handle  
-		check(services, cs, "ServerAttach", OCIServerAttach( 
+		check(cs, "ServerAttach", OCIServerAttach( 
 			cs.srvhp, cs.errhp, (text *)service, (sb4)strlen(service), (ub4)OCI_DEFAULT));
 		// Allocate and initialize OCISvcCtx handle
-		check(services, cs, "HandleAlloc svchp", OCIHandleAlloc( 
+		check(cs, "HandleAlloc svchp", OCIHandleAlloc( 
 			(dvoid *)cs.envhp, (dvoid **) &cs.svchp, (ub4)OCI_HTYPE_SVCCTX, 0, 0));		
 		// set attribute server context in the service context
-		check(services, cs, "AttrSet server-service", OCIAttrSet( 
+		check(cs, "AttrSet server-service", OCIAttrSet( 
 			(dvoid *)cs.svchp, (ub4)OCI_HTYPE_SVCCTX, 
 			(dvoid *)cs.srvhp, (ub4)0, 
 			(ub4)OCI_ATTR_SERVER, (OCIError *)cs.errhp));		
 		// allocate a user context handle
-		check(services, cs, "HandleAlloc usrhp", OCIHandleAlloc(
+		check(cs, "HandleAlloc usrhp", OCIHandleAlloc(
 			(dvoid *)cs.envhp, (dvoid **)&cs.usrhp, (ub4)OCI_HTYPE_SESSION, 0, 0));
 		// set 'user' name
-		check(services, cs, "AttrSet user-session", OCIAttrSet(
+		check(cs, "AttrSet user-session", OCIAttrSet(
 			(dvoid *)cs.usrhp, (ub4)OCI_HTYPE_SESSION, 
 			(dvoid *)user, (ub4)strlen(user), 
 			OCI_ATTR_USERNAME, cs.errhp));		
 		// set 'pwd' password
-		check(services, cs, "AttrSet pwd-session", OCIAttrSet(
+		check(cs, "AttrSet pwd-session", OCIAttrSet(
 			(dvoid *)cs.usrhp, (ub4)OCI_HTYPE_SESSION, 
 			(dvoid *)pwd, (ub4)strlen(pwd), 
 			OCI_ATTR_PASSWORD, cs.errhp));
 		// Authenticate a user  
-		check(services, cs, "SessionBegin", OCISessionBegin(
+		check(cs, "SessionBegin", OCISessionBegin(
 			cs.svchp, cs.errhp, cs.usrhp, 
 			OCI_CRED_RDBMS, OCI_DEFAULT));
 		// remember connection in session
-		check(services, cs, "AttrSet service-session", OCIAttrSet(
+		check(cs, "AttrSet service-session", OCIAttrSet(
 			(dvoid *)cs.svchp, (ub4)OCI_HTYPE_SVCCTX, 
 			(dvoid *)cs.usrhp, (ub4)0, 
 			OCI_ATTR_SESSION, cs.errhp));
@@ -223,12 +315,7 @@ public:
 		// return created connection
 		*(OracleSQL_connection_struct **)connection=&cs;
 	}
-	/// @test remove return
 	void disconnect(void *connection) {
-
-		return;
-
-
 	    OracleSQL_connection_struct &cs=*(OracleSQL_connection_struct *)connection;
 		// Terminate a user session
 		OCISessionEnd(
@@ -257,39 +344,36 @@ public:
 		if(setjmp(cs.mark))
 			services._throw(cs.error);
 
-		check(services, cs, "commit", OCITransCommit(cs.svchp, cs.errhp, 0));
+		check(cs, "commit", OCITransCommit(cs.svchp, cs.errhp, 0));
 	}
 	void rollback(SQL_Driver_services& services, void *connection) {
 	    OracleSQL_connection_struct &cs=*(OracleSQL_connection_struct *)connection;
 		if(setjmp(cs.mark))
 			services._throw(cs.error);
 
-		check(services, cs, "rollback", OCITransRollback(cs.svchp, cs.errhp, 0));
+		check(cs, "rollback", OCITransRollback(cs.svchp, cs.errhp, 0));
 	}
 
 	bool ping(SQL_Driver_services&, void *connection) {
 		// maybe OCIServerVersion?
+		// select 0 from dual
 		return true;
 	}
 
-	unsigned int quote(
-		SQL_Driver_services&, void *, 
-		char *to, const char *from, unsigned int length) {
-		/*
-			it's already UNTAINT_TIMES_BIGGER
-		*/
-		unsigned int result=length;
+	const char* quote(
+		SQL_Driver_services& services, void *connection,
+		const char *from, unsigned int length) {
+		char *result=(char*)services.malloc_atomic(length*2+1);
+		char *to=result;
 		while(length--) {
 			switch(*from) {
 			case '\'': // "'" -> "''"
 				*to++='\'';
 				break;
-			case '\\': // "\" -> "\\"
-				*to++='\'';
-				break;
 			}
 			*to++=*from++;
 		}
+		*to=0;
 		return result;
 	}
 	void query(
@@ -309,18 +393,18 @@ public:
 			const char *statement=preprocess_statement(services, cs, 
 				astatement, lobs);
 
-			check(services, cs, "HandleAlloc STMT", OCIHandleAlloc( 
+			check(cs, "HandleAlloc STMT", OCIHandleAlloc( 
 				(dvoid *)cs.envhp, (dvoid **) &stmthp, (ub4)OCI_HTYPE_STMT, 0, 0));
-			check(services, cs, "syntax", 
+			check(cs, "syntax", 
 				OCIStmtPrepare(stmthp, cs.errhp, (unsigned char *)statement, 
 				(ub4)strlen((char *)statement), 
 				(ub4)OCI_NTV_SYNTAX, (ub4)OCI_DEFAULT));
 			{
 				for(int i=0; i<lobs.count; i++) {
-					check(services, cs, "alloc output var desc", OCIDescriptorAlloc(
+					check(cs, "alloc output var desc", OCIDescriptorAlloc(
 						(dvoid *)cs.envhp, (dvoid **)&lobs.items[i].locator, (ub4)OCI_DTYPE_LOB, 0, 0));
 
-					check(services, cs, "bind output", OCIBindByPos(stmthp, 
+					check(cs, "bind output", OCIBindByPos(stmthp, 
 						&lobs.items[i].bind, cs.errhp, 
 						(ub4)1+i, 
 						(dvoid *)&lobs.items[i].locator, 
@@ -330,7 +414,7 @@ public:
 					lobs.items[i].rows.count=0;
 					OracleSQL_query_lobs::cbf_context_struct cbf_context={
 						&services, &cs, &lobs.items[i].rows};
-					check(services, cs, "bind dynamic", OCIBindDynamic(
+					check(cs, "bind dynamic", OCIBindDynamic(
 						lobs.items[i].bind, cs.errhp, 
 						(dvoid *) &cbf_context, cbf_no_data, 
 						(dvoid *) &cbf_context, cbf_get_data));
@@ -357,8 +441,11 @@ cleanup: // no check call after this poi
 		if(stmthp)
 			OCIHandleFree((dvoid *)stmthp, (ub4)OCI_HTYPE_STMT);
 
-		if(failed)
+		if(failed) {
+			if(cs.sql_error.defined())
+				services._throw(cs.sql_error);
 			services._throw(cs.error);
+		}
 	}
 
 private: // private funcs
@@ -367,7 +454,7 @@ private: // private funcs
 		const char *astatement, OracleSQL_query_lobs &lobs) {
 		size_t statement_size=strlen(astatement);
 
-		char *result=(char *)services.malloc(statement_size
+		char *result=(char *)services.malloc_atomic(statement_size
 			+MAX_STRING // in case of short 'strings'
 			+11/* returning */+6/* into */+(MAX_LOB_NAME_LENGTH+2/*:, */)*2/*ret into*/*MAX_IN_LOBS
 			+1);
@@ -380,6 +467,7 @@ private: // private funcs
 				o[0]=='/' &&
 				o[1]=='*' && 
 				o[2]=='*') { // name start
+				const char* saved_o=o;
 				o+=3;
 				const char *name_begin=o;
 				while(*o)
@@ -388,16 +476,17 @@ private: // private funcs
 						o[1]=='*' &&
 						o[2]=='/' &&
 						o[3]=='\'') { // name end
+						saved_o=0; // found, marking that
 						const char *name_end=o;
 						o+=4;
 						OracleSQL_query_lobs::Item &item=lobs.items[lobs.count++];
 						item.name_ptr=name_begin; item.name_size=name_end-name_begin;
-						item.data_ptr=(char *)services.malloc(statement_size/*max*/); item.data_size=0;
+						item.data_ptr=(char *)services.malloc_atomic(statement_size/*max*/); item.data_size=0;
 
 						const char *start=o;
 						bool escaped=false;
 						while(*o && !(o[0]=='\'' && o[1]!='\'' && !escaped)) {
-							escaped=*o=='\\' || (o[0]=='\'' && o[1]=='\'');
+							escaped=o[0]=='\'' && o[1]=='\'';
 							if(escaped) {
 								// write pending, skip "\" or "'"
 								if(size_t size=o-start) {
@@ -419,6 +508,10 @@ private: // private funcs
 						break;
 					} else
 						o++; // /**skip**/'xxx'
+				if(saved_o) {
+					o=saved_o;
+					*n++=*o++;
+				}
 			} else
 				*n++=*o++;
 		}
@@ -458,10 +551,13 @@ private: // private funcs
 	/*
 		//gpfs on sun. paf 000818
 		//Zanyway, this is needed before. 
-		check(services, cs, "get stmt type", OCIAttrGet(
+		check(cs, "get stmt type", OCIAttrGet(
 			(dvoid *)stmthp, (ub4)OCI_HTYPE_STMT, (ub1 *)&stmt_type, 
 			(ub4 *)0, OCI_ATTR_STMT_TYPE, cs.errhp));
 	*/
+
+		while(isspace(*statement)) 
+			statement++;
 		if(strncasecmp(statement, "select", 6)==0) 
 			stmt_type=OCI_STMT_SELECT;
 		else if(strncasecmp(statement, "insert", 6)==0)
@@ -475,7 +571,7 @@ private: // private funcs
 			(OCISnapshot *)NULL, (ub4)OCI_DEFAULT);
 
 		if(status!=OCI_NO_DATA)
-			check(services, cs, "execute", status);
+			check(cs, "execute", status);
 
 		{
 			for(int i=0; i<lobs.count; i++) 
@@ -483,7 +579,7 @@ private: // private funcs
 					OracleSQL_query_lobs::return_rows *rows=&lobs.items[i].rows;
 					for(int r=0; r<rows->count; r++) {
 						OCILobLocator *locator=rows->row[r].locator;
-						check(services, cs, "lobwrite", OCILobWrite (
+						check(cs, "lobwrite", OCILobWrite (
 							cs.svchp, cs.errhp, 
 							locator, &bytes_to_write, 1, 
 							(dvoid *)lobs.items[i].data_ptr, (ub4)bytes_to_write, OCI_ONE_PIECE, 
@@ -512,6 +608,18 @@ private: // private funcs
 		OCIStmt *stmthp, unsigned long offset, unsigned long limit, 
 		SQL_Driver_query_event_handlers& handlers) {
 
+		ub4 prefetch_rows=100;
+		check(cs, "AttrSet prefetch-rows", OCIAttrSet( 
+			(dvoid *)stmthp, (ub4)OCI_HTYPE_STMT, 
+			(dvoid *)&prefetch_rows, (ub4)0, 
+			(ub4)OCI_ATTR_PREFETCH_ROWS, (OCIError *)cs.errhp));
+
+		ub4 prefetch_mem_size=100*0x400;
+		check(cs, "AttrSet prefetch-memory", OCIAttrSet( 
+			(dvoid *)stmthp, (ub4)OCI_HTYPE_STMT, 
+			(dvoid *)&prefetch_mem_size, (ub4)0, 
+			(ub4)OCI_ATTR_PREFETCH_MEMORY, (OCIError *)cs.errhp));
+
 		OCIParam          *mypard;
 		ub2                    dtype;
 		text                  *col_name;
@@ -535,27 +643,29 @@ private: // private funcs
 			while(++column_count<=MAX_COLS) {
 				/* get next descriptor, if there is one */
 				if(OCIParamGet(stmthp, OCI_HTYPE_STMT, cs.errhp, (void **)&mypard, 
-					(ub4) column_count)!=OCI_SUCCESS)
+					(ub4) column_count)!=OCI_SUCCESS) {
+					--column_count;
 					break;
+				}
 				
 				/* Retrieve the data type attribute */
-				check(services, cs, "get type", OCIAttrGet(
+				check(cs, "get type", OCIAttrGet(
 					(dvoid*) mypard, (ub4)OCI_DTYPE_PARAM, 
 					(dvoid*) &dtype, (ub4 *)0, (ub4)OCI_ATTR_DATA_TYPE, 
 					(OCIError *)cs.errhp));
 				
 				/* Retrieve the column name attribute */
 				ub4 col_name_len;
-				check(services, cs, "get name", OCIAttrGet(
+				check(cs, "get name", OCIAttrGet(
 					(dvoid*) mypard, (ub4)OCI_DTYPE_PARAM, 
 					(dvoid**) &col_name, (ub4 *) &col_name_len, (ub4)OCI_ATTR_NAME, 
 					(OCIError *)cs.errhp));
 				
 				{
 					size_t size=(size_t)col_name_len;
-					char *ptr=(char *)services.malloc(size);
+					char *ptr=(char *)services.malloc_atomic(size);
 					tolower(ptr, (char *)col_name, size);
-					handlers.add_column(ptr, size);
+					check(cs, handlers.add_column(cs.sql_error, ptr, size));
 				}
 				
 				ub2 coerce_type=dtype;
@@ -565,7 +675,7 @@ private: // private funcs
 				switch(dtype) {
 				case SQLT_CLOB: 
 					{
-						check(services, cs, "alloc output var desc", OCIDescriptorAlloc(
+						check(cs, "alloc output var desc", OCIDescriptorAlloc(
 							(dvoid *)cs.envhp, (dvoid **)(ptr=&cols[column_count-1].var), 
 							(ub4)OCI_DTYPE_LOB, 
 							0, (dvoid **)0));
@@ -575,39 +685,35 @@ private: // private funcs
 					}
 				default:
 					coerce_type=SQLT_STR;
-					ptr=cols[column_count-1].str=(char *)services.malloc(MAX_OUT_STRING_LENGTH+1);
+					ptr=cols[column_count-1].str=(char *)services.malloc_atomic(MAX_OUT_STRING_LENGTH+1);
 					size=MAX_OUT_STRING_LENGTH;
 					break;
 				}
 				
 				cols[column_count-1].type=coerce_type;
 				
-				check(services, cs, "DefineByPos", OCIDefineByPos(
+				check(cs, "DefineByPos", OCIDefineByPos(
 					stmthp, &cols[column_count-1].def, cs.errhp, 
 					column_count, (ub1 *) ptr, size, 
 					coerce_type, (dvoid *) &cols[column_count-1].indicator, 
 					(ub2 *)0, (ub2 *)0, OCI_DEFAULT));
 			}
 			
-			handlers.before_rows();
+			check(cs, handlers.before_rows(cs.sql_error));
 			
-			for(unsigned long row=0; !limit||row<limit+offset; row++) {
+			for(unsigned long row=0; !limit||row<offset+limit; row++) {
 				sword status=OCIStmtFetch(stmthp, cs.errhp, (ub4)1,  (ub4)OCI_FETCH_NEXT, 
 					(ub4)OCI_DEFAULT);
-				if(status!=OCI_SUCCESS) {
-					if(status!=OCI_NO_DATA)
-						check(services, cs, "fetch", status);
+				if(status==OCI_NO_DATA)
 					break;
-				}
+				check(cs, "fetch", status);
+
 				if(row>=offset) {
-					handlers.add_row();
+					check(cs, handlers.add_row(cs.sql_error));
 					for(int i=0; i<column_count; i++) {
-						size_t size;
-						void *ptr;
-						if(cols[i].indicator) { // NULL?
-							size=0;
-							ptr=0;
-						} else // not NULL
+						size_t size=0;
+						char* str=0;
+						if(!cols[i].indicator) // not NULL
 							switch(cols[i].type) {
 							case SQLT_CLOB: 
 								{
@@ -618,27 +724,28 @@ private: // private funcs
 									OCILobGetLength(cs.svchp, cs.errhp, var, &loblen);
 									if(loblen) {
 										size=(size_t)loblen;
-										ptr=services.malloc(size);
-										check(services, cs, "lobread", OCILobRead(cs.svchp, cs.errhp, 
-											var, &amtp, offset, (dvoid *) ptr, 
+										str=(char*)services.malloc_atomic(size+1);
+										check(cs, "lobread", OCILobRead(cs.svchp, cs.errhp, 
+											var, &amtp, offset, (dvoid *) str, 
 											loblen, (dvoid *)0, 
 											0, 
 											(ub2)0, (ub1) SQLCS_IMPLICIT));
+										str[size]=0;
 									}
 									break;
 								}
 							default:
-								if(const char *str=cols[i].str) {
+								if(const char *value=cols[i].str) {
 									size=strlen(str);
-									ptr=services.malloc(size);
-									memcpy(ptr, str, size);
+									str=(char*)services.malloc_atomic(size+1);
+									memcpy(str, value, size+1);
 								} else {
 									size=0;
-									ptr=0;
+									str=0;
 								}
 								break;
-						}
-						handlers.add_row_cell(ptr, size);
+							}
+						check(cs, handlers.add_row_cell(cs.sql_error, str, size));
 					}
 				}
 			}
@@ -662,9 +769,7 @@ cleanup: // no check call after this poi
 
 private: // conn client library funcs
 	
-	friend void check(
-		SQL_Driver_services& services, OracleSQL_connection_struct &cs, 
-		const char *step, sword status);
+	friend void check(OracleSQL_connection_struct &cs, const char *step, sword status);
 	friend sb4 cbf_get_data(dvoid *ctxp, 
 		OCIBind *bindp, 
 		ub4 iter, ub4 index, 
@@ -774,15 +879,8 @@ private: // conn client library funcs li
 
 	const char *dlink(const char *dlopen_file_spec) {
 		if(lt_dlinit())
-
 			return lt_dlerror();
-
-
-
         lt_dlhandle handle=lt_dlopen(dlopen_file_spec);
-
-		//return "hren31";
-
         if(!handle)
 			return lt_dlerror(); //"can not open the dynamic link module";
 
@@ -814,16 +912,17 @@ private: // conn client library funcs li
 
 } *OracleSQL_driver;
 
-void check(
-	SQL_Driver_services& services, OracleSQL_connection_struct &cs, 
-	const char *step, sword status) {
+void check(OracleSQL_connection_struct &cs, const char *step, sword status) {
 
 	const char *msg;
 	char reason[MAX_STRING/2];
 
+	const char *prefix="ERROR";
 	switch (status) {
-	case OCI_SUCCESS:
-		return; // hurrah
+	case OCI_SUCCESS: // hurrah
+	case OCI_SUCCESS_WITH_INFO:		// ignoring. example: count(column) when column contains NULLs, 
+														// count() not counting them and gives that status
+		return;
 	case OCI_ERROR:
 		{
 		sb4 errcode;
@@ -834,8 +933,6 @@ void check(
 			msg="[can not get error description]";
 		break;
 		}
-	case OCI_SUCCESS_WITH_INFO:
-		msg="SUCCESS_WITH_INFO"; break;
 	case OCI_NEED_DATA:
 		msg="NEED_DATA"; break;
 	case OCI_NO_DATA:
@@ -855,6 +952,10 @@ void check(
 	longjmp(cs.mark, 1);
 }
 
+void check(OracleSQL_connection_struct &cs, bool error) {
+	if(error)
+		longjmp(cs.mark, 1);
+}
 
 /* ----------------------------------------------------------------- */
 /* Intbind callback that does not do any data input.                 */
@@ -892,18 +993,18 @@ static sb4 cbf_get_data(dvoid *ctxp,
 
 	if(index==0) {
 		static ub4  rows;
-		check(*context.services, *context.cs, "AttrGet cbf_get_data ROWS_RETURNED", 
+		check(*context.cs, "AttrGet cbf_get_data ROWS_RETURNED", 
 			OracleSQL_driver->OCIAttrGet(
 				(CONST dvoid *) bindp, OCI_HTYPE_BIND, (dvoid *)&rows, 
 				(ub4 *)sizeof(ub2), OCI_ATTR_ROWS_RETURNED, context.cs->errhp))	;
 		context.rows->count=(ub2)rows;
 		context.rows->row=(OracleSQL_query_lobs::return_rows::return_row *)
-			context.services->malloc(sizeof(OracleSQL_query_lobs::return_rows::return_row)*rows);
+			context.services->malloc_atomic(sizeof(OracleSQL_query_lobs::return_rows::return_row)*rows);
 	}
 
 	OracleSQL_query_lobs::return_rows::return_row &var=context.rows->row[index];
 
-	check(*context.services, *context.cs, "alloc output var desc dynamic", OracleSQL_driver->OCIDescriptorAlloc(
+	check(*context.cs, "alloc output var desc dynamic", OracleSQL_driver->OCIDescriptorAlloc(
 		(dvoid *) context.cs->envhp, (dvoid **)&var.locator, 
 		(ub4)OCI_DTYPE_LOB, 
 		0, (dvoid **)0));